svn commit: r391915 - in /struts/action/trunk: assembly/ assembly/src/ assembly/src/main/ assembly/src/main/assembly/ assembly/src/main/resources/ core/

2006-04-05 Thread wsmoak
Author: wsmoak Date: Wed Apr 5 23:46:14 2006 New Revision: 391915 URL: http://svn.apache.org/viewcvs?rev=391915&view=rev Log: Configure the source and javadoc plugins for struts-core, and add a simple assembly. Run 'mvn install' from action/build, then 'mvn assembly:assembly' from action/assemb

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

[action1] cleaning up the build

2006-04-05 Thread James Mitchell
I'd like to address some the current [action 1] build issues. Now that we've simplified the directory structure (thanks Don!), I'd like to spend some time on our build process. Please comment on the following, if I don't hear back soon I'll go ahead and take care of these... 1. sample

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
I'm using a stock download of 2.0.3. Oh how I dream of finding the missing manual for Maven 2 command line options :( -- James Mitchell On Apr 6, 2006, at 1:25 AM, Wendy Smoak wrote: On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: I was pleasantly surprised (after making my chan

Re: [Action2] Replacing the OpenSymphony copyright

2006-04-05 Thread Rob Leland
Don Brown wrote: Don, you do know that there are automated tools in the Apache 'commiters' repository to replace copyrights ? I used 2 different version one in Java and one in Jython. While it's been about 2 years since I looked it's probably still there. -Rob While I don't mind doing

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > I was pleasantly surprised (after making my changes to the 4 or 5 > tests in core) to run 'mvn install' in struts/action/build/ and see > the reactor kick off and fully build/test/install all/some of SAF. > Same for compile, test, and a few ot

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > Why 2.0.4? Building from source?!? Jeez! At least I'm not _that_ > bad ;) Because 2.0.3 had some serious regressions, and it was just as easy to grab the 2.0.4 release candidate as to go back to 2.0.2. It's the plugins I'm building from so

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
Why 2.0.4? Building from source?!? Jeez! At least I'm not _that_ bad ;) I'm more inclined to work on a Maven 2 build and just remove whatever is in our way (e.g. failing tests, bad reports due to incomplete plugins, etc) to get to a distributable release. What do you think? -- James Mi

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
That is probably what we would have done if we hadn't had to deal with the {subproject}/build having to be svn:externals-ized into each one. I was pleasantly surprised (after making my changes to the 4 or 5 tests in core) to run 'mvn install' in struts/action/build/ and see the reactor ki

validator issues

2006-04-05 Thread victor ying
Hi All, I am using struts 1.2.7 and related Apache commons validator with validation.xml(whose rules are defined by validator-rules.xml) I need your insight of following issues 1.How do I validate open set data range,e,g (1,10) where 1 and 10 are exclusive, current intRange/floatRange va

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > Notice the console outputs "FAILURE !!", which make it pretty easy to > spot ;) I notice it, I'm just not seeing it here. FWIW, I'm using a snapshot of Maven 2.0.4 and quite a few plugins built from source. Maven 2 is still a work in progre

svn commit: r391892 - in /struts/shale/trunk/build: core-library/project.xml spring/project.xml tiles/project.xml

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 20:47:12 2006 New Revision: 391892 URL: http://svn.apache.org/viewcvs?rev=391892&view=rev Log: artifactId is the preferred tag for identification and groupId/artifactId is the preferred tag for dependencies Modified: struts/shale/trunk/build/core-library/pr

svn commit: r391890 - in /struts/sandbox/trunk: ./ extras/ mailreader-chain/ struts-jericho/ ti/phase2/wars/example/ ti/phase2/wars/samples-jsf/ tiles-documentation/ tiles/tiles-documentation/

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 20:45:03 2006 New Revision: 391890 URL: http://svn.apache.org/viewcvs?rev=391890&view=rev Log: artifactId is the preferred tag for identification and groupId/artifactId is the preferred tag for dependencies Modified: struts/sandbox/trunk/extras/project.xml

svn commit: r391889 - in /struts/action/trunk: faces/project.xml taglib/project.xml

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 20:43:35 2006 New Revision: 391889 URL: http://svn.apache.org/viewcvs?rev=391889&view=rev Log: artifactId is the preferred tag for identification and groupId/artifactId is the preferred tag for dependencies Modified: struts/action/trunk/faces/project.xml

DO NOT REPLY [Bug 39156] - [Shale] client side commons validation not working inside a dataList

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37932] - [Shale] Commons validator ignores the immediate attribute when using client side validation

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 39171] - commons validitor throws exception with float and double.

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r391884 - in /struts/shale/trunk/core-library/src: conf/ java/org/apache/shale/component/ java/org/apache/shale/faces/ java/org/apache/shale/renderer/ java/org/apache/shale/view/faces/

2006-04-05 Thread gvanmatre
Author: gvanmatre Date: Wed Apr 5 19:46:34 2006 New Revision: 391884 URL: http://svn.apache.org/viewcvs?rev=391884&view=rev Log: Fix for bugs 37932, 39171 and 39156 reported by Mark Shifman and Paul Devine. Added: struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ValidatorRend

svn commit: r391880 - /struts/action/trunk/build/README

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 19:39:45 2006 New Revision: 391880 URL: http://svn.apache.org/viewcvs?rev=391880&view=rev Log: Bring README up to date wrt SAF Modified: struts/action/trunk/build/README Modified: struts/action/trunk/build/README URL: http://svn.apache.org/viewcvs/struts/a

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
Before my changes, they fail for me on maven 1, when instrumented for jcoverage (which is the case for the 'dist' target) and maven 2 when run normally (mvn install). Maven 1 --- ... ... [junit] Running org.apache.struts.action.TestActionRedirect [junit] Tests run: 5, Failures:

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > Also, I'm about to start another thread related to our build...it is > (more or less) notes as I go through the various project.xml, > pom.xml, etc, etc for each of the pieces of the action1 puzzle. What do you think about moving the build fi

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, Don Brown <[EMAIL PROTECTED]> wrote: > Weird, so your Maven thinks that the tests fail? The tests pass for me, for > the core module anyways. The tests don't fail for me, either. They're just noisy with stack traces. Don, 'maven nightly' continues to work fine here. I deleted org.

svn commit: r391853 - in /struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages: Missing.jsp Welcome.jsp

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 16:51:30 2006 New Revision: 391853 URL: http://svn.apache.org/viewcvs?rev=391853&view=rev Log: mailreader app * Add lab 1-1. Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Missing.jsp (with props) struts/sandbox/trun

svn commit: r391850 - in /struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src: lab-1-1-src.iml lab-1-2-src.iml src/test/RetainTest.java src/webapp/pages/Missing.jsp src/webapp/pages/Welcome.jsp

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 16:50:33 2006 New Revision: 391850 URL: http://svn.apache.org/viewcvs?rev=391850&view=rev Log: (empty) Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/lab-1-2-src.iml struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/src/test/Ret

svn commit: r391847 - in /struts/sandbox/trunk/mailreader-course/action2: lab-1-2-src/ mailreader-course-action2.ipr

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 16:47:38 2006 New Revision: 391847 URL: http://svn.apache.org/viewcvs?rev=391847&view=rev Log: mailreader app * Add lab 1-2. Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/ - copied from r391821, struts/sandbox/trunk/mailreader-course/

svn commit: r391822 - /struts/action/trunk/apps/blank/project.xml

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 14:42:08 2006 New Revision: 391822 URL: http://svn.apache.org/viewcvs?rev=391822&view=rev Log: bring blank/project.xml inline with other apps Modified: struts/action/trunk/apps/blank/project.xml Modified: struts/action/trunk/apps/blank/project.xml URL: htt

svn commit: r391816 - in /struts/sandbox/trunk/action2: README.txt apps/mailreader/src/java/applicationContext.xml apps/mailreader/src/webapp/WEB-INF/applicationContext.xml apps/mailreader/src/webapp/

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 14:22:35 2006 New Revision: 391816 URL: http://svn.apache.org/viewcvs?rev=391816&view=rev Log: mailreader app * Move Spring configuration file to classpath README.txt * A couple of more suggestions for the cookbook jar. Added: struts/sandbox/trunk/action2/ap

svn commit: r391814 - in /struts/sandbox/trunk/mailreader-course/action2: lab-1-0-src/src/java/ lab-1-0-src/src/webapp/WEB-INF/ lab-1-0-src/src/webapp/pages/ lab-1-1-src/src/java/ lab-1-1-src/src/test

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 14:17:54 2006 New Revision: 391814 URL: http://svn.apache.org/viewcvs?rev=391814&view=rev Log: mailreader-course/action2 * Change "Home" to "Hello" * Move Spring configuration file to classpath Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src

svn commit: r391812 - /struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 14:15:01 2006 New Revision: 391812 URL: http://svn.apache.org/viewcvs?rev=391812&view=rev Log: skip these for now, this is easier than -Dmaven.skip.tests Modified: struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java Modified:

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Don Brown
James Mitchell wrote: Funny you should mention this now. About 10 minutes ago I (locally) commented the failing tests out (actually, I put 'no' in front of the failing testFoo methods, so it looks like 'notestFoo') so I could 'mvn eclipse:eclipse' core, taglib, and extras. I'm not sure why t

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
Funny you should mention this now. About 10 minutes ago I (locally) commented the failing tests out (actually, I put 'no' in front of the failing testFoo methods, so it looks like 'notestFoo') so I could 'mvn eclipse:eclipse' core, taglib, and extras. I'm not sure why the output of the tes

svn commit: r391796 - in /struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src: java/Hello.java java/Home.java java/resources.properties test/HelloTest.java test/HomeTest.java webapp/pages/H

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 13:37:48 2006 New Revision: 391796 URL: http://svn.apache.org/viewcvs?rev=391796&view=rev Log: mailreader-course/action2 * Change "Home" to "Hello" Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java - copied, changed f

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r391792 - in /struts/sandbox/trunk/mailreader-course/action2: ./ lab-1-0-src/src/java/ lab-1-0-src/src/webapp/WEB-INF/ lab-1-1-src/ lab-1-1-src/src/java/ lab-1-1-src/src/webapp/

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 13:32:14 2006 New Revision: 391792 URL: http://svn.apache.org/viewcvs?rev=391792&view=rev Log: mailreader-course/action2 * Add lab 1-1. Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/applicationContext.xml - copied unchanged

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Don Brown
The "nightly" maven goal isn't working for me. It doesn't seem to be correctly executing the jar:install goal, causing other artifact builds to fail due to missing dependencies. Perhaps someone seems something I'm missing from this snippet from a nightly build: +--

DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
.current is now .gone and so now I just need to fix the good one to actually work correctly and we'll have our nightlies back. -- James Mitchell On Apr 4, 2006, at 1:01 PM, James Mitchell wrote: I believe the .current one is an older copy. I'll clean that up shortly. -- James Mitchell

svn commit: r391736 - /struts/current/

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 12:20:35 2006 New Revision: 391736 URL: http://svn.apache.org/viewcvs?rev=391736&view=rev Log: remove alphabeticalizationnessless from the list ;) Modified: struts/current/ (props changed) Propchange: struts/current/ --

svn commit: r391727 - /struts/action/trunk/build/maven-nightly.sh.current

2006-04-05 Thread jmitchell
Author: jmitchell Date: Wed Apr 5 12:10:02 2006 New Revision: 391727 URL: http://svn.apache.org/viewcvs?rev=391727&view=rev Log: remove old nightly script Removed: struts/action/trunk/build/maven-nightly.sh.current - To un

svn commit: r391716 - /struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.iws

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 11:53:53 2006 New Revision: 391716 URL: http://svn.apache.org/viewcvs?rev=391716&view=rev Log: mailreader-course/action2 * Remove local settings file. Removed: struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.iws

svn commit: r391695 - /struts/action/trunk/build/maven.xml

2006-04-05 Thread mrdon
Author: mrdon Date: Wed Apr 5 11:18:43 2006 New Revision: 391695 URL: http://svn.apache.org/viewcvs?rev=391695&view=rev Log: Adding struts-faces directory to nightly target Modified: struts/action/trunk/build/maven.xml Modified: struts/action/trunk/build/maven.xml URL: http://svn.apache.or

DO NOT REPLY [Bug 39213] - Wildcard action matcher does not set module in forward

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r391690 - in /struts/action/trunk/core/src: java/org/apache/struts/config/ActionConfigMatcher.java test/org/apache/struts/config/TestActionConfigMatcher.java

2006-04-05 Thread mrdon
Author: mrdon Date: Wed Apr 5 10:54:46 2006 New Revision: 391690 URL: http://svn.apache.org/viewcvs?rev=391690&view=rev Log: Adding module property to wildcard replacement for forward configs PR: 39213 Modified: struts/action/trunk/core/src/java/org/apache/struts/config/ActionConfigMatcher.

svn commit: r391621 - in /struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2: Constants.java MailreaderSupport.java

2006-04-05 Thread husted
Author: husted Date: Wed Apr 5 07:06:41 2006 New Revision: 391621 URL: http://svn.apache.org/viewcvs?rev=391621&view=rev Log: MailReader * Change "magic" logon to text ExpiredPasswordException Modified: struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/Constants.java

DO NOT REPLY [Bug 39213] New: - Wildcard action matcher does not set module in forward

2006-04-05 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu