Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Bob Lee
I actually didn't understand the * scheme until someone explained it to me. On the other hand, I think I'd grok a scheme which used explicit names pretty quickly. Ant may use "*/**" for paths, but you don't reference indexed parts of the match, do you? Bob On 7/25/06, Don Brown <[EMAIL PROTECTE

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread tm jee
This might not be related, but I like the way Jason does it, and its the way I'd like to do it as well, especailly since I learn that foo!bar is going to get deprecated. - Original Message From: Jason Carreira <[EMAIL PROTECTED]> To: dev@struts.apache.org Sent: Wednesday, 26 July, 2006

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Don Brown
Good ideas. The question is really what would be most intuitive and cover the most common use cases. The */** syntax seems pretty common, and, IMO, very intuitive used in tools like Ant. If we abstract the wildcard handling, we could allow users to switch in a new impl easily for more advanc

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Bob Lee
{foo*} could match slashes. Or {/foo}. Or {{foo}}. We could also use regular expressions--they support this sort of group matching and results. Bob On 7/25/06, Don Brown <[EMAIL PROTECTED]> wrote: Struts 2 (XWork 2 actually) currently does not support this syntax. The main advantage the curr

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Don Brown
Struts 2 (XWork 2 actually) currently does not support this syntax. The main advantage the current "*" token scheme has is "**" which can match any character including '/' while "*" matches all characters except '/'. Now, it should be possible to abstract the wildcard handling/processing so t

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Bob Lee
It doesn't, but I think it should. (Yes, Ted, I should do it then. ;)) Bob On 7/25/06, tm jee <[EMAIL PROTECTED]> wrote: Just out of curiosity, the "invoice/{method}" and "{method}" pair, does the current implementation of Struts2 wildcard supports this? Looks a lot more clearer than the "invo

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread tm jee
Just out of curiosity, the "invoice/{method}" and "{method}" pair, does the current implementation of Struts2 wildcard supports this? Looks a lot more clearer than the "invoice/*" and "{1}" pair. rgds - Original Message From: Bob Lee <[EMAIL PROTECTED]> To: Struts Developers List Se

Re: [jira] Updated: (SITE-13) Enable nightly and continuous integration builds

2006-07-25 Thread James Mitchell
By the way, there's no secret handshake or anything for any committer to get an account our zone, just ask and I'll hook you right up. We can pretty much do what we want with it...well, anything inside the limits of morality and ASF policy. Here's more info on the zones: http://apache.org/

Re: [s2] auto build

2006-07-25 Thread James Mitchell
I'm looking into getting that fixed along with the other nightly builds as well. Just waiting for the Maven 2/solaris zone issue to resolve. Now that Continuum is (or was) up and running, I'd like to let Continuum publish the web site as well. More on this later (and probably in a diffe

Re: Location for nightly builds

2006-07-25 Thread James Mitchell
It clears everything under /www/people.apache.org/builds/struts/ I know I said "cvs.apache.org" last time, but that's really just a symlink over to the above locationI've had that cron job for a while ;) I have disabled it for now, until we find a better solutions...look for a follow

RE: [VOTE] Struts 1.3.5 Quality

2006-07-25 Thread James Holmes
Based on the issues Hubert Rabago and Wendy pointed out... [ ] Alpha [X] Beta [ ] General Availability (GA) James -Original Message- From: Wendy Smoak [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 25, 2006 11:02 PM To: Struts Developers List Subject: Re: [VOTE] Struts 1.3.5 Quality On

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Bob Lee
On 7/25/06, Don Brown <[EMAIL PROTECTED]> wrote: /template/eplus/metaDataList.ftl ... Or: /template/eplus/metaDataList.ftl ... Bob - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL P

Re: [VOTE] Struts 1.3.5 Quality

2006-07-25 Thread Wendy Smoak
On 7/23/06, Ted Husted <[EMAIL PROTECTED]> wrote: Once you have had a chance to review this test build, please respond with a vote on its quality: [ ] Alpha [X] Beta [ ] General Availability (GA) * The struts-faces examples will not deploy on Tomcat 4.1.31 / JDK 1.4.2. (I think web.xml is in

Re: Returning Result directly (was Re: DefaultActionMapper compatablity swi

2006-07-25 Thread Ted Husted
On 7/25/06, Bob Lee <[EMAIL PROTECTED]> wrote: Some people want a simpler, more or less flexible approach in addition to the current one, and there's nothing wrong with that; I was just responding with some brainstorming. Feel free to throw out better ideas. Maybe it's time to open a ticket for

Re: Returning Result directly (was Re: DefaultActionMapper compatablity swi

2006-07-25 Thread Bob Lee
On 7/25/06, Jason Carreira <[EMAIL PROTECTED]> wrote: What happened to not coupling code to the framework? That's one of many factors that should impact a design decision. Oh please no... please no abstract methods with magic implementations. What happens when you go to debug the class? Th

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Don Brown
Jason Carreira wrote: Could you give an example how multiple mappings for a single action is used with common CRUD actions? Don Ok, here's what our Invoice CRUD action mappings look like: /template/eplus/metaDataList.ftl

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Jason Carreira
> Could you give an example how multiple mappings for a > single action is > used with common CRUD actions? > > Don Ok, here's what our Invoice CRUD action mappings look like: /template/eplus/metaDataList.ftl

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Ted Husted
On 7/25/06, Jason Carreira <[EMAIL PROTECTED]> wrote: Why are we trying to follow what Stripes has done? I'm sure Stripes is nice, but why do we need to try to follow what it does instead of trying to figure out what makes the most sense to us? Why not start with what Stripes has done, and th

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Don Brown
Could you give an example how multiple mappings for a single action is used with common CRUD actions? Don Jason Carreira wrote: I'm sure some people do, but the question is in what percentages? I have done it, but only a couple of times, perhaps representing 2-3% of my actions. Since the X

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Jason Carreira
> > Though, I would strongly suggest that we try to > follow the Stripes > annotations wherever possible. And if there's a hard > reason why we > want to use a different term, we should work with Tim > on an > alternative. There's really no reason to have two > annotation APIs that > are trying to

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Jason Carreira
> I'm sure some people do, but the question is in what > percentages? I have done > it, but only a couple of times, perhaps representing > 2-3% of my actions. Since > the XML configuration way is still an option, I think > orienting the framework to > make the more common things easier, yet st

Re: Returning Result directly (was Re: DefaultActionMapper compatablity swi

2006-07-25 Thread Jason Carreira
> Instead of returning a Result object, we can also > consider calling out to a > result method. This is how Rails works. For example: > > class FooAction ... { > > Foo foo = new Foo(); // populated from request > parameters. > public void create() { > if (foo.isValid()) > redirectTo("Li

Re: Fixing Jira tickets

2006-07-25 Thread Wendy Smoak
On 7/25/06, Hubert Rabago <[EMAIL PROTECTED]> wrote: Thanks. Looks like it's working: https://issues.apache.org/struts/browse/STR-2917 Great! See, if I leave things on my TODO list long enough, they fix themselves. :) I think Jeff upgraded JIRA recently, that probably did it. -- Wendy ---

Re: Fixing Jira tickets

2006-07-25 Thread Hubert Rabago
On 7/25/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: If you refer to the issue number in the commit message, it should show up on the 'Subversion Commits' tab on the issue after a little while. I don't think that's working right now, though. We probably need to open a ticket with infrastructure to

Re: Fixing Jira tickets

2006-07-25 Thread Ted Husted
On 7/25/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: On 7/25/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: > After the fact, just add a comment with the ViewVC URL to the commit. Bad job of editing. Trying again: If you commit without mentioning the issue number in the commit message, then just ad

Re: Fixing Jira tickets

2006-07-25 Thread Wendy Smoak
On 7/25/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: After the fact, just add a comment with the ViewVC URL to the commit. Bad job of editing. Trying again: If you commit without mentioning the issue number in the commit message, then just add a comment to the issue with the revision number.

Re: Fixing Jira tickets

2006-07-25 Thread Wendy Smoak
On 7/25/06, Hubert Rabago <[EMAIL PROTECTED]> wrote: The last time I fixed a bug, we were still using Bugzilla. Anything I need to know before marking a Jira ticket as fixed? For instance, how do they get linked to an svn commit? Is it in the commit message? If you refer to the issue number

Fixing Jira tickets

2006-07-25 Thread Hubert Rabago
The last time I fixed a bug, we were still using Bugzilla. Anything I need to know before marking a Jira ticket as fixed? For instance, how do they get linked to an svn commit? Is it in the commit message? Hubert - To unsubsc

Re: Location for nightly builds

2006-07-25 Thread Ted Husted
On 7/25/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: Ted, can you put the 1.3.5 distributions back in http://people.apache.org/builds/struts/1.3.5/ ? Done. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-m

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Ted Husted
On 7/25/06, Jason Carreira <[EMAIL PROTECTED]> wrote: @Action to mark it as an Action method? On 7/25/06, Bob Lee <[EMAIL PROTECTED]> wrote: +1 for @Action Action is already so overloaded, it's painful to see us trying to reuse it again in another context. Sure, we have an Action interface,

Re: Returning Result directly (was Re: DefaultActionMapper compatablity switch)

2006-07-25 Thread Ted Husted
On 7/25/06, Don Brown <[EMAIL PROTECTED]> wrote: however we would have to thoroughly think through the consequences. Which in my mind puts it on the map for phase 2 / Struts 3. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED

Re: Location for nightly builds

2006-07-25 Thread Wendy Smoak
On 7/25/06, James Mitchell <[EMAIL PROTECTED]> wrote: Sorry, I've been a little slow with keeping up on list traffic these last few weeks, but why are we using this location for anything other than nightly builds? The nightly cron job will clear out anything older than 7 days starting at /www/cv

Re: Location for nightly builds

2006-07-25 Thread Ted Husted
Until we have nightly builds again, it's my intent to run these at least every week. Does the cron job clear out everything under 2.0.x, or just the nightly subdirectory? (Has the cron job been updated to use 2.0.x instead of 2.x?) In any event, next time I can just open a 2.0.0 for the weekly

Re: Location for nightly builds

2006-07-25 Thread James Mitchell
Sorry, I've been a little slow with keeping up on list traffic these last few weeks, but why are we using this location for anything other than nightly builds? The nightly cron job will clear out anything older than 7 days starting at /www/cvs.apache.org/builds/struts. Should I turn this o

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Bob Lee
+1 for @Action On 7/25/06, Jason Carreira <[EMAIL PROTECTED]> wrote: > > > Works for me. What should we call this annotation? > @Published? @Action to mark it as an Action method? - Posted via Jive Forums http://forums.opensy

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Don Brown
I'm sure some people do, but the question is in what percentages? I have done it, but only a couple of times, perhaps representing 2-3% of my actions. Since the XML configuration way is still an option, I think orienting the framework to make the more common things easier, yet still allowing m

Re: Returning Result directly (was Re: DefaultActionMapper compatablity switch)

2006-07-25 Thread Bob Lee
Instead of returning a Result object, we can also consider calling out to a result method. This is how Rails works. For example: class FooAction ... { Foo foo = new Foo(); // populated from request parameters. public void create() { if (foo.isValid()) redirectTo("ListFoos"); else

Re: Returning Result directly (was Re: DefaultActionMapper compatablity

2006-07-25 Thread Jason Carreira
Ugh, not this again... Doesn't anyone else reuse their actions and map them in several different ways? > > I personally would like to see XWork enhanced to > support action methods > returning Result instances directly, however we would > have to thoroughly think > through the consequences. >

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Michael Jouravlev
On 7/25/06, Ted Husted <[EMAIL PROTECTED]> wrote: On 7/25/06, Jason Carreira <[EMAIL PROTECTED]> wrote: > @Action to mark it as an Action method? Stripes uses the annontation @DefaultHandler where we would configure a default action, which might imply the annotation @Handler for what we are talk

Returning Result directly (was Re: DefaultActionMapper compatablity switch)

2006-07-25 Thread Don Brown
Tim Fennell wrote: I was going to chime in on this, so I may as well now. Stripes, through it's default way of routing events, will allow a submitted form or URL to invoke any method that is public no-arg and returns a Resolution - this seems much safer because Resolution is a Stripes specific

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Tim Fennell
While it might imply that, Stripes actually uses @HandlesEvent Which can take an optional String parameter which is the name of the handled event (which is defaulted to the method name otherwise) I was going to chime in on this, so I may as well now. Stripes, through it's default w

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Ted Husted
On 7/25/06, Ted Husted <[EMAIL PROTECTED]> wrote: On 7/25/06, Jason Carreira <[EMAIL PROTECTED]> wrote: > @Action to mark it as an Action method? Stripes uses the annontation @DefaultHandler where we would configure a default action, which might imply the annotation @Handler for what we are talk

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Ted Husted
On 7/25/06, Jason Carreira <[EMAIL PROTECTED]> wrote: @Action to mark it as an Action method? Stripes uses the annontation @DefaultHandler where we would configure a default action, which might imply the annotation @Handler for what we are talking about here. * http://stripes.mc4j.org/confluen

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Frank W. Zammetti
Sorry about the double-post, thought I hit cancel in time :) Speaking of @Remotable... might that make a good tie-in for the DWR integration, or indeed any other AJAX-type integration? Kill two birds with one stone is what I'm getting at... marks a method as available for DWR/AJAX remoting, as we

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Frank W. Zammetti
@Callable or @Executable, so it's more explicit? Maybe even @Remotable? (nah, probably not) Frank -- Frank W. Zammetti Founder and Chief Software Architect Omnytex Technologies http://www.omnytex.com AIM: fzammetti Yahoo: fzammetti MSN: [EMAIL PROTECTED] Java Web Parts - http://javawebparts.sou

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Frank W. Zammetti
@Callable or @Executable, so it's somewhat more explicit? Frank -- Frank W. Zammetti Founder and Chief Software Architect Omnytex Technologies http://www.omnytex.com AIM: fzammetti Yahoo: fzammetti MSN: [EMAIL PROTECTED] Java Web Parts - http://javawebparts.sourceforge.net Supplying the wheel, s

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Jason Carreira
> > > Works for me. What should we call this annotation? > @Published? @Action to mark it as an Action method? - Posted via Jive Forums http://forums.opensymphony.com/thread.jspa?threadID=38338&messageID=75682#75682 --

Re: 1.x docs & Maven

2006-07-25 Thread Wendy Smoak
On 7/18/06, Ted Husted <[EMAIL PROTECTED]> wrote: Of course, there are reasons why we aren't using beta-5 :) It has "issues". :) I just set the Shale build to beta-4 as well. Before coding against the Maven generated bookmarks, personally I'd wait for it to go GA. I'm thinking they might ch

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread David Evans
That all makes sense, and thanks to you, Bob and Ted for your openness in discussing these issues with a non-commiter. In looking through the snapshot, I'm really excited to see where things are going, this framework is going to be a joy to work with. dave On Tue, 2006-07-25 at 10:36 -0700, Don B

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Bob Lee
On 7/25/06, Don Brown <[EMAIL PROTECTED]> wrote: In the future, I could see an interceptor that checks the method specified for a method-level annotation, and only if it is present, allow the request to continue. Works for me. What should we call this annotation? @Published?

Re: DefaultActionMapper compatablity switch

2006-07-25 Thread Don Brown
_If_ you use a wildcard for an action, and _if_ you have that matched value as your method name, then yes, you are intentionally allowing anyone to access any method on that action class. This isn't a concern, IMO, because it was explicitly allowed by the developer, where the old capability was

Re: [Struts Wiki] Update of "StrutsDocComments" by MichaelJouravlev

2006-07-25 Thread Ted Husted
On 7/25/06, Michael Jouravlev <[EMAIL PROTECTED]> wrote: How would you differentiate actions that process one "flavor" of request (regular action) and actions that process several events (dispatch actions)? What about something like "coarse-grained handlers" and "fine-grained handles"? And which