Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Musachy Barroso
Don Brown wrote: I think the core issue is a misperception that Struts 2.0 is a clean slate, and therefore, we can remove/change any tags and attributes we wish. While this seems to be the case at first glance, Struts 2.0 is really a continuation of WebWork 2.2 and therefore, This hit me a

Re: [s1.3.6] Let's put a fork in it?

2006-12-09 Thread Wendy Smoak
On 12/9/06, Paul Benedict <[EMAIL PROTECTED]> wrote: I've successfully tested all applications but the faces application.If you can confirm it, we can proceed with the tagging. Struts 1 still has a snapshot dependency on its parent pom, so we need to wait for the struts-master release to happe

Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Don Brown
I think the core issue is a misperception that Struts 2.0 is a clean slate, and therefore, we can remove/change any tags and attributes we wish. While this seems to be the case at first glance, Struts 2.0 is really a continuation of WebWork 2.2 and therefore, we do have to worry about backward

Re: [s1.3.6] Let's put a fork in it?

2006-12-09 Thread Paul Benedict
Ted, I've successfully tested all applications but the faces application.If you can confirm it, we can proceed with the tagging. Paul - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECT

Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Musachy Barroso
Good that you mentioned 'cause I hadn't seen it. First thing, "notifyTopics" ,my bad, I forgot to fix it, easy to fix. The attributes that are a little bit problematic cause they were not consistent between the different tags are: preInvokeJS (in anchor, not in div), shouldn't this one be "bef

Re: [S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Martin Cooper
Oops! Forgot [1]: https://issues.apache.org/struts/browse/WW-1554 On 12/9/06, Martin Cooper <[EMAIL PROTECTED]> wrote: As Don has noted [1], there are some tag attributes (e.g. notifyTopics) that have disappeared recently. It seems that, included in the patch to upgrade Dojo to version 0.4, the

[S2] Tag attribute changes and Dojo upgrade

2006-12-09 Thread Martin Cooper
As Don has noted [1], there are some tag attributes (e.g. notifyTopics) that have disappeared recently. It seems that, included in the patch to upgrade Dojo to version 0.4, there were other changes that have caused incompatibility with earlier versions. I don't claim to be an expert on the tags, b

Re: [S2] Struts 2.0.2 Build - ON HOLD

2006-12-09 Thread Musachy Barroso
Yeah that one. The multiple(list) and multiple(array) are working, I hadn't tried'em before. The tests pass, that what the first thing I tried. I'll double-check to see if I figure it out. musachy Don Brown wrote: Nope, and I'm able to successfully upload a file on the single, multiple (array

Re: [S2] Struts 2.0.2 Build - ON HOLD

2006-12-09 Thread Don Brown
Another thing - if this was truly a bug, then our unit tests should be failing. Take a look at the file upload unit test and see if it is properly testing the feature. Don Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize)

Re: [S2] Experimental Features

2006-12-09 Thread Don Brown
I think our release notes, at a minimum, should have a list of plugins and features that are labeled "experimental". Of this list you provided, I would agree with all but the last one, since direct results was a very simple change. Zero conf is based on production code from Stripes, so an "ex

Re: [S2] Struts 2.0.2 Build - ON HOLD

2006-12-09 Thread Don Brown
Nope, and I'm able to successfully upload a file on the single, multiple (array), and multiple (list). To be clear, this page has the file upload tests that are failing? http://localhost:8080/struts2-showcase/fileupload/ Don Musachy Barroso wrote: Yeap, I always get "File cannot be empty" (v

Re: [S2] Struts 2.0.2 Build - ON HOLD

2006-12-09 Thread Musachy Barroso
Yeap, I always get "File cannot be empty" (validation upload.lenght() > 0 failing) message. Do you have any uncommitted changes? musachy Don Brown wrote: Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is ava

Re: [S2] Struts 2.0.2 Build - ON HOLD

2006-12-09 Thread Don Brown
Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a

Re: [S2] Struts 2.0.2 Build - ON HOLD

2006-12-09 Thread Musachy Barroso
setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a problem in 1.1.1. musachy Musachy Barroso wrote: The problem with the fileupload examples is that Don added t

Re: [S2] Struts 2.0.2 Build - ON HOLD

2006-12-09 Thread Musachy Barroso
The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the va

Re: [S2] Experimental Features

2006-12-09 Thread Wendy Smoak
On 12/9/06, Ted Husted <[EMAIL PROTECTED]> wrote: As implemented, these features seem solid and useful, but I wonder if anyone has a chance to use them all beyond "proof of concept" examples. (Wendy?) Me? I was playing with zero xml config in a prototype, (still needed struts.properties, but n

[S2] Experimental Features

2006-12-09 Thread Ted Husted
It's exciting to see that we've added a number of brave, new features since Struts 2.0.1. * codebehind plugin * zero configuration * REST-ful URLS * direct results As implemented, these features seem solid and useful, but I wonder if anyone has a chance to use them all beyond "proof of concept"

Re: svn commit: r484626 - in /struts/struts2/trunk: apps/showcase/src/main/java/org/apache/struts2/showcase/xslt/ apps/showcase/src/main/resources/ apps/showcase/src/main/webapp/xslt/ core/src/main/ja

2006-12-09 Thread David H. DeWolf
Ted Husted wrote: Is this related tt http://issues.apache.org/struts/browse/WW-1550 ? Yes, partially. I still think that the matchingPattern and excludingPattern should be reintroduced as well, but this definately helps with the majority of situations for which they are needed. It's ju

Re: svn commit: r484626 - in /struts/struts2/trunk: apps/showcase/src/main/java/org/apache/struts2/showcase/xslt/ apps/showcase/src/main/resources/ apps/showcase/src/main/webapp/xslt/ core/src/main/ja

2006-12-09 Thread Ted Husted
Is this related tt http://issues.apache.org/struts/browse/WW-1550 ? It's just that we're trying to link all the commits to JIRA issues, to simplify preparing the release notes. -Ted. On 12/8/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: ddewolf Date: Fri Dec 8 07:02:24 2006 New Rev

Re: [s1.3.6] Let's put a fork in it?

2006-12-09 Thread Ted Husted
In the normal course, we don't pre-distribute the intended libraries, and if we did it would be in "SNAPSHOT" form. We can't remove the "SNAPSHOT" moniker until we are ready to do the deed, otherwise there would be confusion as to which is the "real" release. First, the development groups tests i