Thanks. Updates coming up.
Niall Pemberton wrote:
From a visual scan, theres a few things that don't look quite right
to me.
1) setStyleIdExpr - this method is now duplicated - should have been
renamed to setTitleKeyExpr when copy/pasting? Would have thought this
doesn't compile - for me I wou
+1 for var. id is special and shouldn't be used -- it even has its own
W3C spec.
Martin Cooper wrote:
On 6/28/07, Musachy Barroso <[EMAIL PROTECTED]> wrote:
What would be the best way to get to an agreement on this? cast a vote?
I tend to feel that we're a bit too vote-happy around here, s
From a visual scan, theres a few things that don't look quite right to me.
1) setStyleIdExpr - this method is now duplicated - should have been
renamed to setTitleKeyExpr when copy/pasting? Would have thought this
doesn't compile - for me I would have hoped the code had been tested
before commit
On 6/28/07, Musachy Barroso <[EMAIL PROTECTED]> wrote:
What would be the best way to get to an agreement on this? cast a vote?
I tend to feel that we're a bit too vote-happy around here, so I'd prefer to
see us reach consensus instead, if we can.
So far, I haven't heard anyone voice objectio
I'm going to be substantially offline for the next week. Count this a vote
for "var."
Joe
On 6/28/07, Musachy Barroso <[EMAIL PROTECTED]> wrote:
What would be the best way to get to an agreement on this? cast a vote?
musachy
On 6/28/07, Martin Cooper <[EMAIL PROTECTED]> wrote:
>
> On 6/27/0
What would be the best way to get to an agreement on this? cast a vote?
musachy
On 6/28/07, Martin Cooper <[EMAIL PROTECTED]> wrote:
On 6/27/07, Joe Germuska <[EMAIL PROTECTED]> wrote:
>
> Sorry, I have been very absentee from Struts discussions, but I took a
> minute to review this one...
>
>
What comes firsta documents
or
Is this browser dependent?
For more backgound:
The login for my site uses a cookie value, this cookie was created on the
same domain but not in
the java request, so if I'm correct javascript is probably the only solution
I have to reading in this
client's
It probably is inconsistent now. At one point, I'm pretty sure the code was
consistent in using a 'this.' prefix only when necessary (e.g. in setters,
like "this.foo = foo"), but that's probably no longer true. Oh well.
--
Martin Cooper
On 6/28/07, Paul Benedict <[EMAIL PROTECTED]> wrote:
Yes
Yes, it is debatable. As I look through the Struts source code, I see this
principle applied inconsistently. Sometimes qualified; others not.
Otherwise, not a big deal. I could have not done it :-)
On 6/28/07, Martin Cooper <[EMAIL PROTECTED]> wrote:
The "best" part is debatable - it's certainl
The "best" part is debatable - it's certainly not one that I favour. ;-)
IMHO, it's redundant and clutters the code.
--
Martin Cooper
On 6/28/07, Paul Benedict <[EMAIL PROTECTED]> wrote:
That's not why I added it. I added it out of best practice.
On 6/28/07, Martin Cooper <[EMAIL PROTECTED]>
That's not why I added it. I added it out of best practice.
On 6/28/07, Martin Cooper <[EMAIL PROTECTED]> wrote:
On 6/26/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
> Author: pbenedict
> Date: Tue Jun 26 23:05:09 2007
> New Revision: 551067
>
> URL: http://svn.apache.org/viewvc?view=rev&
Hi,
I faced the same problem and found the cause.
Prior to Xwork 2.0.3 the objectTypeDeterminer property in XWorkConverter
was initialised using the instance created by the static block in
ObjectTypeDeterminerFactory. This static block determines which
implementation of the ObjectTypeDetermin
On 6/27/07, Joe Germuska <[EMAIL PROTECTED]> wrote:
Sorry, I have been very absentee from Struts discussions, but I took a
minute to review this one...
Acknowledging that consistency (between s:set, s:url, s:bean, etc) is good
but that "id" has specific semantics for HTML markup, what about usi
On 6/26/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: pbenedict
Date: Tue Jun 26 23:05:09 2007
New Revision: 551067
URL: http://svn.apache.org/viewvc?view=rev&rev=551067
Log:
STR-1175: Add instance qualification
Why? There doesn't appear to be any local variable for this one to be
14 matches
Mail list logo
