Re: [struts-dev] classpath issues...

2008-06-08 Thread Dale Newfield
Musachy Barroso wrote: Yes, try/catching errors there is a good idea. I will fix it, and log the exception. Thank you for adding that. Can I lobby you also modify your "make sure it's a file uri" check to be "make sure it's a non-opaque file uri"? (I.E.: Also check for !uri.isOpaque() .)

Re: [Struts2] Convention Plugin - @Result

2008-06-08 Thread Bob Tiernay
I think the log level should be bumped up one :) -- From: "Musachy Barroso" <[EMAIL PROTECTED]> Sent: Sunday, June 08, 2008 1:14 PM To: "Struts Developers List" Subject: Re: [Struts2] Convention Plugin - @Result Being there doesn't really mean th

Re: [POLL] Drop strutsel package from 1.4?

2008-06-08 Thread Martin Cooper
On Sat, Jun 7, 2008 at 10:16 PM, Paul Benedict <[EMAIL PROTECTED]> wrote: > Martin, would you find it acceptable to leave them where they are and just > relegate them to an optional build profile? That probably makes most sense; > if we still want them buildable (I think we do), then they really a

Re: [Struts2] Convention Plugin - @Result

2008-06-08 Thread Musachy Barroso
Being there doesn't really mean that they need a location, there are also result types on external plugins that we won't know about. We could change the warning message, or remove it altogether. musachy On Sun, Jun 8, 2008 at 11:38 AM, Bob Tiernay <[EMAIL PROTECTED]> wrote: > Can't you determine

Re: [Struts2] Convention Plugin - @Result

2008-06-08 Thread Bob Tiernay
Can't you determine these from struts.convention.relative.result.types? -- From: "Musachy Barroso" <[EMAIL PROTECTED]> Sent: Sunday, June 08, 2008 11:14 AM To: "Struts Developers List" Subject: Re: [Struts2] Convention Plugin - @Result Well, ther

Re: [Struts2] Convention Plugin - @Result

2008-06-08 Thread Musachy Barroso
Well, there are a few result that require "location", like velocity, freemarker and others. There is no way to know which one do or do no. To play on the safe side, a warning was added, but it is kind of weak indeed. musachy On Sun, Jun 8, 2008 at 10:59 AM, Bob Tiernay <[EMAIL PROTECTED]> wrote:

[Struts2] Convention Plugin - @Result

2008-06-08 Thread Bob Tiernay
I am trying to use the following in my LoginAction class: @Action(value = "login!login", results = [EMAIL PROTECTED](name = "success", type = "redirectAction", params = {"actionName", "ListAccounts", "namespace", "/account"} )}) public String login() throws Exception { Howeve

Re: [Struts2] Convention Plugin - Annotationd

2008-06-08 Thread Musachy Barroso
On Sun, Jun 8, 2008 at 10:36 AM, Bob Tiernay <[EMAIL PROTECTED]> wrote: > Well, by "convention" these things could be defined in the top most package > of the actions packages (ie. struts.convention.action.packages) in > package-info.java. This seems natural to me. > Yes, that would be the obvious

Re: [Struts2] Convention Plugin - Annotationd

2008-06-08 Thread Bob Tiernay
Well, by "convention" these things could be defined in the top most package of the actions packages (ie. struts.convention.action.packages) in package-info.java. This seems natural to me. I would think that at least the default interceptor-ref should be made available on package-info.java(s) b

Re: [Struts2] Convention Plugin - Annotationd

2008-06-08 Thread Musachy Barroso
I think that convention should support everything from the current xml configuration element "action" down. For things outside action, like global result, stacks, beans etc, is not really intuitive where the annotations should be. musachy On Sun, Jun 8, 2008 at 10:25 AM, Bob Tiernay <[EMAIL PROT

[Struts2] Convention Plugin - Annotationd

2008-06-08 Thread Bob Tiernay
I am currently trying to convert an existing project over to use the convention plugin. In, the process I discovered that it appears as though I cannot do the following with the annotations: 1. Declare interceptor annotations on package-info.java 2. Set a default interceptor ref (eg. for a pack