Re: hacking OGNL and parameter binding

2008-07-19 Thread Don Brown
Musachy, you need to mark the box that lets anyone join the review as a reviewer. As it is now, no one can comment. Don On Sat, Jul 19, 2008 at 12:47 AM, Musachy Barroso [EMAIL PROTECTED] wrote: I opened a code review here: http://fisheye6.atlassian.com/cru/CR-9 I added a new interface

Bamboo - Broken build

2008-07-19 Thread Nils-Helge Garli Hegvik
The Struts 2 main builds are currently failing, complaining about a missing xwork 2.1.2-SNAPSHOT dependency. The change from build 883 to 884 when it started to fail was minor and I can't see how that should have caused the failure. I guess something has been removed from a repository

Re: [s2] Struts 2 OSGi Plugin

2008-07-19 Thread alvins
Had a closer look into the jsp equinox handling and it looks like there is active development going on to support this - http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.equinox.jsp.jasper/. From what I have read (also did a quick test) the equinox servlet bridge can run in either container

Re: Bamboo - Broken build

2008-07-19 Thread Don Brown
Not sure where the xwork snapshot went, but I deployed it, ran the builds and they are now failing due to Musachy's last commit. Don On Sat, Jul 19, 2008 at 6:12 PM, Nils-Helge Garli Hegvik [EMAIL PROTECTED] wrote: The Struts 2 main builds are currently failing, complaining about a missing

Re: hacking OGNL and parameter binding

2008-07-19 Thread Musachy Barroso
duh..done :) On Sat, Jul 19, 2008 at 3:44 AM, Don Brown [EMAIL PROTECTED] wrote: Musachy, you need to mark the box that lets anyone join the review as a reviewer. As it is now, no one can comment. Don On Sat, Jul 19, 2008 at 12:47 AM, Musachy Barroso [EMAIL PROTECTED] wrote: I opened a

Re: hacking OGNL and parameter binding

2008-07-19 Thread Musachy Barroso
I'm not sure how to get permission to make comments in crucible. I guess we would have to benchmark it, but I don't see anything big going on, as the objects(like root, context, etc) are just set into the new stack. musachy -

Convention plugin: why not deployed to repo with 2.1.2?

2008-07-19 Thread Paul Benedict
Does anyone know why the convention plugin is not deployed to the repo for 2.1.2? PS: I wish the plugins had a namespace like the Maven plugins (i.e., org.apache.maven.plugins - org.apache.struts.plugins) Paul

Re: Convention plugin: why not deployed to repo with 2.1.2?

2008-07-19 Thread Musachy Barroso
Do we deploy things from the sandbox to the repo? musachy On Sat, Jul 19, 2008 at 7:25 PM, Paul Benedict [EMAIL PROTECTED] wrote: Does anyone know why the convention plugin is not deployed to the repo for 2.1.2? PS: I wish the plugins had a namespace like the Maven plugins (i.e.,

Re: Convention plugin: why not deployed to repo with 2.1.2?

2008-07-19 Thread Wendy Smoak
On Sat, Jul 19, 2008 at 9:35 PM, Musachy Barroso [EMAIL PROTECTED] wrote: Do we deploy things from the sandbox to the repo? That was my thought... isn't this a sandbox plugin? http://svn.apache.org/repos/asf/struts/sandbox/trunk/struts2-convention-plugin/ I would not expect to see it in the

Re: Convention plugin: why not deployed to repo with 2.1.2?

2008-07-19 Thread Paul Benedict
I wasn't aware it was a sandbox plugin when I wrote the email. I later found that out through SVN exploring, but I was mislead by the online documentation. I wish the S2 wiki noted it was a sandbox plugin. Paul On Sat, Jul 19, 2008 at 11:51 PM, Wendy Smoak [EMAIL PROTECTED] wrote: On Sat, Jul