Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
This is a problem of FreeMarker not being able to locate TLDs when running under Jetty. I ran Showcase under tomcat and it works fine. musachy On Sat, Dec 27, 2008 at 5:38 PM, Musachy Barroso wrote: > There is a problem with FreeMarker, hit this url in showcase: > http://localhost:8080/struts2-s

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
There is a problem with FreeMarker, hit this url in showcase: http://localhost:8080/struts2-showcase/tiles/freemarkerLayout.action JspTaglibs["http://tiles.apache.org/tags-tiles";] is undefined. It cannot be assigned to tiles at org.apache.struts2.tiles.StrutsTilesRequestContext.include(S

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
3 hours debugging, and the fix was one line of code :). Please test against trunk and let me know, it all seems to work for me. musachy On Sat, Dec 27, 2008 at 12:40 PM, Musachy Barroso wrote: > yes, that's a good idea, in fact there are some tags there, like > "url", wich do not fail. > > On Sa

Re: [VOTE] Struts 2.1.3 Quality

2008-12-27 Thread Wes Wannemacher
Should be done, it might have bulk mailed on 29 issues though, sorry :( -Wes On Sat, 2008-12-27 at 12:45 -0500, Musachy Barroso wrote: > yes, the good news is that rolling 2.1.4 won't be that painful. We > need to move the jira tickets to 2.1.5 leaving the one for this > problem, and the one I op

Re: [VOTE] Struts 2.1.3 Quality

2008-12-27 Thread Musachy Barroso
yes, the good news is that rolling 2.1.4 won't be that painful. We need to move the jira tickets to 2.1.5 leaving the one for this problem, and the one I opened for REST. musachy On Sat, Dec 27, 2008 at 12:40 PM, James Holmes wrote: > Fair enough. I agree. Does that mean we'll fix and roll a 2.1

Re: [VOTE] Struts 2.1.3 Quality

2008-12-27 Thread James Holmes
Fair enough. I agree. Does that mean we'll fix and roll a 2.1.4? On Sat, Dec 27, 2008 at 12:35 PM, Musachy Barroso wrote: > I am downgrading my vote to: > > +1 Leave at test build > > See https://issues.apache.org/struts/browse/WW-2937 for details. > Thanks Al, for testing and reporting. > musac

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
yes, that's a good idea, in fact there are some tags there, like "url", wich do not fail. On Sat, Dec 27, 2008 at 12:36 PM, Wes Wannemacher wrote: > I'll follow suit and rescind my vote as well... Should we add a tag > showcase's decorator so that it pops up when we test in the future? > > -Wes >

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Wes Wannemacher
I'll follow suit and rescind my vote as well... Should we add a tag showcase's decorator so that it pops up when we test in the future? -Wes On Sat, 2008-12-27 at 12:31 -0500, Musachy Barroso wrote: > never mind, just adding: > > > > to the main decorator makes fail, I will downgrade my vote.

Re: [VOTE] Struts 2.1.3 Quality

2008-12-27 Thread Musachy Barroso
I am downgrading my vote to: +1 Leave at test build See https://issues.apache.org/struts/browse/WW-2937 for details. Thanks Al, for testing and reporting. musachy On Fri, Dec 26, 2008 at 11:47 AM, Musachy Barroso wrote: > The Struts 2.1.3 test build is now available. > > Release notes: > * [htt

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
never mind, just adding: to the main decorator makes fail, I will downgrade my vote. musachy On Sat, Dec 27, 2008 at 12:23 PM, Musachy Barroso wrote: > I change the filter and filter mappings to the "old" ones, and > showcase still works, do you know what I would need to change to > reproduce

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
I change the filter and filter mappings to the "old" ones, and showcase still works, do you know what I would need to change to reproduce the problem? musachy On Sat, Dec 27, 2008 at 11:12 AM, Al Sutton wrote: > I'm sorry I didn't try the trunk sooner (too busy coding the site :(). > > The filt

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
yes, I agree, I just want to reproduce the problem and try to understand what is happening before doing it. musachy On Sat, Dec 27, 2008 at 12:19 PM, Paul Benedict wrote: > I say call 2.1.3 a bust and move onto making 2.1.4 GA. I had to do 3 > point releases from 1.3.5 to 1.3.8 to go GA. :-) Get

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Paul Benedict
I say call 2.1.3 a bust and move onto making 2.1.4 GA. I had to do 3 point releases from 1.3.5 to 1.3.8 to go GA. :-) Getting new features to work right universally is a tough job. Paul On Sat, Dec 27, 2008 at 11:04 AM, Musachy Barroso wrote: > You are not using the new filters, so I guess somet

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
You are not using the new filters, so I guess something is went wrong in that refactoring. I will see if I cand find the problem, but the release cannot go out like this. musachy On Sat, Dec 27, 2008 at 11:12 AM, Al Sutton wrote: > I'm sorry I didn't try the trunk sooner (too busy coding the sit

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Al Sutton
I'm sorry I didn't try the trunk sooner (too busy coding the site :(). The filters are; struts-cleanup org.apache.struts2.dispatcher.ActionContextCleanUp sitemesh com.opensymphony.module.sitemesh.filter.PageFilter struts org.apac

Re: Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Musachy Barroso
this one looks bad, how do you have your filters configured? I think we saw this before and had been fixed. musachy On Sat, Dec 27, 2008 at 4:50 AM, Al Sutton wrote: > Next problem; I'm seeing an exception being thrown in Freemarker which I > believe is a knock on effect from the sitemesh plugin

Struts 2.1.3 Quality - Freemarker/Sitemesh plugin issue

2008-12-27 Thread Al Sutton
Next problem; I'm seeing an exception being thrown in Freemarker which I believe is a knock on effect from the sitemesh plugin. When I set a breakpoint in FreemarkerTemplateEngine.renderTemplate there are several passes through where the servletcontext, request, and response objects are pulled