Re: sitemesh problem in 2.1.8

2009-10-20 Thread Christian Stone
So some of the sitemesh 3 code is in the latest drop apparently, and it is marked alpha. So I am doing 2 things... 1. Updating the existing filters code (FreeMarkerPageFilter and VelocityPageFilter) to use the PageFilter.java implementation in SiteMesh 2.3 (note that I presume that I can

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Wes Wannemacher
To help with both the patch creation and your sanity (matching up xwork and struts versions), work off of trunk for both of them. Check out xwork from subversion here - svn co http://svn.opensymphony.com/svn/xwork/trunk xwork and build it - cd xwork ; mvn clean install Then, checkout and build

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Christian Stone
Okay, I'll do it... will take perhaps a day (free time... you know). -- Christian On Oct 20, 2009, at 9:14 PM, Musachy Barroso wrote: I don't think anyone here knows much about the sitemesh codebase, so feel free to take a shot at it and ask for help here if you need it. thanks for reporting

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Musachy Barroso
I don't think anyone here knows much about the sitemesh codebase, so feel free to take a shot at it and ask for help here if you need it. thanks for reporting musachy On Tue, Oct 20, 2009 at 5:37 PM, Christian Stone wrote: > P.S.  Sorry about the posting on the vote thread. > > There is a good d

Re: sitemesh problem in 2.1.8

2009-10-20 Thread Christian Stone
P.S. Sorry about the posting on the vote thread. There is a good discussion about the three possible solutions with the bug (http://issues.apache.org/struts/browse/WW-3275). The easiest (but far from ideal) is to use the solution #2. However, there is a complete rewrite of PageFilter.jav

sitemesh problem in 2.1.8

2009-10-20 Thread Musachy Barroso
lets follow up here On Tue, Oct 20, 2009 at 4:02 PM, Musachy Barroso wrote: > I think you meant "sitemesh" instead of  freemarker right? FreeMarker > 2.3.15 is what is bundled with Struts 2.1.8.x. > > On Tue, Oct 20, 2009 at 3:54 PM, Christian Stone wrote: >> WW-3275 > > > > -- > Screw John Galt

Re: [VOTE] Struts 2.1.8.1 Vote

2009-10-20 Thread Martin Cooper
On Tue, Oct 20, 2009 at 3:54 PM, Christian Stone wrote: > Since Struts 2.1.8 is incompatible with FreeMarker 2.4 (bug  WW-2766 and > WW-3275) which is bundled in 2.1.8, I would hope you are delivering this > build with FreeMarker  2.2.1 (and actually it seems fine with 2.3 as well). >  However, th

Re: [VOTE] Struts 2.1.8.1 Vote

2009-10-20 Thread Musachy Barroso
I think you meant "sitemesh" instead of freemarker right? FreeMarker 2.3.15 is what is bundled with Struts 2.1.8.x. On Tue, Oct 20, 2009 at 3:54 PM, Christian Stone wrote: > WW-3275 -- Screw John Galt, who is Martin Gainty? ---

Re: [VOTE] Struts 2.1.8.1 Vote

2009-10-20 Thread Christian Stone
Since Struts 2.1.8 is incompatible with FreeMarker 2.4 (bug WW-2766 and WW-3275) which is bundled in 2.1.8, I would hope you are delivering this build with FreeMarker 2.2.1 (and actually it seems fine with 2.3 as well). However, there are a number of us who use FreeMarker and Sitemesh, a

Re: [VOTE] Struts 2.1.8.1 Vote

2009-10-20 Thread Wes Wannemacher
Here's my +1 GA... -Wes On Tue, Oct 20, 2009 at 5:49 PM, Musachy Barroso wrote: > +1 GA. I have been using it and it works fine. I also tested unzipping > the files in windows xp and that was fixed as well. > > musachy > > On Tue, Oct 20, 2009 at 2:26 PM, Wes Wannemacher wrote: >> The Struts 2.

Re: [VOTE] Struts 2.1.8.1 Vote

2009-10-20 Thread Musachy Barroso
+1 GA. I have been using it and it works fine. I also tested unzipping the files in windows xp and that was fixed as well. musachy On Tue, Oct 20, 2009 at 2:26 PM, Wes Wannemacher wrote: > The Struts 2.1.8 test build is now available. > > Release notes: > * [http://cwiki.apache.org/confluence/di

[VOTE] Struts 2.1.8.1 Vote

2009-10-20 Thread Wes Wannemacher
The Struts 2.1.8 test build is now available. Release notes: * [http://cwiki.apache.org/confluence/display/WW/Version+Notes+2.1.8.1] Distribution: * [http://people.apache.org/builds/struts/2.1.8.1/] Maven 2 staging repository: * [http://people.apache.org/builds/struts/2.1.8.1/m2-staging-reposito

Re: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Obinna
Tested it and it works for me! Great! Thanks a million. - Eric On Tue, Oct 20, 2009 at 9:13 PM, Musachy Barroso wrote: > small fix to JspApplicationContextImpl seems to make it work for > me(add the hash of the classloader to the key), give it a try and let > me know (update from trunk) > > mu

Re: http://struts.apache.org/dtds/struts-2.1.7.dtd NOT FOUND

2009-10-20 Thread Musachy Barroso
yeah it was xalan or xerces. On Tue, Oct 20, 2009 at 10:07 AM, Wes Wannemacher wrote: > On Tue, Oct 20, 2009 at 12:43 PM, Martin Cooper wrote: >> On Tue, Oct 20, 2009 at 8:24 AM, Musachy Barroso wrote: >>> If I don't remember wrong, there is a bug in tomcat, or one of its xml >>> deps that trie

Re: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Musachy Barroso
small fix to JspApplicationContextImpl seems to make it work for me(add the hash of the classloader to the key), give it a try and let me know (update from trunk) musachy On Tue, Oct 20, 2009 at 11:00 AM, Musachy Barroso wrote: > ok I was able to reproduce it, working on it (looks hairy) > > mus

Re: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Musachy Barroso
ok I was able to reproduce it, working on it (looks hairy) musachy On Tue, Oct 20, 2009 at 7:01 AM, Obinna wrote: > Ok, So I've been able to inspect the classloaders and I think I see what's > going wrong (though I'm not sure how best to fix it). > > Given my two webapps, AppA and AppB running s

Re: http://struts.apache.org/dtds/struts-2.1.7.dtd NOT FOUND

2009-10-20 Thread Wes Wannemacher
On Tue, Oct 20, 2009 at 12:43 PM, Martin Cooper wrote: > On Tue, Oct 20, 2009 at 8:24 AM, Musachy Barroso wrote: >> If I don't remember wrong, there is a bug in tomcat, or one of its xml >> deps that tries to get the dtd online. This has popped multiple times >> in user@ right? > > I guess that's

Re: http://struts.apache.org/dtds/struts-2.1.7.dtd NOT FOUND

2009-10-20 Thread Martin Cooper
On Tue, Oct 20, 2009 at 8:24 AM, Musachy Barroso wrote: > If I don't remember wrong, there is a bug in tomcat, or one of its xml > deps that tries to get the dtd online. This has popped multiple times > in user@ right? I guess that's possible. When this happened with S1, though, it was because so

Re: http://struts.apache.org/dtds/struts-2.1.7.dtd NOT FOUND

2009-10-20 Thread Wes Wannemacher
On Tue, Oct 20, 2009 at 11:24 AM, Musachy Barroso wrote: > If I don't remember wrong, there is a bug in tomcat, or one of its xml > deps that tries to get the dtd online. This has popped multiple times > in user@ right? > > musachy > You're right... There is some combination of jars that causes t

Re: http://struts.apache.org/dtds/struts-2.1.7.dtd NOT FOUND

2009-10-20 Thread Musachy Barroso
If I don't remember wrong, there is a bug in tomcat, or one of its xml deps that tries to get the dtd online. This has popped multiple times in user@ right? musachy On Tue, Oct 20, 2009 at 7:53 AM, Martin Cooper wrote: > On Tue, Oct 20, 2009 at 6:16 AM, Wes Wannemacher wrote: >> Yes, you can co

Re: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Musachy Barroso
ah, good stuff. It seems like whatever calls JspFactory.setDefaultFactory(...) is assuming there is only one JspFactory, which is usually true, we need to fix that. musachy On Tue, Oct 20, 2009 at 7:01 AM, Obinna wrote: > Ok, So I've been able to inspect the classloaders and I think I see what's

Re: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Musachy Barroso
yes, if it fails to cast to itself, it means that the class of the object being casted was loaded by a different classloader. I will try to debug and see if for both my dummy apps it is using the same JspFactoryImpl, which in theory it should not, I think. musachy On Tue, Oct 20, 2009 at 4:14 AM,

Re: http://struts.apache.org/dtds/struts-2.1.7.dtd NOT FOUND

2009-10-20 Thread Martin Cooper
On Tue, Oct 20, 2009 at 6:16 AM, Wes Wannemacher wrote: > Yes, you can copy the file... The files in 2.x might be overwritten, > but I don't know if there is any pointers to 'dtds' anywhere. I don't know what the situation is for S2, but that URL is *the* definitive reference to the DTDs for S1.

Re: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Obinna
Ok, So I've been able to inspect the classloaders and I think I see what's going wrong (though I'm not sure how best to fix it). Given my two webapps, AppA and AppB running simulatenously in tomcat. I do the following: 1. Load AppA a. Load normal jsp page (breakpoint not caught -> still usi

Re: http://struts.apache.org/dtds/struts-2.1.7.dtd NOT FOUND

2009-10-20 Thread Wes Wannemacher
Yes, you can copy the file... The files in 2.x might be overwritten, but I don't know if there is any pointers to 'dtds' anywhere. -Wes On Tue, Oct 20, 2009 at 1:58 AM, Lukasz Lenart wrote: > Can I copy the file? As I recall, Wes mentioned that all files will be > erased during a new release fro

RE: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Martin Gainty
Eric- are you able to determine which classloader JspApplicationContext is using to load JspApplicationContextImpl class? System.out.println("The class of " + JspApplicationContextImpl + " is " + JspApplicationContextImpl.getClass().getName()); Syste

Re: embeddedJsp plugin causing jsp compilation issues

2009-10-20 Thread Obinna
An update... I've tried setting a breakpoint in the JspApplicationContextImpl.getInstance() method and the JspFactoryImpl().getJspApplicationContext() methods but for some reason cannot inspect the variable at that point to figure out which classloader are being called when. What is clear is that