[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-09 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-78003822 That's the case, can you explain what you mean by non-struts2 context? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-09 Thread quaff
Github user quaff commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-77971388 ValueStack will be always not null with struts2 request, so It wouldn't change the behavior of struts2, this pull request is intend to use in non-struts2 context. --- If y

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-09 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-77833815 What I meant is that if `ValueStack` is missing in context something wrong happened, so solution to null-check is error-prone :) --- If your project is set up for it

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-09 Thread quaff
Github user quaff commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-77827292 @lukaszlenart , It doesn't add new thing just null-check added, It's safe if existing unit tests passed. --- If your project is set up for it, you can reply to this email a