[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-11 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-78426250 But you cannot pass `null` and expect that it will work properly, if you want such behaviour add method with signature that doesn't expect `ValueStack` --- If your p

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-11 Thread quaff
Github user quaff commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-78400068 It's just a static util class, It should be light and simple, your suggestion is opposite. --- If your project is set up for it, you can reply to this email and have your

[GitHub] struts-site pull request: Removed missing tag

2015-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts-site/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] struts pull request: Improve LocalizedTextUtil defend NPE

2015-03-11 Thread lukaszlenart
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/35#issuecomment-78242017 So you can use a `StubValueContext` like this one ```java public class StubValueStack implements ValueStack { Map ctx = new HashMap(); CompoundR