Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219829308
All the tags are implemented in FreeMarker, those archive templates are
deprecated and should be thrown away.
---
If your project is set up for it, you can reply to
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219829978
@lukaszlenart Ahh ok. Thanks for clarifying that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219826548
the css class for that cell is in the controlheader.ftl already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219826190
OH ok, got you
https://github.com/apache/struts/tree/master/core/src/main/resources/template/archive
I miss that.
---
If your project is set up for it, yo
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219824169
Yep, the aforementioned commit misses css class for that cell in the
`controlheader.ftl`. It should be the same way as for the buttons. :)
---
If your project is set
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219823160
How the Velocity templating is working? The only Velocity templates I see
are in the
[archive](https://github.com/apache/struts/tree/master/core/src/main/resources/te
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219820654
So it's not a regression bug ;-) Yes, we do support Velocity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219820007
@lukaszlenart the parameter align was remove on this commit
https://github.com/victorsosa/struts/commit/a0b34806b0f700a1fd240b698c4cec474711bbd0
---
If your pro
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219820070
Issue is about Velocity tags, not FreeMarker. Are we still supporting
Velocity tags?
---
If your project is set up for it, you can reply to this email and have your
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219817155
I'm just wondering what was the main reason, I have prepared a unit test
and it didn't pass when using 2.3.29-SNAPSHOT which means 2.3.28.1 is broken
the same way.
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219813310
CSS class to this table cell is what we have now and to have back
compatibility as @lukaszlenart said.
---
If your project is set up for it, you can reply to this em
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219809968
Why not just add some CSS class to this table cell? Then end-users can
style it as they want and align parameter will not be needed.
---
If your project is set up fo
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219713305
Another thing I will change the name to just
> align-center
because this css class can be used in other places that are using the align
attribute; wh
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63517163
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${para
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219709110
Yes, it fix the main issue and keep the back compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63516015
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${pa
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63515782
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${para
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219706843
This doesn't fix the main issue, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63514815
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${pa
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/95
WW-4634 Centre alignment doesn't seem to work in Velocity tags
Fix for WW-4634
Centre alignment doesn't seem to work in Velocity tags
You can merge this pull request into a Git repos
20 matches
Mail list logo
