[GitHub] struts pull request #116: [WW-4528] handling ChainingInterceptor excludes an...

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

Build failed in Jenkins: Struts-JDK9-master #77

See Changes: [amashchenko] WW-4743 NPE in StrutsTilesContainerFactory when resource isn't found -- [...truncated 15019 lines...] Results : Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 [JE

Re: How to select how to solve issue?

Am 13.02.17 um 12:10 schrieb Lukasz Lenart: > 2017-02-04 19:19 GMT+01:00 Yasser Zamani : >> 2. When I fixed WW-4694, I discovered that our AnnotationUtils has not >> any tangible improvement for about 4 years and also, with my changes, a >> method named isAnnotatedBy will be almost useless or dupli

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

Github user yasserzamani commented on a diff in the pull request: https://github.com/apache/struts/pull/118#discussion_r100774641 --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java --- @@ -160,7 +160,20 @@ private void copyStack(ActionInvocat

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

Github user yasserzamani commented on a diff in the pull request: https://github.com/apache/struts/pull/118#discussion_r100774158 --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java --- @@ -160,7 +160,20 @@ private void copyStack(ActionInvocat

Build failed in Jenkins: Struts-JDK9-master #76

See Changes: [yasser.zamani] [WW-4694] annotation processing improved in order to navigate around [yasser.zamani] [WW-4472] using improved AnnotationUtils to navigate around proxies [Lukasz Lenart] Reformats code [Lukasz Lenart] D

[GitHub] struts pull request #118: [WW-4105] OgnlUtil improved in order to only setti...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/118#discussion_r100772955 --- Diff: core/src/main/java/com/opensymphony/xwork2/interceptor/ChainingInterceptor.java --- @@ -160,7 +160,20 @@ private void copyStack(ActionInvocat

Re: how to solve issue? fewer changes or...

2017-02-07 9:50 GMT+01:00 Yasser Zamani : > I also discovered sometimes PRs will be dependent e.g. PR2 will fix > ISSUE2 if and only if PR1 has been accepted and pulled before. I think I > should fix ISSUE2 in PR1 too and links them in JIRA, all of these before > PR1's acceptation, to avoid make mu

Re: How to select how to solve issue?

2017-02-04 19:19 GMT+01:00 Yasser Zamani : > I have fixed WW-4694 where I found that I need some recommendation > before creating it's PR, to fix it as best as possible. > > In general, would you like to issue being solved with fewer changes as > much as possible? Or no, as best as possible but wit

[GitHub] struts pull request #117: [WW-4694] annotation processing improved

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] struts issue #117: [WW-4694] annotation processing improved

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/117 Cool, this look great and I don't mind copping code from other libraries if they match license :) Regarding issue linkage I think you can update the description and put an issue ID ther

[GitHub] struts issue #117: [WW-4694] annotation processing improved

Github user yasserzamani commented on the issue: https://github.com/apache/struts/pull/117 Thank you. I got it and will fix it by update my eclipse Preferences. And what about the new codes and comments? some of them are copied from `Spring` framework which itself has `Apache

Build failed in Jenkins: Struts-JDK9-master #75

See Changes: [carl.antuar] [WW-4737] preserve nulls instead of converting them to the string 'null' [carl.antuar] [WW-4737] add unit testing for parameters being converted to string -- [...tr

Showcase app ajax validation check

Was looking at some client side validation, with the showcase app. I use firefox and it was not working, it just returned Network or server error! https://struts.apache.org/docs/ajax-validation.html The ajax call was returning 400, so falls back onto the error function and just displays the netwo

[GitHub] struts issue #117: [WW-4694] annotation processing improved

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/117 I have one general issue: indentation in some files are too big, it should be `4 spaces` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] struts pull request #115: WW-4737 Properly handle arrays containing nulls

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab