Re: LocaleProviderFactory

2017-03-15 Thread Stefaan Dutry
I have a question about the pull request. In the interface LocaleProviderFactory, there's only a method called createLocaleProvider. Does this mean that there's supposed to be a seperate instance of LocaleProvider on every single place this is used? (I know you could technicaly implement the inte

LocaleProviderFactory

2017-03-15 Thread Lukasz Lenart
If no objections I will merge this PR [1] tomorrow [1] https://github.com/apache/struts/pull/122 Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For addi

[GitHub] struts issue #118: [WW-4105] OgnlUtil improved in order to only setting prop...

2017-03-15 Thread yasserzamani
Github user yasserzamani commented on the issue: https://github.com/apache/struts/pull/118 @aleksandr-m , Thank you for your time and comments; please let me know what do you think about below; I would like to be sure about usefulness before starting implementation. > Are you

Re: Localized bean

2017-03-15 Thread Greg Huber
>you can always implement your own >LocalizedTextProvider and search in default bundles first and then >fallback to searching class hierarchy. There seems alot going on in DefaultLocalizedTextProvider so I would rather stay with the default and do the local modification. >Something like getDefau

Re: Localized bean

2017-03-15 Thread Łukasz Lenart
Something like getDefaultText()? but you can always implement your own LocalizedTextProvider and search in default bundles first and then fallback to searching class hierarchy. Maybe I should prepare a small demo? Regards -- Łukasz 2017-03-15 9:08 GMT+01:00 Greg Huber : >>Hm... I think definin

Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-15 Thread Lukasz Lenart
Hi, Another PR cleaning up a mess with injecting things ;) https://github.com/apache/struts/pull/122 and what do you think about adding a dedicated artefact to keep all those interfaces? strust2-api? And move all the APIs there maybe with default implementations. Another thing I would like to st

[GitHub] struts pull request #122: WW-4757: LocaleProvider factory

2017-03-15 Thread lukaszlenart
GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/122 WW-4757: LocaleProvider factory Replaces injectable `LocaleProvider` with `LocaleProviderFactory` to avoid problems with multiple beans implementing the `LocaleProvider` interface. Imp

Re: Localized bean

2017-03-15 Thread Greg Huber
>Hm... I think defining struts.custom.i18n.resources should resolve your problem >struts.custom.i18n.resources=ApplicationResources I already have this, but since I came from a struts 1, I am not motivated to use the class package logic as there would be too much duplication and maintenance of all