Struts 2.4

2017-11-28 Thread Lukasz Lenart
Hi, I'm going to release a new version of Struts 2.3.x but because we are not able to support 2.3.x on Java 6, I will switch to Java 7 and brand it Struts 2.4 Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To u

Re: [jira] [Updated] (WW-4873) NotSerializableException - org.apache.struts2.dispatcher.StrutsRequestWrapper

2017-11-28 Thread Lukasz Lenart
2.5.14.1 will be a fast release, please do not assign any other issues to it. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2017-11-29 7:42 GMT+01:00 Lukasz Lenart (JIRA) : > > [ > https://issues.apache.org/jira/browse/WW-4873?page=com.atlassian.jira.plugin.system.issuetabp

Fixing Sonar issues?

2017-11-28 Thread Yasser Zamani
It seems we have 259 new code smells raised [1] somehow they're much :( what's your idea about what we should do? I have similar doubt about coverage. It seems it's 46%. I thought that we should find most important ones at [2] and fix them everyday one by one on a daily basis. What's your idea?

Re: Struts 2.6

2017-11-28 Thread Louis Smith
All my clients app servers are on Servlet 3.1 - Glassfish is now on 4.0. The cross-package limitation comes to mind as first concern.- how many "add-opens" and "add-modules" would be required. I need to get back on testing a full Struts 2.5.14 app under Java 9/Glassfish and see what I can find.

Re: Struts 2.6

2017-11-28 Thread Greg Huber
... String convertToString(Map arg0, Object arg1) { Possibly will look into something like this, but its easier for now to use: value="%{getText('format.double',{bean.size})}" where format.double={0,number,##0.0} ie Thanks. On 28 November 2017 at 09:15, Yasser Zamani wrote: > > > On 11/2

Re: Struts 2.6

2017-11-28 Thread Lukasz Lenart
2017-11-28 10:15 GMT+01:00 Greg Huber : >>but how do you use with ? > > I do not, thought maybe I was using textfield incorrectly for numbers. Its > read only. Ok, ok :) So is better though :) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/

Re: Struts 2.6

2017-11-28 Thread Yasser Zamani
On 11/28/2017 12:36 PM, Greg Huber wrote: > where do these live now? does not compile for me. > > *ThemeDescriptorConverter.java* > > import org.apache.struts.model.ThemeDescriptor; > import org.apache.struts.model.Themes; No I mentioned those as examples. You instead should write your own, l

Re: Struts 2.6

2017-11-28 Thread Greg Huber
>but how do you use with ? I do not, thought maybe I was using textfield incorrectly for numbers. Its read only. On 28 November 2017 at 08:58, Lukasz Lenart wrote: > 2017-11-28 9:52 GMT+01:00 Greg Huber : > > ah, that works OK, the eclipse context does not explain what they do, > just > > sa

Re: Struts 2.6

2017-11-28 Thread Greg Huber
where do these live now? does not compile for me. *ThemeDescriptorConverter.java* import org.apache.struts.model.ThemeDescriptor; import org.apache.struts.model.Themes; On 28 November 2017 at 08:45, Yasser Zamani wrote: > > > On 11/28/2017 11:51 AM, Greg Huber wrote: > > Is there any way I can

Re: Struts 2.6

2017-11-28 Thread Lukasz Lenart
2017-11-28 9:52 GMT+01:00 Greg Huber : > ah, that works OK, the eclipse context does not explain what they do, just > says: "Minimum fraction digits" but how do you use with ? And feel free to register this as a bug :) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ ---

Re: Struts 2.6

2017-11-28 Thread Greg Huber
ah, that works OK, the eclipse context does not explain what they do, just says: "Minimum fraction digits" On 28 November 2017 at 08:48, Yasser Zamani wrote: > > > On 11/28/2017 12:14 PM, Greg Huber wrote: > > still shows 10 > > I think it should be minimumFractionDigits. >

Re: Struts 2.6

2017-11-28 Thread Yasser Zamani
On 11/28/2017 12:14 PM, Greg Huber wrote: > still shows 10 I think it should be minimumFractionDigits.

Re: Struts 2.6

2017-11-28 Thread Yasser Zamani
On 11/28/2017 11:51 AM, Greg Huber wrote: > Is there any way I can > now easily do this? I think you can write a small custom converter via extending `com.opensymphony.xwork2.conversion.impl.StringConverter` and overriding it's `convertToString` method [1] then you can register it globally for

Re: Struts 2.6

2017-11-28 Thread Greg Huber
>Right, a bit annoying ... but that makes me think that we can use the >'format.numer' directly in the converter Some kind of formatting would be useful and possibly eliminate the getText() call. Tried number, but it is an output field only, also still shows 10, does not seem to do anything?

Re: Struts 2.6

2017-11-28 Thread Lukasz Lenart
2017-11-28 9:21 GMT+01:00 Greg Huber : > It works ok, but I want to show the digits (.0). Is there any way I can > now easily do this? Sorry but no :( > My price fields I have to manually set the value: > > value="%{getText('format.number',{bean.price})}" size="5" maxlength="6" /> Right, a bit

Re: Struts 2.6

2017-11-28 Thread Lukasz Lenart
2017-11-28 9:04 GMT+01:00 Greg Huber : > ...one thing I have noticed is the number formatting on textfield has > changed. > > Previously, if its value was 10 it used to show 10.0 now it only shows 10. > ie missing the decimal point and a zero. > > > > public double getSize() { > return siz

Re: Struts 2.6

2017-11-28 Thread Greg Huber
It works ok, but I want to show the digits (.0). Is there any way I can now easily do this? My price fields I have to manually set the value: On 28 November 2017 at 08:15, Yasser Zamani wrote: > > > On 11/28/2017 11:34 AM, Greg Huber wrote: > > Previously, if its value was 10 it used to show

Re: Struts 2.6

2017-11-28 Thread Yasser Zamani
On 11/28/2017 11:34 AM, Greg Huber wrote: > Previously, if its value was 10 it used to show 10.0 now it only shows 10. > ie missing the decimal point and a zero. Yes, we dropped `.setMinimumFractionDigits(1)` [1]. Do you have any issue when post back the value to your action? [1] https://gith

Re: Struts 2.6

2017-11-28 Thread Greg Huber
...one thing I have noticed is the number formatting on textfield has changed. Previously, if its value was 10 it used to show 10.0 now it only shows 10. ie missing the decimal point and a zero. public double getSize() { return size; } I have checked 2.5.13 and it works as expected

Build failed in Jenkins: Struts-site-javadocs #4

2017-11-28 Thread Apache Jenkins Server
See -- [...truncated 1.50 MB...] at java.lang.Thread.runat org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze java.lang.Thread.run (Thread.java:745) (Thread.java:745)