Avoid using setters

2018-09-18 Thread Lukasz Lenart
Hi, In matter of security I wonder if we should stop using setters in internal API. Like in SessionAware interface we use setSession() and each actions must implement this method. Then we have a logic to avoid mapping incoming values to setSession() to permit injecting values into Session. Instea

Re: New releases

2018-09-18 Thread Lukasz Lenart
wt., 18 wrz 2018 o 23:43 Yasser Zamani napisał(a): > > > > On 9/17/2018 3:01 PM, Yasser Zamani wrote: > > Oh by the way, wait; I remember this from ASF: > > > > New policy : > > > > -- SHOULD supply a SHA-256 and/or SHA-512 checksum file > > -- SHOULD NOT supply MD5 or SHA-1 checksum files > >

Re: New releases

2018-09-18 Thread Yasser Zamani
On 9/17/2018 3:01 PM, Yasser Zamani wrote: > Oh by the way, wait; I remember this from ASF: > > New policy : > > -- SHOULD supply a SHA-256 and/or SHA-512 checksum file > -- SHOULD NOT supply MD5 or SHA-1 checksum files > > Which I think it means we must push some changes (e.g. maven optio

Re: New releases

2018-09-18 Thread Lukasz Lenart
I have also noticed that we used a wrong profile in out struts-master, it must be "apache-release" instead of "release". Quick fix is to add "-Papache-release" when performing the release. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ wt., 18 wrz 2018 o 08:22 Lukasz Lenart napis

Build failed in Jenkins: Struts-master-JDK8 #149

2018-09-18 Thread Apache Jenkins Server
See -- [...truncated 299.58 KB...] [ERROR] public static long parseLong(char[] b, int off, int len) [ERROR]^ [ERROR]

Jenkins build is back to normal : Struts-master-JDK7 #147

2018-09-18 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Build failed in Jenkins: Struts-master-JDK8 #148

2018-09-18 Thread Apache Jenkins Server
See Changes: [lukaszlenart] WW-4951 Upgrades to the latest struts master to support SHA256/512 -- [...truncated 299.42 KB...] [ERROR] public static long parseLong(ch

Build failed in Jenkins: Struts-master-JDK7 #146

2018-09-18 Thread Apache Jenkins Server
See Changes: [lukaszlenart] WW-4951 Upgrades to the latest struts master to support SHA256/512 -- [...truncated 3.16 MB...] [exec] 2018-09-18 08:13:10 URL:https://