Re: ***UNCHECKED*** AW: Avoid using setters

2018-09-19 Thread Lukasz Lenart
śr., 19 wrz 2018 o 13:42 Yasser Zamani napisał(a): > Yes I saw :) thanks a lot keeping this one to be done! By the way I'm > trying to build 2.3.x with latest struts-master or etc to see if is > possible to automate WW-4951. Don't bother, it isn't :( Regards -- Łukasz + 48 606 323 122 http://w

Re: ***UNCHECKED*** AW: Avoid using setters

2018-09-19 Thread Yasser Zamani
On 9/19/2018 2:23 PM, Lukasz Lenart wrote: > Ah, right :) I knew that I saw this idea somewhere but I couldn't > recall. Yes I saw :) thanks a lot keeping this one to be done! By the way I'm trying to build 2.3.x with latest struts-master or etc to see if is possible to automate WW-4951. Regard

Re: New releases

2018-09-19 Thread Lukasz Lenart
śr., 19 wrz 2018 o 12:08 Yasser Zamani napisał(a): > -1 as I think this will be error prone and hard to do as a manual > procedure (ASF says "For every artifact distributed to the public > through Apache channels" [1] i.e. not only assemblies but also all > artifacts). I would automate it; as mave

Re: AW: Avoid using setters

2018-09-19 Thread Yasser Zamani
On 9/19/2018 2:17 PM, Yasser Zamani wrote: > Same refactor would be nice for Struts internal CDI by > finding all references of @Inject and refactoring them [1]. This changes > isn't backward compatible so no need for deprecation I think. FIX: This change (finding all references of @Inject and r

Re: ***UNCHECKED*** AW: Avoid using setters

2018-09-19 Thread Lukasz Lenart
śr., 19 wrz 2018 o 11:41 Yasser Zamani napisał(a): > On 9/19/2018 10:33 AM, christoph.nenn...@bmw.de wrote: > > Oh yes, that sounds like a great idea! > > I wonder why we didn't come up with this earlier, the simplest ideas are > > the hardest to find ;) > > We already have discovered and propose

Re: AW: Avoid using setters

2018-09-19 Thread Yasser Zamani
On 9/19/2018 10:53 AM, Lukasz Lenart wrote: > Cool, first step https://github.com/apache/struts/pull/252 - WIP :) +1, thanks a lot! Same refactor would be nice for Struts internal CDI by finding all references of @Inject and refactoring them [1]. This changes isn't backward compatible so no need

Re: New releases

2018-09-19 Thread Yasser Zamani
On 9/19/2018 8:23 AM, Lukasz Lenart wrote: > Yeah... the sums in Nexus are generated by Nexus, there is an issue > about generating sums in Nexus 3 - looks like it's a matter of policy > defined in Nexus what kind of sums to generate. I would not batter > with this. Anyway, we must provide SHA256

Re: ***UNCHECKED*** AW: Avoid using setters

2018-09-19 Thread Yasser Zamani
On 9/19/2018 10:33 AM, christoph.nenn...@bmw.de wrote: > Oh yes, that sounds like a great idea! > I wonder why we didn't come up with this earlier, the simplest ideas are the > hardest to find ;) We already have discovered and proposed this in security list [1] about one year ago :) LGTM also

Re: AW: Avoid using setters

2018-09-19 Thread Lukasz Lenart
śr., 19 wrz 2018 o 09:03 napisał(a): > > Oh yes, that sounds like a great idea! > I wonder why we didn't come up with this earlier, the simplest ideas are the > hardest to find ;) > > My preference would be the name withSession. Cool, first step https://github.com/apache/struts/pull/252 - WIP :)

***UNCHECKED*** AW: Avoid using setters

2018-09-19 Thread Christoph.Nenning
Oh yes, that sounds like a great idea! I wonder why we didn't come up with this earlier, the simplest ideas are the hardest to find ;) My preference would be the name withSession. Regards, Christoph -Ursprüngliche Nachricht- Von: Lukasz Lenart [mailto:lukaszlen...@apache.org] Gesend