[GitHub] [struts] atkaiser commented on issue #400: [WW-5065] Removing unnecessary part of AbstractMatcher#replaceParameters

2020-04-20 Thread GitBox
atkaiser commented on issue #400: URL: https://github.com/apache/struts/pull/400#issuecomment-616904644 Sounds good to me This is an automated message from the Apache Git Service. To respond to the message, please log on to G

New messages

2020-04-20 Thread Lukasz Lenart
Hi, You have probably noticed new messages flooding the list, this is a side effect of enabling .asf.yaml [1] to control notifications. We don't use it in the main Struts repo, but this somehow fixed how the notifications should be routed from the very beginning. If you have any idea how to config

[GitHub] [struts] lukaszlenart commented on issue #400: [WW-5065] Removing unnecessary part of AbstractMatcher#replaceParameters

2020-04-20 Thread GitBox
lukaszlenart commented on issue #400: URL: https://github.com/apache/struts/pull/400#issuecomment-616730002 Right, this should express its external effect ``` struts.matcher.appendNamedParameters=true ``` If not objections I'm going to merge this PR and add the flag. --

[GitHub] [struts-site] lukaszlenart commented on issue #145: Correct extension of JSP component.

2020-04-20 Thread GitBox
lukaszlenart commented on issue #145: URL: https://github.com/apache/struts-site/pull/145#issuecomment-616720493 LGTM 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [struts-site] lukaszlenart commented on issue #145: Correct extension of JSP component.

2020-04-20 Thread GitBox
lukaszlenart commented on issue #145: URL: https://github.com/apache/struts-site/pull/145#issuecomment-616719802 Hm... Jenkins triggering stopped working :\ This is an automated message from the Apache Git Service. To respond

[GitHub] [struts-site] davelnewton opened a new pull request #145: Correct extension of JSP component.

2020-04-20 Thread GitBox
davelnewton opened a new pull request #145: URL: https://github.com/apache/struts-site/pull/145 May also want a directory change to better reflect common JSP usage (and that it cannot be on classpath). This is an automated m