[GitHub] [struts] lukaszlenart commented on issue #400: [WW-5065] Removing unnecessary part of AbstractMatcher#replaceParameters

lukaszlenart commented on issue #400: URL: https://github.com/apache/struts/pull/400#issuecomment-617569364 @atkaiser @JCgH4164838Gh792C124B5 PR is ready https://github.com/apache/struts/pull/405 This is an automated message

[GitHub] [struts] lukaszlenart opened a new pull request #405: [WW-5065] Defines a new flag to control appending params

lukaszlenart opened a new pull request #405: URL: https://github.com/apache/struts/pull/405 Follow up on https://github.com/apache/struts/pull/400 Refs [WW-5065](https://issues.apache.org/jira/browse/WW-5065) This is an au

[GitHub] [struts] lukaszlenart commented on issue #400: [WW-5065] Removing unnecessary part of AbstractMatcher#replaceParameters

lukaszlenart commented on issue #400: URL: https://github.com/apache/struts/pull/400#issuecomment-617550492 LGTM 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [struts] lukaszlenart commented on issue #397: [WW-4789] [WW-3788] ActionContext refactoring

lukaszlenart commented on issue #397: URL: https://github.com/apache/struts/pull/397#issuecomment-617547853 Here are the [ActionContext](https://github.com/apache/struts/pull/397/files#diff-8bd10f8c78a248734b503714a44e1dcc) changes I'm talking about. All the rest is a consequence of those

[GitHub] [struts] coveralls edited a comment on issue #397: [WW-4789] [WW-3788] ActionContext refactoring

coveralls edited a comment on issue #397: URL: https://github.com/apache/struts/pull/397#issuecomment-602049491 [](https://coveralls.io/builds/30235237) Coverage increased (+0.03%) to 49.212% when pulling **f071c9d0ed

Jenkins job struts-core/master#244 failed

There is a build failure in struts-core/master. Build: https://builds.apache.org/job/struts-core/job/master/244/ Logs: https://builds.apache.org/job/struts-core/job/master/244/console Changes: https://builds.apache.org/job/struts-core/job/master/244/changes -- Mr. Jenkins Director of Continuous I

Jenkins job struts-core/master#243 failed

There is a build failure in struts-core/master. Build: https://builds.apache.org/job/struts-core/job/master/243/ Logs: https://builds.apache.org/job/struts-core/job/master/243/console Changes: https://builds.apache.org/job/struts-core/job/master/243/changes -- Mr. Jenkins Director of Continuous I

Jenkins job struts-core/master#242 failed

There is a build failure in struts-core/master. Build: https://builds.apache.org/job/struts-core/job/master/242/ Logs: https://builds.apache.org/job/struts-core/job/master/242/console Changes: https://builds.apache.org/job/struts-core/job/master/242/changes -- Mr. Jenkins Director of Continuous I

[GitHub] [struts] lukaszlenart commented on issue #229: WW-4796 Rename springconstants to have a uniform naming pattern

lukaszlenart commented on issue #229: URL: https://github.com/apache/struts/pull/229#issuecomment-617350536 I assume we are good to merge this PR if no objections, from my side LGTM 👍 This is an automated message from the Ap

[GitHub] [struts] lukaszlenart commented on issue #397: [WW-4789] [WW-3788] ActionContext refactoring

lukaszlenart commented on issue #397: URL: https://github.com/apache/struts/pull/397#issuecomment-617345083 I think this PR is finally ready. I know it's huge so if there are objections merging it AS-IS I can prepare another PR and just move `ActionContext`s changes and then update the res