[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-23 Thread GitBox
JCgH4164838Gh792C124B5 commented on pull request #397: URL: https://github.com/apache/struts/pull/397#issuecomment-618723503 Hi. I will try to go over the new changes in a few days. Thanks for all the work on this. 👍 Thi

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #405: [WW-5065] Defines a new flag to control appending params

2020-04-23 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #405: URL: https://github.com/apache/struts/pull/405#discussion_r414185407 ## File path: core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java ## @@ -50,10 +53,23 @@ * The compiled patter

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #405: [WW-5065] Defines a new flag to control appending params

2020-04-23 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #405: URL: https://github.com/apache/struts/pull/405#discussion_r414181934 ## File path: core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java ## @@ -36,6 +36,9 @@ * @since 2.1 */ public ab

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on a change in pull request #397: [WW-4789] [WW-3788] ActionContext refactoring

2020-04-23 Thread GitBox
JCgH4164838Gh792C124B5 commented on a change in pull request #397: URL: https://github.com/apache/struts/pull/397#discussion_r414173368 ## File path: core/src/main/java/com/opensymphony/xwork2/util/ValueStack.java ## @@ -28,23 +30,25 @@ */ public interface ValueStack { -

Build failed in Jenkins: Struts-master-JDK8-dependency-check #269

2020-04-23 Thread Apache Jenkins Server
See Changes: [lukaszlenart] Fixes url used to generate the website -- Started by timer Running as SYSTEM [EnvInject] - Loading node environment variable

Re: Struts benchmarking

2020-04-23 Thread Martin Gainty
all: the bean you want to profile will need to implement ThreadMX https://www.javamex.com/tutorials/profiling/profiling_java5_threads_howto.shtml import java.lang.management.*; ... ThreadMXBean threadBean = ManagementFactory.getThreadMXBean(); once we have ThreadMXBean we can interrogate thread

Re: Struts benchmarking

2020-04-23 Thread Alex Kaiser
Interesting bug. It looks like each test run is sending 5000 requests in total using 100 "client threads". During the test at some interval (it seems random) it's printing out a summary of the test so far. Each summary seems to contain: - Number of requests sent since last summary - The total r