Build failed in Jenkins: Struts » Struts-examples-dependency-check #84

2022-12-29 Thread Apache Jenkins Server
See Changes: [Lukasz Lenart] Cleans up dependencies and suppresses false positives [github] Bump javax.servlet-api from 3.1.0 to 4.0.1 [github] Bump slf4j-simple from 2.0.5 to 2.0.6

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
      fileUploadServlet /user/resources.action   makes it work, but ends up with an empty file called embeddable53b33ea6a4fb4bb1957d35fa60af338c.jpg. Will debug some more.😁 On 29/12/2022 12:56, Lukasz Lenart wrote: czw., 29 gru 2022 o 13:34 Greg Huber napisał(a): I have now set struts.

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
struts.multipart.parser=servlet struts2 url-pattern>*.action fileUploadServlet /user/resources* Does not seem to call the servlet, only a 404. I use the StrutsPrepareAndExecuteFilter. With the filter mapping, how does it use the servlet mapping? boolean isMultipartRe

Re: Fileupload on JakartaEE

2022-12-29 Thread Lukasz Lenart
czw., 29 gru 2022 o 13:34 Greg Huber napisał(a): > > I have now set > > struts.multipart.parser=org.apache.struts2.dispatcher.multipart.ServletMultiPartRequest this must be: struts.multipart.parser=servlet (I will document this latter) > > fileUploadServlet > org.apache.struts2.dispat

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
I have now set struts.multipart.parser=org.apache.struts2.dispatcher.multipart.ServletMultiPartRequest     fileUploadServlet org.apache.struts2.dispatcher.servlet.FileUploadServlet         fileUploadServlet     /fileupload/*     /tags/ui/* # I get in FileUploadSupport.

Re: Fileupload on JakartaEE

2022-12-29 Thread Lukasz Lenart
czw., 29 gru 2022 o 11:55 Greg Huber napisał(a): > > I made no changes just used the branch as is. I tried deleting the > commons jar to make sure it was using the new code but my app won't > start without it. Cool, it means I didn't break any existing configuration :D Did you change the value

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
I made no changes just used the branch as is.  I tried deleting the commons jar to make sure it was using the new code but my app won't start without it. ..If I add a breakpoint on FileUploadSupport isFileUploadRequest(..) it stops so I assume its being used. On 29/12/2022 10:44, Lukasz Lena

Re: Fileupload on JakartaEE

2022-12-29 Thread Lukasz Lenart
czw., 29 gru 2022 o 11:40 Greg Huber napisał(a): > WW-5273-servlet-upload branch works on both my ajax and forms based upload. Great to hear that! Did you have any problem with configuring that additional FileUploadServlet which is needed by Servlet API 3.1? > (although commons-fileupload-1.4.ja

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
WW-5273-servlet-upload branch works on both my ajax and forms based upload. (although commons-fileupload-1.4.jar is still included) On 29/12/2022 09:38, Lukasz Lenart wrote: Take a look on that PR https://github.com/apache/struts/pull/650 Regards --

Re: Fileupload on JakartaEE

2022-12-29 Thread Lukasz Lenart
Take a look on that PR https://github.com/apache/struts/pull/650 Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...

[GitHub] [struts] lukaszlenart opened a new pull request, #650: [WW-5273] Supports file upload using Servlet API 3.1

2022-12-29 Thread GitBox
lukaszlenart opened a new pull request, #650: URL: https://github.com/apache/struts/pull/650 Also documents update is needed Closes [WW-5273](https://issues.apache.org/jira/browse/WW-5273) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: Fileupload on JakartaEE

2022-12-29 Thread Lukasz Lenart
czw., 29 gru 2022 o 09:01 Yasser Zamani napisał(a): > Am I right that even if it was a servlet then it wasn't working too? as > per [1]. There is a slight problem with "keep using commons-fileupload" - it depends on "javax.servlet" package, while this package is available in the first version of

Re: Fileupload on JakartaEE

2022-12-29 Thread Yasser Zamani
Hi, Am I right that even if it was a servlet then it wasn't working too? as per [1]. Anyway in general I think we shouldn't try to keep supporting both. "Java EE is Officially Retired. It’s Now Called Jakarta EE. How Did We Get Here?" [2]. So I think at some day we may have a release that