Re: looking at roller upgrade again

2023-04-10 Thread Greg Huber
More housekeeping, the id on the form tag never supported %{..} on the action attribute. ie action="%{#mainAction}!saveDraft" On 10/04/2023 20:37, Yasser Zamani wrote: Hi there, please see inline... On 4/3/2023 11:18 AM, Lukasz Lenart wrote: The change has been introduced here [1] and the pro

Re: looking at roller upgrade again

2023-04-10 Thread Yasser Zamani
Hi there, please see inline... On 4/3/2023 11:18 AM, Lukasz Lenart wrote: The change has been introduced here [1] and the problem is that it replaces any non-alphanumeric character with "_". Also it works on an unevaluated version of the "name" attribute (in case if the "id" attribute is not def

Re: looking at roller upgrade again

2023-04-10 Thread Lukasz Lenart
pon., 10 kwi 2023 o 09:57 Greg Huber napisał(a): > > Modified version here > > https://github.com/gregh3269/struts/tree/WW-5302-unevaluated-id > > > >myConfig > action="%{#mainAction}!save" /> > method="save" /> > > id="myConfig_myConfig_save"> I missed that you do not use the "n

Re: looking at roller upgrade again

2023-04-10 Thread Greg Huber
Modified version here https://github.com/gregh3269/struts/tree/WW-5302-unevaluated-id   myConfig   action="%{#mainAction}!save" />   method="save" />   id="myConfig_myConfig_save"> On 09/04/2023 15:16, Lukasz Lenart wrote: niedz., 9 kwi 2023 o 12:20 Greg Huber napisał(a): Testing the

Re: looking at roller upgrade again

2023-04-10 Thread Greg Huber
branch WW-5302-unevaluated-id Seems the same to me.  Note the action has a variable: %{#mainAction}!save All it seems to be doing is escaping action: %{#mainAction}!save : %{#mainAction}!save ___mainAction}_save On 09/04/2023 15:16, Lukasz Lenart wrote: niedz., 9 kwi 2023 o 12:20 Greg Huber