[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-05-22 Thread abrin
Github user abrin commented on the pull request: https://github.com/apache/struts/pull/7#issuecomment-43969902 Hi Lukasz, On my branch I wasn’t able to get it to pass the tests, were you able to? thanks, adam On May 20, 2014, at 11:09 PM, Lukasz

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-24 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10886552 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10779343 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10777092 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10770402 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-19 Thread abrin
Github user abrin commented on a diff in the pull request: https://github.com/apache/struts/pull/7#discussion_r10753958 --- Diff: core/src/main/resources/template/simple/checkboxlist.ftl --- @@ -29,7 +29,13 @@ <#else> <#assign itemKey = stack.

[GitHub] struts pull request: [PATCH] First attempt at enabling value-label...

2014-03-18 Thread abrin
GitHub user abrin opened a pull request: https://github.com/apache/struts/pull/7 [PATCH] First attempt at enabling value-labels to be pulled from Locale Files. Adding listValueKey attribute to checkboxList, radioMap, and select tags. Issues: This implementation