Luskaz:
How are you doing code changes using GitHub pull requests so that your
work ends up in the https://git-wip-us.apache.org/repos/asf/struts.git?
Bruce
--
View this message in context:
http://struts.1045723.n5.nabble.com/Coding-Work-Flow-GitHub-to-Apache-Git-tp5715813.html
Sent from
+1 GA
--
View this message in context:
http://struts.1045723.n5.nabble.com/VOTE-Struts-2-3-17-tp5715703p5715714.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@stru
I tested using 2.3.17 with the Struts 2 example apps
(http://git.apache.org/struts-examples.git) and everything worked correctly.
Bruce
--
View this message in context:
http://struts.1045723.n5.nabble.com/Struts-2-3-17-ready-to-test-tp5715666p5715676.html
Sent from the Struts - Dev mailing lis
Luskaz:
Is this the source code for the Struts CRUD example project -
https://github.com/strutsathon/struts2-crud-example that you and I think
should be added to our example apps in our new Git repo?
I'd like to review it in some detail to see what we would need to add to the
Struts Getting Sta
I vote for adding it to the Maven example projects.
I do think we need to also add a tutorial page about it as part of our
Struts Getting Started tutorials:
http://struts.apache.org/release/2.3.x/docs/getting-started.html
The Getting Started tutorials build upon themselves so we can expect th
Thank you for the help. I totally missed enclosing the value in single
quotes inside double quotes. I'm going to add some text to the JavaDoc for
GenericUIBean that makes this clearer (the Component UI tag reference wiki
page pulls in the JavaDoc).
Bruce
--
View this message in context:
http
I'm working on JIRA WW-4299 and am trying to setup an example application to
validate the problem the person reported with the Struts component tag and
parameters.
In my example app (see attached zip file) I have this markup in index.jsp:
<%@taglib prefix="s" uri="/struts-tags" %>
http://www.w3.
I assigned myself JIRA ticket https://issues.apache.org/jira/browse/WW-4299.
I'm not sure the correct process for working on this issue and then pushing
the code back to our Git repository.
I tried following the email chain about Git Flow but quickly got lost. I
read through http://struts.apache
Thank you Lukasz for all the work you've done on this task.
I will create a JIRA issue for updating the tutorial web pages with this
change to Git for where people can get the Struts 2 example app source code
and assign to myself. I think I will use the GitHub mirror since many
people have GitHub
What is the URL for git clone to pull down the examples?
Bruce
--
View this message in context:
http://struts.1045723.n5.nabble.com/Migrated-Struts2-examples-to-Git-tp5715078p5715465.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
--
Your suggestion is fine with me.
Bruce
--
View this message in context:
http://struts.1045723.n5.nabble.com/Migrated-Struts2-examples-to-Git-tp5715078p5715317.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
--
I think whichever option makes it easier for a person to clone down and use
the examples.
If we make the examples part of Struts main then would a person need to
clone down the entire Struts source code in order to have the examples?
That might be a bit too much.
Bruce
--
View this message
Luskaz - I'm assuming we are still using Subversion repository for the Struts
2 examples.
I update the pom.xml for the parent project to exclude the struts2-core
transitive dependency to commons-fileupload and added a separate dependency
for commons-fileupload 1.3.1. This work was done to addre
I think I figured it out.
In the testpage.jsp of his example he has this s:form tag:
{code:XML}
{code}
Note the action="TestPage.action..."
If you then do not have default-action-ref in struts.xml you will get the
form tag rendered as
form id="testform" name="testform" action="TestPage.
Quite the mystery.
I've run the example application on both GlassFish and Tomcat 7 using
FireFox
Without the default-action-ref in the struts.xml I see this when I view page
source:
{code:XML}
field1 = 111
field2 = 222
{code}
With the default-action-ref in the struts.xml I see this whe
Appreciate the responses but perhaps I wasn't clear.
What I'm trying to research is why if using a default-action-ref statement
in struts.xml the query string parameters and values are included in the
form action attribute (although with an incorrectly encoded &) but if no
default-action-ref state
I'm working on JIRA issue https://issues.apache.org/jira/browse/WW-4259. A
user reported that the action attribute of the form tag rendered by the
s:from tag included a duplicate amp (e.g.
At first I could not duplicate the problem the user reported.
Then the user provided a Maven example proje
+1 for moving the examples to GitHub - they will be easier to find since
GitHub can be searched, people can fork them and make modifications as part
of their learning
Bruce
--
View this message in context:
http://struts.1045723.n5.nabble.com/Migrated-Struts2-examples-to-Git-tp5715078p5715088.h
Lukasz - Please look over this Jira issue:
https://issues.apache.org/jira/browse/WW-4254 which I've been researching.
I think a change made between 2.3.15.3 and 2.3.16 to the include statement
in the xhtml/conrolheader.ftl file has broken the datetimepicker tag
rendering when the label attribute
Luskaz:
Thank you for the help. I ran the updated themes example and everything
worked fine.
Also I've updated the themes tutorial
http://struts.apache.org/release/2.3.x/docs/struts-2-themes.html but you
will need to edit the page to see my changes (which unfortunately editing
the page in
I've updated the Struts 2 example applications at
https://svn.apache.org/repos/asf/struts/sandbox/trunk/struts2examples/ to
use 2.3.16 release.
The theme example still doesn't work and I've not been able to figure out
how to fix it. I know that 2.3.16 includes some changes to how to extend a
Stru
I ran the Struts 2 tutorial example web apps
(https://svn.apache.org/repos/asf/struts/sandbox/trunk/struts2examples) with
2.3.16 and everything worked correctly.
--
View this message in context:
http://struts.1045723.n5.nabble.com/Struts-2-3-16-ready-to-test-tp5714800p5714817.html
Sent from th
Perhaps the example app described here could be helpful:
http://struts.apache.org/release/2.3.x/docs/form-validation-using-xml.html
--
View this message in context:
http://struts.1045723.n5.nabble.com/Struts2-Sample-App-for-Validation-tp5714338p5714390.html
Sent from the Struts - Dev mailin
Luskaz reported that this bug is fixed in the latest Struts snapshot.
--
View this message in context:
http://struts.1045723.n5.nabble.com/Need-Assistance-With-Fixing-WW-4194-tp5713977p5714059.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
After unzipping the download create the .war file by using mvn -e clean
package
Then copy the .war file to Tomcat's webapps directory
Then go to: http://localhost:8080/Component_Tag_Struts2_Mvn/
Click on the link to Register
Complete the registration form and click submit
You will see two NO
I updated the struts 2 version in the parent example to be 2.3.15.2.
Everything built successfully.
--
View this message in context:
http://struts.1045723.n5.nabble.com/Struts2-Examples-tp5713949p5713979.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
https://issues.apache.org/jira/browse/WW-4194
Please see the notes for WW-4194. I've not been able to figure out the
cause of the bug the user reported as I'm not too familiar with the
Component class and how the ValueStack object is created and provided to the
Component class constructor. I tri
For the Documentation menu items why not use Struts 2 and Struts 1 as menu
choices instead of Struts 2.3.x and Struts 1.3.x. When we release Struts
2.4 we'll have to change those. The page those menu items link to (which
right now is not working) can specify the current version (e.g. 2.3.15.1).
On the main page of the new site:
We welcome your help! If you want to more about how to build and patch the
Struts 2 codebase, please read the Developer Docs
Should the above be:
We welcome your help! If you want to *learn *more about how to build and
patch the Struts 2 codebase, please read th
I think in the applications that use ParameterNameAware there are two use
cases - use it to specify a "blacklist" of parameter names that Struts
should not try to process or use it to specify a "whitelist" of parameter
names that Struts should allow.
If we change the OR to AND then the people who
Please see: https://issues.apache.org/jira/browse/WW-4153 which I'm working
on.
I thought about modifying template/simple/select.ftl to:
<#assign i = 1 >
<#if parameters.multiple?default(false)>
<#if (parameters.id?? && parameters.name??)>
<#if (parameters.id?? && !parameters.name??)
For now I added the following to the JavaDoc for the ParameterNameAware
interface so that it matches the JavaDoc for ParametersInterceptor:
* Using {@link ParameterNameAware} could be dangerous as {@link
ParameterNameAware#acceptableParameterName(String)} takes precedence
* over {@link Parameter
Paul and Luskaz - I appreciate the feedback but I'm a little confused.
Should I add the warning about using the ParameterNameAware interface that
is in the JavaDoc for the ParametersInterceptor to the JavaDoc for the
ParameterNameAware interface?
Or do we need to make some code changes in how
I'm working on issue https://issues.apache.org/jira/browse/WW-4137
Though we don't need to change the source code to address the reported issue
I think we may want to change the JavaDoc for the ParameterNameAware
interface.
The JavaDoc for the ParametersInterceptor -
http://struts.apache.org/rel
Lukasz:
I understand now. The change is that I have to put the theme attribute on
the s:form tag with a value of xhtml and then use the theme attribute on the
s:checkboxlist tag with a value of KUTheme (my custom check box list theme).
So the edit.jsp code is:
That is a change fr
Thank you for looking at this issue.
I removed the theme attribute from the form tag. But when I add the theme
attribute to the s:checkboxList tag I now get this error:
Error reading included file template/KUTheme/controlheader.ftl
The problematic instruction:
--
==> include
"/${paramet
I'm updating the themes tutorial
(http://struts.apache.org/release/2.3.x/docs/struts-2-themes.html) but
cannot get my example application to work using the latest version of Struts
2.
The example application is at
http://code.google.com/p/struts2-examples/downloads/detail?name=Themes_Struts_2_Mvn_
Thanks - I'll change the package name.
--
View this message in context:
http://struts.1045723.n5.nabble.com/Conventions-Plugin-Changes-Since-2-2-1-tp5713039p5713149.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
I'm updating the example applications located here
http://code.google.com/p/struts2-examples/downloads/list and moving them
to our Subversion repository. These example applications are referenced in
our Getting Started Tutorials:
http://struts.apache.org/release/2.3.x/docs/getting-started.html
Yes - keeping all the dependencies up-to-date in 20 some projects that each
use Ant to build became too time consuming. It's not just the Struts 2
dependencies but also the other artifacts that must be updated.
There are probably ways to work around that but I cannot think of one that
is not IDE
Maurizo - The Ant versions of the example applications were more popular then
the Maven versions. So if someone wants to maintain the Ant versions I
think people trying to learn Struts 2 would be grateful.
All the Ant versions of the example applications are at
http://code.google.com/p/struts2-ex
My plan is to move all the example applications from Google Code (
http://code.google.com/p/struts2-examples/downloads/list) for the Struts 2
Getting Started Tutorials
(http://struts.apache.org/release/2.3.x/docs/getting-started.html) to the
Subversion repository here:
https://svn.apache.org/repos
When running a unit test of a Struts portlet action using StrutsTestCase with
version of the Struts portlet plugin from 2.3.1 on a NullPointerException is
thrown. The same test passes with version 2.2.1 of the Struts portlet
plugin.
See: https://issues.apache.org/jira/browse/WW-3826 for complete
I re-opened the old issue: https://issues.apache.org/jira/browse/WW-3763
I'll find out what PortletActionContext.getPortletContext() is returning. I
agree it should be null if the action being called is not in a package that
extends struts-portlet-default.
Bruce
--
View this message in contex
Added some logging to PortletUrlRenderer - when call an action that is not in
package that extends struts-portlet-default the call to
urlComponent.getPortetUrlType() does return null instead of none.
So the if statement:
if (PortletActionContext.getPortletContext() == null ||
"none".equalsIgno
The 2.3.3 release of the Struts Portlet Plugin breaks using a Struts
application as both a portlet and as a standalone Java application. I
believe the issue is similar to
https://issues.apache.org/jira/browse/WW-3763. Thought we had fixed that
issue, but additional changes made to the Struts Port
Can you provide a rough estimate for when Struts 2 version 2.3.2 will be
released?
We would like to upgrade our Struts applications to the latest version to
fix the security vulnerabilities identified in
http://struts.apache.org/2.x/docs/s2-009.html and also widely discussed on
several IT blogs th
47 matches
Mail list logo
