Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts-site/commit/8caf5affd5c5539843e82c99a98f10ccf80fcf13#commitcomment-24459801
argh... sorry, I have missed that page. I thought you used just one, top
level page. Will revert
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts-site/pull/15#discussion_r140223857
--- Diff: source/maven-archetypes/index.md ---
@@ -3,155 +3,146 @@ layout: default
title: Maven Archetypes (WIP)
---
-#Struts 2
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts-site/pull/15#discussion_r140223777
--- Diff: source/maven-archetypes/index.md ---
@@ -3,155 +3,146 @@ layout: default
title: Maven Archetypes (WIP)
---
-#Struts 2
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/167
I will transit the plugin page and will let you know. Give me few days :)
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/166
ð LGTM
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/162
Merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
The case is that on second container initialisation we do not create
singletons upfront ... I have tried to change that but got some problems, not
sure why. I must re-think how we initialise
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-examples/pull/15
Works :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/159
Is it ready to merge? Does it contain the latest changes from #157?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/157
I would wait a bit and give Adam a chance to post a comment (if he wants
to). No rush :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/157
I think we are good here, thanks a lot for yours work :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/158
With the `ActionInvocation` in place I can access an action which means the
action can provide additional informations how to serialise/deserialize
object/string via dedicated interfaces, e.g
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/158
Merge it first as I think those changes are less intrusive as the whole
idea in my head ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/158
> I don't see where new parameter ActionInvocation is actually used. Is
that yet to come?
Not yet :)
---
If your project is set up for it, you can reply to this email and have y
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
Thanks a lot :) I see now what's going on but have no idea why :\
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
I don't see any other options now to merge this. @aleksandr-m could you
prepare that example app? I will be able to investigate what's wrong with my
solution ;-)
---
If your project is set up
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/158
WW-4835: Configurable handlers
This PR changes API a bit to allow pass current `ActionInvocation` to the
REST content type handlers to allow implement different behaviour based on a
current
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/157
Could you wait a bit with merging this PR? I have asked somebody to take a
look on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/156
Ach... you did merge it :\ But this isn't a valid RegEx :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
Would it be possible to share an application that replicates this
behaviour? Sorry for bothering you but I want to understand what's going on :)
---
If your project is set up for it, you can
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
> With the new code in #155 the custom type converter isn't initialized at
all. :(
w00t!
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
I have changed code a bit, can you try to test it on your side?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
... but where the `ObjectFactory#buildBean` is called? It should only be
called when building non-internal beans and when all the internal beans were
already instantiated. Can you post a call
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
See these screenshots
master
this branch
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
One more question: JDK version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
(on OSX)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
hm... but this example works for both branches - `master` and this:
```
DateConverter.convertToString()
localizedTextProvider=com.opensymphony.xwork2.util.StrutsLocalizedTextProvider
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
I have opened #155 - what do you think? @aleksandr-m can you test it
locally as I do not have the exact setup.
---
If your project is set up for it, you can reply to this email and have your
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/155
WW-4827: post init
Resolves [WW-4827](https://issues.apache.org/jira/browse/WW-4827)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/44
Hm... I wonder how hard it will be to make this configurable so we can keep
backward compatibility and allow enable a custom prefix on demand.
---
If your project is set up for it, you can
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
Hm... give me few minutes, maybe I will be able add support for it ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
I'm not sure if this is a good idea ... basically we need a
`@PostConstruct` mechanism in Struts DI - this can be easily achieved by
switching to Guice 3 and using CDI annotations
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/153
No better idea and I think we can assume when you need to inject the
`Container` you should always do it in a constructor.
---
If your project is set up for it, you can reply to this email
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/152
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/151
@sdutry yes, you are :)
http://struts.apache.org/submitting-patches.html#how-to-merge-pull-requests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/151
Looks good ð LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129282870
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129281192
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129281026
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129280692
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/150
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-examples/pull/14
See #13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-examples/pull/13
There is, under test now
http://markmail.org/message/d2kaut6iow335x6z
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/148
WW-4808: Multiple suffixes
Implements multiple Action suffixes in the Convention Plugin, right now you
can define suffixes as follow
```xml
```
[WW-4808](https
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-examples/pull/6
This PR won't be merged, not sure what was your intention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-examples/pull/5
Wow! Huge works, sorry but I missed this (and other) PR :( Can you open it
again against the latest `master` branch?
---
If your project is set up for it, you can reply to this email
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-examples/pull/2
Sorry, I missed this (and other) PR :( Can you re-open this PR against the
latest `master` branch?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/146
I think it would be good to have it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/145
Nope, I mean PRs are a GitHub specific feature, and looks like PR is always
merged with the `master` branch so checking out the PR isn't an option to test
non-`master` PRs ;-)
https
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/145
Nope, I'm getting compilation errors:
```
[ERROR] chainHistory = new LinkedList<>();
```
which means when I fetch your PR it was merged against the `master` branch
i
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/145
After checking out your PR locally I cannot build it on JDK6 (Struts 2.3.x
must be built on JDK 6)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/145
So you have made all the changes by hand, not be merging in another branch,
right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/145
Did you cherry-pick changes from your original branch? As this is the only
option to port changes merged to the `master` branch back to the `support-2-3`
branch.
---
If your project is set up
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/145
I'm not able to merge this PR as it also contains some changes from the
`master` branch - I have no idea how does it happen, maybe some GitHub PR's
magic :\ I will try to cherry-pick
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/141#discussion_r123429169
--- Diff:
core/src/main/java/com/opensymphony/xwork2/conversion/impl/DateConverter.java
---
@@ -48,7 +51,28 @@ public Object convertValue(Map<Str
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
Yes, you must branch off from the `support-2-3` branch and open a PR
against that branch after all
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
@yasserzamani do you want to port some of those changes to 2.3.33? Or at
least implement what @aleksandr-m mentioned in a comment?
---
If your project is set up for it, you can reply
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
If no objections I am going to merge this PR, btw. I have created a task to
implement Voters
https://issues.apache.org/jira/browse/WW-4807
---
If your project is set up for it, you can
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
Yeah I understand but still this affects non-Spring users. And I think this
can go in as is and we can improve and think about the Voters mechanism in 2.6.
---
If your project is set up
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
With the flag in place you can always disable it in your {{struts.xml}}
event it the Spring Plugin is present.
---
If your project is set up for it, you can reply to this email and have your
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
The case with those changes is that they will affect everyone even if you
don't use Spring so its scope should be narrowed just to the Spring Plugin. The
simplest solution is to add a flag
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts-site/pull/10
Adds info how to avoid a clash of Log4j2 libs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukaszlenart/struts-site patch-1
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/139
Thanks, merged :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/137
Please see docs, I have renamed the constant and the class
https://cwiki.apache.org/confluence/display/WW/Localization#Localization-Usingonlyglobalbundles
---
If your project is set up
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/138
Any other objections? I would start with what we have here and improve
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/137
Any objections to merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/135
I think with can go ahead and merge this, @aleksandr-m any objections?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/138
@aleksandr-m good point, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/138
Sure thing, please register an issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/138
`ParsePosition` is basically used to check if the whole value was used,
e.g. `1234abc` can be normally parsed into `1234` but comparing the
`ParsePosition` with length of the value you can
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/138
It's all about `String -> BigDecimal/Double -> String` conversion, so if
you have a `Double` in DB represented as `Double` it shouldn't be a problem.
This solves posting numbers with
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/138
WW-3171 WW-3357 WW-3650 WW-4581: Locale aware converters
This PR introduces Locale aware conversion of `BigDecimal` and `Double` and
`Double`
[WW-3171](https://issues.apache.org/jira
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r115808166
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/137
This is ready to test, to test the new bean you must specify the following
constant in `struts.xml`
```xml
```
now you can play with `struts.custom.i18n.resources
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/137
WW-4762: Default provider
Implements a default text provider which only operates on defined default
bundles and those provided via `struts.custom.i18n.resources`
Implements [WW-4762
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/134
@fustaki done, are we ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/135#discussion_r115664014
--- Diff:
core/src/main/java/com/opensymphony/xwork2/spring/SpringUtils.java ---
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2017 The Apache Software
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/71
Please open an issue in JIRA with all these details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/71
As far I can recall, there were some changes but please try to use 2.3.20
or even the latest version 2.3.32
---
If your project is set up for it, you can reply to this email and have your
reply
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/71
@DenizR I'm not sure what do you mean by that, but the mentioned issue was
fixed in Struts 2.3.20
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/134
WW-4749: Buffer/Flush behaviour in FreemarkerResult
Implements [WW-4749](https://issues.apache.org/jira/browse/WW-4749)
You can merge this pull request into a Git repository by running
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/133
hmm... very clever `method.getDeclaringClass()` should return the proper
class :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/132
ah... cool :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/132
Small changes like this you can directly push to the `master` branch,
opening PR and merging it, is time-consuming :)
---
If your project is set up for it, you can reply to this email and have
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/130
Good question... I have used those random card numbers in tests and looks
ok (but we will see)
https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm
---
If your
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/130
> I hope the regex is stable
What do you mean by that? I have used this
http://www.regular-expressions.info/creditcard.html
---
If your project is set up for it, you can re
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/130
This is ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/131
WW-4210: Type conversion class
This PR extends existing `TypeConversion` annotation to allow define
converters as a class instead of a raw string.
Implements [WW-4210](https
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/130
WW-3952: Credit card validator
Implements a credit card validator
[WW-3952](https://issues.apache.org/jira/browse/WW-3952)
You can merge this pull request into a Git repository by running
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/128
- ~`DoubleRangeFieldValidator`~
- ~`URLValidator`~
- ~`RequiredStringValidator`~
- ~`StringLengthFieldValidator`~
---
If your project is set up for it, you can reply to this email
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/129
This PR won't be merged, the `support-2-3` branch is used to keep support
for Struts 2.3.x where the `master` branch is used for current development of
Struts 2.5.x.
---
If your project
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/128
- ~`DoubleRangeFieldValidator`~
- `URLValidator`
- ~`RequiredStringValidator`~
- ~`StringLengthFieldValidator`~
---
If your project is set up for it, you can reply to this email
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/128
- ~`DoubleRangeFieldValidator`~
- `URLValidator`
- ~`RequiredStringValidator`~
- `StringLengthFieldValidator`
---
If your project is set up for it, you can reply to this email
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/128
- ~`DoubleRangeFieldValidator`~
- `URLValidator`
- `RequiredStringValidator`
- `StringLengthFieldValidator`
---
If your project is set up for it, you can reply to this email
GitHub user lukaszlenart opened a pull request:
https://github.com/apache/struts/pull/128
Multidimensional validation
This PR adds support for validation of Collections in field validators
Resolves WW-4578
You can merge this pull request into a Git repository by running
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/127
Did you notice that this targets Struts 2.6? I would rather postpone this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-extras/pull/3
You can merge it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/124
Great work, LGTM! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts-extras/pull/3
This is great, osm work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108500937
--- Diff:
struts2-custom-results-plugin/src/main/resources/struts-plugin.xml ---
@@ -0,0 +1,18 @@
+
+
+http://struts.apache.org/dtds
1 - 100 of 356 matches
Mail list logo
