Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/97
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
it is ready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/104
this fix doesn't make sense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/104
A second thought max of 512 could be a better number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/104
WW-4620 ParametersInterceptor should check collection index to against DOS
ParametersInterceptor should check collection index to against DOS
Check the parameters map to have only 255
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
@lukaszlenart can you check please the result in jenkins because I am
getting success build for Portlet here in my PC.
But here it gets
`unexpected status code [500] at URL
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/103
WW-4650 Json deserialization does not work in 2.5.1
Fix for WW-4650 broked by WW-4558 and test cases changes too.
You can merge this pull request into a Git repository by running:
$ git
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
Yep it was too fast; that fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
Maybe It is not a good idea because this test is failing and I don't have
the clue about what is wrong. Do you know why?
>
> Tests run: 1659, Failures: 1, Errors: 0, Skipp
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
Here is the fix:
```
org.apache.maven.plugins
maven-surefire-plugin
2.19.1
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
NOp :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
Sorry I compiled the wrong branch, I was able to duplicate the issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
> openjdk version "1.8.0_91"
> OpenJDK Runtime Environment (build 1.8.0_91-b14)
> OpenJDK 64-Bit Server VM (build 25.91-b14, mixed mode)
---
If your project is set
Github user victorsosa commented on the issue:
https://github.com/apache/struts/pull/98
On my end.
[INFO] Installing
/home/vns/workspace/struts/plugins/testng/target/struts2-testng-plugin-2.5.1-SNAPSHOT-sources.jar
to
/home/vns/.m2/repository/org/apache/struts/struts2
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221804220
Yes, I am ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/97#issuecomment-221640016
@aleksandr-m It is set to English in here:
https://github.com/apache/struts/blob/master/core/src/main/java/org/apache/struts2/dispatcher/multipart
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/96#issuecomment-221600945
PR remove, it wasn't requested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/98
WW-4638 - TestNG 6.9.10 dependency error
Fix dependency issue and update to 1.7 jdk
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221567053
I will fix the 103 test cases, give me some time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/97
WW-4636 File upload error message always in default language
File upload error message always in default English language.
Content negotiation is a mechanism defined in the HTTP
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221314653
@aleksandr-m You mean something like in
controlheader.ftl and .tdInput {text-align:left;} in styles.css. <-- This is
for 2.5.
THat means **drop al
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/96#issuecomment-221015218
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/96#issuecomment-220947364
But it is using the parameter align instead of a css class. the align
parameter is deprecated in html 5.
---
If your project is set up for it, you can reply to this
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/96
WW-4634
Cherry-pick PR for support-2-3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts support-2-3
Alternatively you can
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-220818804
@lukaszlenart ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-220740769
It will break back compatibility as @lukaszlenart said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219826548
the css class for that cell is in the controlheader.ftl already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219826190
OH ok, got you
https://github.com/apache/struts/tree/master/core/src/main/resources/template/archive
I miss that.
---
If your project is set up for it
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219820007
@lukaszlenart the parameter align was remove on this commit
https://github.com/victorsosa/struts/commit/a0b34806b0f700a1fd240b698c4cec474711bbd0
---
If your
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219813310
CSS class to this table cell is what we have now and to have back
compatibility as @lukaszlenart said.
---
If your project is set up for it, you can reply to this
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219713305
Another thing I will change the name to just
> align-center
because this css class can be used in other places that are using the align
attrib
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63517163
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-219709110
Yes, it fix the main issue and keep the back compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63515782
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/95
WW-4634 Centre alignment doesn't seem to work in Velocity tags
Fix for WW-4634
Centre alignment doesn't seem to work in Velocity tags
You can merge this pull request
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/89#issuecomment-216887974
Closing this PR; I didn't get any support from this Sitemesh community;
this project seems to be dead; there is not point on upgrade it.
---
If your project i
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-206506526
Code implement by Lukas already
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/93#issuecomment-206505978
Close this PR; the code was implemented by aleksandr-m
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-205401807
Thanks for you help, Aleksandr; can you please post the stack trace of
that? So I can look with more info into ResourceFinder
---
If your project is set up for it
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/93#issuecomment-205006766
This is the stack trace of the recently portlet-webapp test fails
```
2016-04-03 15:47:03,142 ERROR [btpool0-1] dispatcher.Jsr168Dispatcher
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/94
WW-4623 Multiple tiles.xml in web.xml
WW-4623, WW-4624
Multiple tiles.xml in web.xml
Now it will load all the "**/tiles*.xml" below WEB-INF and also load
individual f
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/93#issuecomment-204507324
Travis is no compiling correctly because is using OpenJDK 7 instead of Java
JDK 7
---
If your project is set up for it, you can reply to this email and have your
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/93
WW-4622 [struts2-tiles-plugin]
[StrutsWildcardServletTilesApplicationContext] getRealPath
[struts2-tiles-plugin] [2.3.28]
[StrutsWildcardServletTilesApplicationContext] getRealPath
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/92#issuecomment-204501865
Dumped, too many conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/92
WW-4622 [struts2-tiles-plugin]
[StrutsWildcardServletTilesApplicationContext] getRealPath
[struts2-tiles-plugin] [2.3.28]
[StrutsWildcardServletTilesApplicationContext] getRealPath
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/91#issuecomment-204499487
I will close this PR to open one on the correct support branch. Sorry for
the trouble.
---
If your project is set up for it, you can reply to this email and have
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/91
WW-4622 [struts2-tiles-plugin]
[StrutsWildcardServletTilesApplicationContext] getRealPath
[struts2-tiles-plugin] [2.3.28]
[StrutsWildcardServletTilesApplicationContext] getRealPath
GitHub user victorsosa reopened a pull request:
https://github.com/apache/struts/pull/87
WW-4558 contentType override ignored for JSONInterceptor
From now on:
The "accept" request header parameter must be "application/json" or
"application/js
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/83#issuecomment-191989638
Green :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/90
WW-4610 ServletActionContext.getRequest() doesn't return the
MultiPartRequestWrapper (or StrutsRequestWrapper) when using StrutsPrepareFilter
Now StrutsPrepareFilter se
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/89#issuecomment-191471653
for example VelocityPageFilter and FreemarkerPageFilter aren't used, right?
and can be deleted
---
If your project is set up for it, you can reply to this emai
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/89#issuecomment-191426848
I did'nt because I did not get any compile error here, weird; But I am
working on it so the code compile
---
If your project is set up for it, you can reply to
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/89
WW-4356 Implement new Sitemesh plugin based on Sitemesh3 - Sitemesh update
WW-4356
Implement new Sitemesh plugin based on Sitemesh3
sitemesh update
You can merge this pull
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/87#discussion_r52929566
--- Diff:
plugins/json/src/main/java/org/apache/struts2/json/JSONInterceptor.java ---
@@ -70,17 +70,22 @@
private boolean noCache = false
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/87
Ww 4558 contentType override ignored for JSONInterceptor
From now on:
The "accept" request header parameter must be "application/json" or
"application/json-rpc&q
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/84#discussion_r50339318
--- Diff:
plugins/sitemesh/src/main/java/org/apache/struts2/sitemesh/VelocityDecoratorServlet.java
---
@@ -78,17 +88,18 @@ public void init(ServletConfig
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/84
WW-3940 Upgrade to Velocity Tools 2.0
JWebUnit upgrade to 3.3 too
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts ww-3940
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/83
Easymock update to 3.4
This is the upgrade of the Easymock library for the unit tests
Every unit test is changed to keep the same result but using the new API.
You can merge this pull
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/79#discussion_r50120845
--- Diff:
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -110,7 +110,9 @@ public void doExecute(String location
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/80
WW-4456 Got NPE when File Upload Limitation exceeds in portal env
HI Lukasz,
This is a proposal to fix WW-4456 - Got NPE when File Upload Limitation
exceeds in portal env
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/79
WW-4412 Context started without being closed
Patch for WW-4412
Context started without being closed
You can merge this pull request into a Git repository by running:
$ git pull
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/74#issuecomment-172694546
Closed; Just got contaminated with other changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/78
update pull
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts patch
Alternatively you can review and apply these changes as
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/77
WW-4412 Context started without being closed
Patch WW-4412
Context started without being closed
Now the context is closed after been used.
You can merge this pull request
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/76#issuecomment-172679977
Closed this pull request is right; I will send another one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/76
WW-4412 Context started without being closed
WW-4412
Context started without being closed
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/74
propose fix for ww-4456
HI Lukasz,
This is a proposal to fix WW-4456 - Got NPE when File Upload Limitation
exceeds in portal env.
We should catch in any case a
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/71#issuecomment-172194026
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/70#issuecomment-170337968
ok, PR closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/71
patch ww-3266 getFieldValue() method of ValueStackDataSource uses
getDescription() to get field value may not appropriate.
patch ww-3266
getFieldValue() method of ValueStackDataSource
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/70#issuecomment-169070596
This close also the CVE-2014-0112, CVE-2014-0113 and CVE-2014-0116
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/70#discussion_r48856556
--- Diff:
core/src/test/java/com/opensymphony/xwork2/security/DefaultExcludedPatternsCheckerTest.java
---
@@ -11,6 +11,9 @@
public void
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/70
WW-4582 Permanent patch for security issue CVE-2014-0094 adds 'class' to
exclude
adds 'class' to exclude params in ParametersInterceptor (avoid ClassLoader
manipulation)
You
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/69
Patch WW-4312 A problem on Iterator tag
Allow null values in the iterator tag
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/68
Merge pull request #2 from apache/master
Merge changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts patch
Alternatively
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/66#issuecomment-168793429
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/66#issuecomment-168781813
Done, check Jenkins; it seems to be blocked
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/66#issuecomment-168777910
Yea, My bad; Let me fix it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/64#issuecomment-168775787
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/67
Patch WW-4381 upgrade to jasperreports 6.0
Also I accidentally revert the Patch WW-3462 so here is the fix again
You can merge this pull request into a Git repository by running
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/66
Jsonencoding UTF-8
Now the Json encoding by default is utf-8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/64
Patch WW-3462 connection open after report generation
Now the connection is close after been used.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/63
fix for WW-4573
NPE/ concurrent modification exception
using a CopyOnWriteArrayList. This is to keep Memory consistency on the
ValueStack.
You can merge this pull request into a Git
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/62#discussion_r48685943
--- Diff: core/src/main/java/org/apache/struts2/result/PostbackResult.java
---
@@ -76,6 +76,10 @@
*/
public class PostbackResult extends
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/62
Patch ww-4564
set content type see ww-4564
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts patch
Alternatively you can
1 - 100 of 105 matches
Mail list logo
