Re: 2.5 => 3.0 (was Re: @StringLengthFieldValidator for 2.5)

2012-07-31 Thread Łukasz Lenart
2012/7/27 Paul Benedict : > Thoughts? With 3.0 we must clean up the whole code base, rename packages, remove obsolete classes and methods and move Convention into Core and so on. With 2.5 we could do some less user harming things like remove some plugins, some classes and methods and leave the res

2.5 => 3.0 (was Re: @StringLengthFieldValidator for 2.5)

2012-07-27 Thread Paul Benedict
I began to recently wonder if 2.5 should really be called 3.0. When we originally had the discussion, I advocated going to 2.5 to show maturity but also because the current versioning was far away (probably 2.1 was out then). I also probably didn't realize if any of the changes would be major. Wel

Re: @StringLengthFieldValidator for 2.5

2012-07-23 Thread Rene Gielen
In this case JIRA may be a little too opaque. The confluence page is good for keeping oversight and draft concepts. Am 7/24/12 8:50 , schrieb Lukasz Lenart: > Or you can just add an issue with fix version 2.5 > > 2012/7/24 Łukasz Lenart : >> Here it is [1], basically it was about Struts 3, but St

Re: @StringLengthFieldValidator for 2.5

2012-07-23 Thread Rene Gielen
Hmm ... obvious enough I could have found it myself :) Am 7/24/12 8:48 , schrieb Łukasz Lenart: > Here it is [1], basically it was about Struts 3, but Struts 2.5 is > more in range now ;-) > > [1] https://cwiki.apache.org/confluence/display/WW/Struts+2.5 > > > Regards > -- René Gielen http:/

Re: @StringLengthFieldValidator for 2.5

2012-07-23 Thread Lukasz Lenart
Or you can just add an issue with fix version 2.5 2012/7/24 Łukasz Lenart : > Here it is [1], basically it was about Struts 3, but Struts 2.5 is > more in range now ;-) > > [1] https://cwiki.apache.org/confluence/display/WW/Struts+2.5 > > > Regards > -- > Łukasz > mobile +48 606 323 122 http://www

Re: @StringLengthFieldValidator for 2.5

2012-07-23 Thread Łukasz Lenart
Here it is [1], basically it was about Struts 3, but Struts 2.5 is more in range now ;-) [1] https://cwiki.apache.org/confluence/display/WW/Struts+2.5 Regards -- Łukasz mobile +48 606 323 122 http://www.lenart.org.pl/ Warszawa JUG conference - Confitura http://confitura.pl/ 2012/7/24 Rene Giel

Re: @StringLengthFieldValidator for 2.5

2012-07-23 Thread Rene Gielen
You are right, these String typed attributes are kind of ugly. It might be worth changing them for a planned "breaking" release. That said, do we have a Confluence page to gather such planned breaking changes? Remember, we will have only one shot in a longer time period to make the Struts 2 API br

@StringLengthFieldValidator for 2.5

2012-07-22 Thread Paul Benedict
I noticed @StringLengthFieldValidator uses String type for minLength and maxLength. I find this unexpected. Shouldn't we use the int type for these fields? I would vote to go through the annotations and fix the types for 2.5 -- since 2.5 is supposed to break backwards compatibility. Thoughts? Pau