Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-173253337
Done. We should add notice in the release notes about breaking change in
`ResultInfo` / `@Result` for those who use `Result.name()` or extend
`ResultInfo`.
---
If y
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-173142656
I would like to merge this PR and start release process of BETA3 :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-173117164
@aleksandr-m I'm ok with that and I agree with @swiftelan - let's follow
standards
---
If your project is set up for it, you can reply to this email and have your
r
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50221451
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResul
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50173826
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResult
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-172982203
@swiftelan So you are proposing to change only type? The name of the
attribute will stay the same i.e `name`, right? There is still some chance that
something going t
I can't see a reason not to support both.
(*Chris*)
On Tue, Jan 19, 2016 at 12:06 PM, swiftelan wrote:
> Github user swiftelan commented on the pull request:
>
> https://github.com/apache/struts/pull/75#issuecomment-172970495
>
> @aleksandr-m
>
> An annotation attribute that is def
Github user swiftelan commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-172970495
@aleksandr-m
An annotation attribute that is defined as an array does not have to have
the curly braces to define a single value for that attribute.
Ba
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50163270
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResul
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-172947410
@swiftelan I was thinking about that too, BUT:
* It will break backward compatibility
* I kind of like that annotation attributes looks the same as in xml
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50153311
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResult
Github user swiftelan commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-172880314
Annotations allow multivalued attributes in the form of arrays. Using this
makes it obvious that you can supply multiple result names for a single result
configuration.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50081302
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResul
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50080211
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResul
Github user aleksandr-m commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50079358
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResult
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/75#issuecomment-172754377
Great idea!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/75#discussion_r50076520
--- Diff:
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
---
@@ -777,11 +777,21 @@ protected Class verifyResul
GitHub user aleksandr-m opened a pull request:
https://github.com/apache/struts/pull/75
WW-4590 - Allow to use multiple names in result
Allow to use multiple values in `result` tag `name` attribute and in
`Result` annotation `name`.
So this typical configuration:
`
19 matches
Mail list logo
