Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38966472
Please close this PR, patch applied.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38965395
Whoa! You are right :-) `XmlConfigurationProvider` is created per config
file, eg. `struts-plugin.xml` but we can have many such files on classpath,
that's why `urls`
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38222608
Ok, I will double check but it looks like this needs further refactoring -
it can be done later
---
If your project is set up for it, you can reply to this email and
Github user gregh3269 commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38221955
I used my dev environment, I had already modified XmlConfigurationProvider
for the tomcat virtual server mods. The pull looks ok.
I checked double reloading comes
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38220286
What app do you use to check that? Simple struts2-blank is enough to
investigate that?
---
If your project is set up for it, you can reply to this email and have your
It does fix the reloading issue, but now it reloads a whole lot more files.
I can see it checks the files per configuration, but it seems to check them
twice? Whether it actually reloads them twice I will investigate.
If you log needsReload() {..} you can see, for me its gone from 4 to 11
files!
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38199004
You must have a strange setup, though. `XmlConfigurationProvider` is
instantiated per each configuration file, i.e. `struts-default.xml` (one),
`struts-plugin.xml` (ma
Github user code4craft commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38186496
There is only one "struts-biz.xml" file and one "struts-plugin.xml" file in
the web project. But "struts-plugin.xml" files in other jar (such as
"struts-spring-plugin.ja
...thought there should only be one url in urls.hasNext() for each file,
maybe there are multiple struts-biz.xml file/jars?
On 20 March 2014 12:14, code4craft wrote:
> Github user code4craft commented on the pull request:
>
> https://github.com/apache/struts/pull/6#issuecomment-38159811
>
>
Github user code4craft commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38159811
The JIRA issue is
[https://issues.apache.org/jira/browse/WW-4302](https://issues.apache.org/jira/browse/WW-4302).
---
If your project is set up for it, you can reply to
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38155805
Where is JIRA issue for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user aafly commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38154616
I ran all the tests passed, and my demo works well in reloading the file
'struts-plugin.xml' after the change.
---
If your project is set up for it, you can reply to this em
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/6#issuecomment-38027870
Have you tested that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
GitHub user aafly opened a pull request:
https://github.com/apache/struts/pull/6
loadedFileUrls only contains the last one of urls with same file name
In XmlConfigurationProvider, the field `loadedFileUrls` contains the xml
files loaded. The loaded files will be checked if they are
15 matches
Mail list logo
