Re: [S2.1] Moving testing classes from core to a new module

2008-01-27 Thread Antonio Petrelli
2008/1/25, Antonio Petrelli <[EMAIL PROTECTED]>: > Hi friends, > during my license-problem-busting I noticed that in struts-core there > are some classes using TestNG and JUnit, therefore these dependencies > must be at compile-scope. > So my question is: isn't it better to move these classes to a

Re: [S2.1] Moving testing classes from core to a new module

2008-01-26 Thread Antonio Petrelli
2008/1/26, Ted Husted <[EMAIL PROTECTED]>: > On Jan 26, 2008 5:29 AM, Antonio Petrelli <[EMAIL PROTECTED]> wrote: > > The problem is that, when we package everything in binary form, we > > ship 3rd party packages together with Struts 2. We should *at least* > > add a line in the NOTICE.txt file, an

Re: [S2.1] Moving testing classes from core to a new module

2008-01-26 Thread Ted Husted
On Jan 26, 2008 5:29 AM, Antonio Petrelli <[EMAIL PROTECTED]> wrote: > The problem is that, when we package everything in binary form, we > ship 3rd party packages together with Struts 2. We should *at least* > add a line in the NOTICE.txt file, and when the package is not > licensed under the ASL,

Re: [S2.1] Moving testing classes from core to a new module

2008-01-26 Thread Antonio Petrelli
2008/1/26, Piero Sartini <[EMAIL PROTECTED]>: > > during my license-problem-busting I noticed that in struts-core there > > are some classes using TestNG and JUnit, therefore these dependencies > > must be at compile-scope. > > Sorry for the (maybe) stupid question - but does this mean that there a

Re: [S2.1] Moving testing classes from core to a new module

2008-01-25 Thread Ted Husted
It sounds reasonable to me, so long as we are talking about /s/shale-test/struts-test :) On Jan 25, 2008 2:15 PM, Antonio Petrelli <[EMAIL PROTECTED]> wrote: > Hi friends, > during my license-problem-busting I noticed that in struts-core there > are some classes using TestNG and JUnit, therefore t

Re: [S2.1] Moving testing classes from core to a new module

2008-01-25 Thread Piero Sartini
> during my license-problem-busting I noticed that in struts-core there > are some classes using TestNG and JUnit, therefore these dependencies > must be at compile-scope. Sorry for the (maybe) stupid question - but does this mean that there are licensing problems with TestNG and S2? It seems tha

Re: [S2.1] Moving testing classes from core to a new module

2008-01-25 Thread Antonio Petrelli
2008/1/25, Brian Pontarelli <[EMAIL PROTECTED]>: > > Those are for base classes for testing. JCatapult solves this problem > with a separate JAR called jcatapult-core-test.jar, which is along the > same lines as a new maven project as you mention. In fact building a different JAR is easily done wi

Re: [S2.1] Moving testing classes from core to a new module

2008-01-25 Thread Brian Pontarelli
Those are for base classes for testing. JCatapult solves this problem with a separate JAR called jcatapult-core-test.jar, which is along the same lines as a new maven project as you mention. Another way is to remove the base class and provide test helper toolkits. JCatapult also does this in

[S2.1] Moving testing classes from core to a new module

2008-01-25 Thread Antonio Petrelli
Hi friends, during my license-problem-busting I noticed that in struts-core there are some classes using TestNG and JUnit, therefore these dependencies must be at compile-scope. So my question is: isn't it better to move these classes to a new module, like "shale-test". to help other people testing