Re: [Standalone Tiles] Maybe too much bound to Locale

2006-03-29 Thread Antonio Petrelli
Greg Reddin ha scritto: But what about adding an API that requires a generic Object key parameter to support the 3rd dimension? That would be fine! But to support also the 4th, the 5th... ;-) Well, it can get pretty crazy. I think we should *at most* provide support for the 3rd with an

Re: [Standalone Tiles] Maybe too much bound to Locale

2006-03-28 Thread Greg Reddin
On Mar 28, 2006, at 9:47 AM, Antonio Petrelli wrote: Actually Dimensions chooses from name, user role and channel, or only name and user role, Yes, I forgot about user role :-) But what about adding an API that requires a generic Object key parameter to support the 3rd dimension? That

Re: [Standalone Tiles] Maybe too much bound to Locale

2006-03-28 Thread Antonio Petrelli
Hi Greg! Greg Reddin ha scritto: Here's the way I see it: We see the tiles definitions set as a 2-dimensional data set. One axis is the name and the other is the locale. There's the added wrinkle that definition data from one name can inherit data from another name. By adding "channel" to

Re: [Standalone Tiles] Maybe too much bound to Locale

2006-03-28 Thread Greg Reddin
On Mar 27, 2006, at 5:54 AM, Antonio Petrelli wrote: I've noticed that both DefinitionsFactory and ComponentDefinitions are both too (IMHO) tightly bound to the Locale. What I mean is that maybe using Locale class to distinguish between different sets of definitions is not a good idea. From

Re: [Standalone Tiles] Maybe too much bound to Locale

2006-03-28 Thread Antonio Petrelli
Antonio Petrelli ha scritto: I've noticed that both DefinitionsFactory and ComponentDefinitions are both too (IMHO) tightly bound to the Locale. I forgot to mention ComponentDefinition (without the 's') and TilesUtilImpl. In particular TilesUtilImpl.getDefinition has calls to ServletRequest.ge

Re: [Standalone Tiles] Maybe too much bound to Locale

2006-03-27 Thread Antonio Petrelli
Craig McClanahan ha scritto: One of the reasons I think using a Locale is a good choice is that you'll need one later on anyway ... to generate Locale-sensitive date formats, for example. You're right. But the big problem is that Locale is a final class. I think that an "extensible" locale cla

Re: [Standalone Tiles] Maybe too much bound to Locale

2006-03-27 Thread Craig McClanahan
On 3/27/06, Antonio Petrelli <[EMAIL PROTECTED]> wrote: > > I've noticed that both DefinitionsFactory and ComponentDefinitions are > both too (IMHO) tightly bound to the Locale. > What I mean is that maybe using Locale class to distinguish between > different sets of definitions is not a good idea.

[Standalone Tiles] Maybe too much bound to Locale

2006-03-27 Thread Antonio Petrelli
I've noticed that both DefinitionsFactory and ComponentDefinitions are both too (IMHO) tightly bound to the Locale. What I mean is that maybe using Locale class to distinguish between different sets of definitions is not a good idea. From my point of view, I think that where you are using Locale