The PR is ready for review
https://github.com/apache/struts/pull/252
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev
wt., 25 wrz 2018 o 10:43 napisał(a):
> > I finished implementing new interfaces and just wonder if I should
> > change `ValidationAware` as well - I thought about splitting it into
> > three smaller interfaces that can be used separately -
> > ValidationErrorsAware, ValidationMessagesAware and
> >
> > > Same refactor would be nice for Struts internal CDI by
> > > finding all references of @Inject and refactoring them [1]. This changes
> > > isn't backward compatible so no need for deprecation I think.
> >
> > FIX: This change (finding all references of @Inject and refactoring them
> > e.g. s
śr., 19 wrz 2018 o 13:30 Yasser Zamani napisał(a):
> On 9/19/2018 2:17 PM, Yasser Zamani wrote:
> > Same refactor would be nice for Struts internal CDI by
> > finding all references of @Inject and refactoring them [1]. This changes
> > isn't backward compatible so no need for deprecation I think.
śr., 19 wrz 2018 o 13:42 Yasser Zamani napisał(a):
> Yes I saw :) thanks a lot keeping this one to be done! By the way I'm
> trying to build 2.3.x with latest struts-master or etc to see if is
> possible to automate WW-4951.
Don't bother, it isn't :(
Regards
--
Łukasz
+ 48 606 323 122 http://w
On 9/19/2018 2:23 PM, Lukasz Lenart wrote:
> Ah, right :) I knew that I saw this idea somewhere but I couldn't
> recall.
Yes I saw :) thanks a lot keeping this one to be done! By the way I'm
trying to build 2.3.x with latest struts-master or etc to see if is
possible to automate WW-4951.
Regard
On 9/19/2018 2:17 PM, Yasser Zamani wrote:
> Same refactor would be nice for Struts internal CDI by
> finding all references of @Inject and refactoring them [1]. This changes
> isn't backward compatible so no need for deprecation I think.
FIX: This change (finding all references of @Inject and r
śr., 19 wrz 2018 o 11:41 Yasser Zamani napisał(a):
> On 9/19/2018 10:33 AM, christoph.nenn...@bmw.de wrote:
> > Oh yes, that sounds like a great idea!
> > I wonder why we didn't come up with this earlier, the simplest ideas are
> > the hardest to find ;)
>
> We already have discovered and propose
On 9/19/2018 10:53 AM, Lukasz Lenart wrote:
> Cool, first step https://github.com/apache/struts/pull/252 - WIP :)
+1, thanks a lot! Same refactor would be nice for Struts internal CDI by
finding all references of @Inject and refactoring them [1]. This changes
isn't backward compatible so no need
On 9/19/2018 10:33 AM, christoph.nenn...@bmw.de wrote:
> Oh yes, that sounds like a great idea!
> I wonder why we didn't come up with this earlier, the simplest ideas are the
> hardest to find ;)
We already have discovered and proposed this in security list [1] about
one year ago :)
LGTM also
śr., 19 wrz 2018 o 09:03 napisał(a):
>
> Oh yes, that sounds like a great idea!
> I wonder why we didn't come up with this earlier, the simplest ideas are the
> hardest to find ;)
>
> My preference would be the name withSession.
Cool, first step https://github.com/apache/struts/pull/252 - WIP :)
e.org]
Gesendet: Mittwoch, 19. September 2018 08:50
An: Struts Developers List
Betreff: Avoid using setters
Hi,
In matter of security I wonder if we should stop using setters in
internal API. Like in SessionAware interface we use setSession() and
each actions must implement this method. Then we have a
Hi,
In matter of security I wonder if we should stop using setters in
internal API. Like in SessionAware interface we use setSession() and
each actions must implement this method. Then we have a logic to avoid
mapping incoming values to setSession() to permit injecting values
into Session.
Instea
13 matches
Mail list logo
