Re: Bean Validation Plugin in 2.5

2015-06-23 Thread Lukasz Lenart
2015-06-23 16:28 GMT+02:00 Christoph Nenning : > I guess the 'guide' must be re-generated and that takes place during > releases? > http://struts.apache.org/docs/validation.html Yes, it must be exported but it's a separated process and can be performed independently Regards -- Łukasz + 48 606 3

Re: Bean Validation Plugin in 2.5

2015-06-23 Thread Christoph Nenning
truts Developers List , > Date: 12.06.2015 11:13 > Subject: Re: Bean Validation Plugin in 2.5 > > Hi Christoph, > > thanks for the code review and fixes. > > I already added a basic plugin documentation: > https://cwiki.apache.org/confluence/display/WW/Bean+Validat

Re: Bean Validation Plugin in 2.5

2015-06-15 Thread Christoph Nenning
> From: Johannes Geppert > To: Struts Developers List , > Date: 15.06.2015 08:58 > Subject: Re: Bean Validation Plugin in 2.5 > > Hi Christoph, > > I reverted some of your changes because it has broken the build. > > [ERROR] /home/jenkins/jenkins-slave/workspace

Re: Bean Validation Plugin in 2.5

2015-06-14 Thread Johannes Geppert
://twitter.com/jogep 2015-06-12 15:08 GMT+02:00 Christoph Nenning : > > From: Lukasz Lenart > > To: Struts Developers List , > > Date: 12.06.2015 14:58 > > Subject: Re: Bean Validation Plugin in 2.5 > > > > 2015-06-12 14:45 GMT+02:00 Christoph Nenning > : > >

Re: Bean Validation Plugin in 2.5

2015-06-12 Thread Christoph Nenning
> From: Lukasz Lenart > To: Struts Developers List , > Date: 12.06.2015 14:58 > Subject: Re: Bean Validation Plugin in 2.5 > > 2015-06-12 14:45 GMT+02:00 Christoph Nenning : > >> Do you already have a confluence account? > > > > Just created: cnenning

Re: Bean Validation Plugin in 2.5

2015-06-12 Thread Lukasz Lenart
2015-06-12 14:45 GMT+02:00 Christoph Nenning : >> Do you already have a confluence account? > > Just created: cnenning Extended your access rights to be full-blown committer :) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/

Re: Bean Validation Plugin in 2.5

2015-06-12 Thread Christoph Nenning
flow I want to give the plugin some space in the 'guide' section to make it more visible. Regards, Christoph > From: Johannes Geppert > To: Struts Developers List , > Date: 12.06.2015 11:13 > Subject: Re: Bean Validation Plugin in 2.5 > > Hi Christoph, > &g

Re: Bean Validation Plugin in 2.5

2015-06-12 Thread Johannes Geppert
# web: http://www.jgeppert.com twitter: http://twitter.com/jogep 2015-06-12 10:57 GMT+02:00 Christoph Nenning : > > From: Johannes Geppert > > To: Struts Developers List , > > Date: 27.05.2015 21:18 > > Subject: Re: Bean

Re: Bean Validation Plugin in 2.5

2015-06-12 Thread Christoph Nenning
> From: Johannes Geppert > To: Struts Developers List , > Date: 27.05.2015 21:18 > Subject: Re: Bean Validation Plugin in 2.5 > > Just pushed first version of new bean validation plugin. > In general it is based on Umesh works, but I renamed some thinks and made >

Re: Bean Validation Plugin in 2.5

2015-05-27 Thread Umesh Awasthi
I think that is a mistake from my end..that github project only have a sample example..I will also check as I remember I created application with different examples to test it out. Thanks Umesh On Wed, May 27, 2015 at 11:17 PM, Johannes Geppert wrote: > Thanks Umesh, I will take a look at it. >

Re: Bean Validation Plugin in 2.5

2015-05-27 Thread Johannes Geppert
Thanks Umesh, I will take a look at it. I will check if we can reuse some current showcase validation examples. # web: http://www.jgeppert.com twitter: http://twitter.com/jogep 2015-05-27 21:38 GMT+02:00 Umesh Awasthi : > Thanks Johannes, > > I cre

Re: Bean Validation Plugin in 2.5

2015-05-27 Thread Umesh Awasthi
Thanks Johannes, I created struts2-jsr303-example ( https://github.com/strutsathon/struts2-jsr303-example) , not tested it for very long If needed, I can work on it to fix it Thanks Umesh On Wed, May 27, 2015 at 12:18 PM, Johannes Geppert wrote: > Just pushed first version of new bean validati

Re: Bean Validation Plugin in 2.5

2015-05-27 Thread Johannes Geppert
Just pushed first version of new bean validation plugin. In general it is based on Umesh works, but I renamed some thinks and made some small improvements. Also I added some first basic test cases. Would be nice if someone likes to try the new bean validation plugin. Next step is preparing a examp

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Lukasz Lenart
2015-05-22 8:28 GMT+02:00 Johannes Geppert : > That's great Umesh! > > @Lukasz > Is maybe a ICLA required for that? Good question but I assumed no if this will be contributed via patch/GitHub PR - it's the same as others do > After import I would suggest to rename it to bean-validation-plugin. >

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Johannes Geppert
That's great Umesh! @Lukasz Is maybe a ICLA required for that? After import I would suggest to rename it to bean-validation-plugin. I think having a specific JSR number in the name is confusing people they don't know it. And if we later some other JSR's are following for bean validation it is not

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Lukasz Lenart
2015-05-21 18:24 GMT+02:00 Umesh Awasthi : > I am more than happy to donate the plugin. Please let me know what need to > be done from my end for this. Great! There are two options: - prepare a patch and attach it to a JIRA ticket - prepare a PR on GitHub and register task in the JIRA in both opt

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Umesh Awasthi
I am more than happy to donate the plugin. Please let me know what need to be done from my end for this. Thanks Umesh On Thu, May 21, 2015 at 12:37 AM, Lukasz Lenart wrote: > 2015-05-21 9:17 GMT+02:00 Christoph Nenning >: > > Yeah, would be great to support more JSRs. > > I would even go furth

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Lukasz Lenart
2015-05-21 9:17 GMT+02:00 Christoph Nenning : > Yeah, would be great to support more JSRs. > I would even go further and deprecate struts validation. > > Well, ok I guess struts validation is more powerfull and will stay. Just > want to emphasize that I prefer to rely on existing specs. I would li

Re: Bean Validation Plugin in 2.5

2015-05-21 Thread Christoph Nenning
> Hi all, > > I just played a little bit with the bean validation plugin created by Umesh > Awasthi. > > https://github.com/struts-community-plugins/jsr303-validator-plugin > > My first tests are successfully and it works fine for me. > > What you all think about an import to our main distribu

Re: Bean Validation Plugin in 2.5

2015-05-20 Thread Lukasz Lenart
If Umesh accept that and he will donate the plugin, why not :) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2015-05-20 19:51 GMT+02:00 Johannes Geppert : > Hi all, > > I just played a little bit with the bean validation plugin created by Umesh > Awasthi. > > https://github.com/

Bean Validation Plugin in 2.5

2015-05-20 Thread Johannes Geppert
Hi all, I just played a little bit with the bean validation plugin created by Umesh Awasthi. https://github.com/struts-community-plugins/jsr303-validator-plugin My first tests are successfully and it works fine for me. What you all think about an import to our main distribution for 2.5? Bean Va