lukaszlenart merged PR #676:
URL: https://github.com/apache/struts/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@struts.apach
kusalk opened a new pull request, #676:
URL: https://github.com/apache/struts/pull/676
WW-5300
--
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
2013/4/26 Ken McWilliams :
> I still don't understand what the use case isxe for the two filters. In the
> StrutsPrepareAndExecuteFilter the source of both the Prepare and Execute
> filters are clearly concatenated.
>
> What kind of 3rd party functionality will need to grab onto struts2
> resources
eded them. I don't know what the code is
> like
> >> > now, but it sounds like perhaps it still hasn't completely gotten away
> >> > from
> >> > statics and threadlocals.
> >> >
> >> > As a side note, back then (2008?) we did some profiling
> > from
>> > statics and threadlocals.
>> >
>> > As a side note, back then (2008?) we did some profiling and found that
>> > actually all the thread locals were eating up a bunch of time in the
>> > request, so it is more than just a general &qu
> > their removal.
> >
> > Again, my knowledge is pretty dated, but that's where things came from.
> >
> > Don
> >
> >
> > On Tue, Apr 23, 2013 at 7:40 PM, ppm10103 wrote:
> >>
> >>
> >> At 2013-04-24
Again, my knowledge is pretty dated, but that's where things came from.
>
> Don
>
>
> On Tue, Apr 23, 2013 at 7:40 PM, ppm10103 wrote:
>>
>>
>> At 2013-04-24 03:44:22,"Lukasz Lenart" wrote:
>>
>> >2013/4/23 ppm10103 :
>>
" sense that should drive
their removal.
Again, my knowledge is pretty dated, but that's where things came from.
Don
On Tue, Apr 23, 2013 at 7:40 PM, ppm10103 wrote:
>
> At 2013-04-24 03:44:22,"Lukasz Lenart" wrote:
>
> >2013/4/23 ppm10103 :
> >> The
At 2013-04-24 03:44:22,"Lukasz Lenart" wrote:
>2013/4/23 ppm10103 :
>> The Dispatcher will have only one instance,
>> it bind to ThreadLocal is for what?
>
>For thread safety, then you can access Dispatcher from a thread
>without synchronisation.
2013/4/23 ppm10103 :
> The Dispatcher will have only one instance,
> it bind to ThreadLocal is for what?
For thread safety, then you can access Dispatcher from a thread
without synchronisation. That's my opinion :-)
Regards
--
Łukasz
+ 48 606 323 122 http://www.le
Woohoo, I get it now... I saw the PrepareOperations before but digging w/o
an IDE is a pain.
Sweet--thanks again.
Dave
On Thu, Jun 21, 2012 at 4:11 PM, Łukasz Lenart wrote:
> 2012/6/21 Dave Newton :
> > Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll
2012/6/21 Dave Newton :
> Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll track
> it down later when I have a chance. Is there an elevator pitch for how the
> ng filter ends up calling it?
Take a look on the finally section of doFilter(),
ltiPartRequest.cleanUp()
>
> It works with old and with the new filters.
>
Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll
track it down later when I have a chance. Is there an elevator pitch for
how the ng filter ends up calling it?
Thanks,
Dave
Hi Dave,
I've changed a bit the whole cleanup idea, right now it's delegated to
given implementation of MultiPartRequest, to the method cleanUp().
So a filter calls Dispatcher.cleanUpRequest(request) which delegate to
MultiPartRequest.cleanUp()
It works with old and with the new filters.
Regard
gt;
>> The patch for WW-3490 [1] moved temp file deletion out of the interceptor
>> into the dispatcher, but if the ng dispatcher is being used, when/how are
>> the files deleted? I've dug a little bit and haven't seen it yet; at this
>> po
Jun 21, 2012 at 6:14 AM, Dave Newton wrote:
> Where are uploaded files currently cleaned up?
>
> The patch for WW-3490 [1] moved temp file deletion out of the interceptor
> into the dispatcher, but if the ng dispatcher is being used, when/how are
> the files deleted? I've dug
Where are uploaded files currently cleaned up?
The patch for WW-3490 [1] moved temp file deletion out of the interceptor
into the dispatcher, but if the ng dispatcher is being used, when/how are
the files deleted? I've dug a little bit and haven't seen it yet; at this
point it's
-main-java-org-apache-struts2-dispatcher-Serva-tp4343285p4343664.html
Sent from the Struts - Dev mailing list archive at Nabble.com.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h
t; Modified:
>
> struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ServletActionRedirectResult.java
>
> struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/ServletRedirectResult.java
>
> Modified:
> struts/strut
Team,
After successfully testing the new org.apache.struts.dispatcher package (by
retrofitting a current application of mine), it is in great shape for
anyone else to try. Here are some highlights:
1) New ExecuteDispatcher command for ComposableRequestProcessor that
delegates to a Dispatcher
le);
> }
> }
>
> if (paramsWorkaroundEnabled) {
> request.getParameter("foo"); // simply read any parameter (existing or not)
> to "prime" the request
> }
> }
> ===
>
> You guys may not think this to be a bug
URL with
different encoding before they send requests to server!!
Would someone take just 5 minutes to see whether the logic in
Dispatcher::prepare() is correct or not.
BTW, Glad to see the 2.1 will soon go to GA and see some great heros save
Convention plugin from dustbin.
reg
You're correct, this is a user-list question.
I'm not sure that you can dispatch to a non-servlet resource.
--- On Sun, 12/14/08, Dirk Forchel wrote:
> From: Dirk Forchel
> Subject: Re: ServletDispatcherResult (dispatcher) and forwarding to Actions
> To: dev@struts.apache
dispatch/forward to the ${referer} defined as "input" result. My
> SearchAction implements the Prepareable interface and set the "referer"
> property in my prepare method:
>
> @Override
> public void prepare() throws Exception {
>referer = request.getHeader(
Path();
}
If a validation error occurs on my welcome page, the dispatcher should go to
the welcome page (referer = http://localhost:9001/welcome.action). If I have
a validation error on the category page, the dispatcher for the input result
should go to http://localhost:9001/category.action. If I
g logic itself -- and I see some truth to
> this. A better solution is to make the Controller handle this
> responsibility outright. Thus, a new "dispatcher" attribute has been
> added to the action mapping. The Controller can now delegate to the
> configured Dispatcher whic
as a flaw -- that an Action
would execute the dispatching logic itself -- and I see some truth to
this. A better solution is to make the Controller handle this
responsibility outright. Thus, a new "dispatcher" attribute has been
added to the action mapping. The Controller can now deleg
ed by server may not be encoded in UTF-8 format.
When this happened, by detecting (charcode > 127) in querystring of request,
I'll
manually set request's contentEncoding property to "GBK".
But Dispatcher simply ignored my effort and reset contentEncoding to "UTF-8",
whi
and enhancement of
Struts itself.
http://struts.apache.org/mail.html
Sanjeev Vijapurapu wrote:
Hi,
I have recently upgraded to struts 2.1.1 and if my struts filter
dispatcher url pattern is not "/*" instead it is "/actions/*,
/struts/*".
And now if I am trying to acces
Hi,
I have recently upgraded to struts 2.1.1 and if my struts filter
dispatcher url pattern is not "/*" instead it is "/actions/*,
/struts/*".
And now if I am trying to access a jsp page that is not under that url
pattern ( something like /test.jsp), struts tags in that jsp p
I've been going through the documentation and the source and trying to
understand the architecture of Struts 2.
In the documentation for the createDispatcher method in
FilterDispatcher, it says
Create a default [EMAIL PROTECTED] Dispatcher} that subclasses can
override
with a custom Dispa
Yeah, we probably should extract an interface out of the Dispatcher
class. For now, you can subclass Dispatcher and point Struts 2 to it by
subclassing the FilterDispatcher and override the createDispatcher method.
Don
Tarek Nabil wrote:
I've been going through the documentation an
+1 Good catch. :)
Don
tm jee wrote:
Hi guys,
Currently, Dispatcher allows ConfigurationManager to be set through a setter
method, however a new ConfigurationManager is being created when Dispatcher
constructor is called, resulting in the the setter method being functionless.
I think we
/java/org/apache/struts2/dispatcher/Dispatcher.java
struts/struts2/trunk/core/src/test/java/org/apache/struts2/config/SettingsTest.java
Modified:
struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
URL:
http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/
t; Author: plightbo
> > Date: Mon Aug 28 15:39:12 2006
> > New Revision: 437868
> >
> > URL:
> http://svn.apache.org/viewvc?rev=437868&view=rev
> > Log:
> > Wendy has a sharp eye
> >
> > Modified:
> >
>
> truts/struts2/trunk/core/src
ied:
struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java
struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher/mapper/DefaultActionMapper.java
Modified:
struts/struts2/trunk/core/src/main/java/org/apache/struts2/StrutsConstants.java
URL:
On 8/28/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
+/** Allows one to disable dynamic method invocation from the URL */
+public static final String STRUTS_DISABLE_DYNAMIC_METHOD_INVOCATIOn =
"struts.core.disableDynamicMethodInvocation";
Capitalization of INVOCATIOn ?
+priv
Author: tmjee
Date: Thu Apr 27 08:47:13 2006
New Revision: 397574
URL: http://svn.apache.org/viewcvs?rev=397574&view=rev
Log:
remove an uneccessary System.out.println statement
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/dispatcher/ma
Author: tmjee
Date: Thu Apr 27 08:43:30 2006
New Revision: 397572
URL: http://svn.apache.org/viewcvs?rev=397572&view=rev
Log:
WW-1278
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/dispatcher/FilterDispatcher.java
Modified:
incubator/webwork2/action/src/
ache/struts/action2/dispatcher/FilterDispatcher.java
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/default.properties
incubator/webwork2/action/src/test/java/org/apache/struts/action2/config/ConfigurationTest.java
Modified:
incubator/webwork2/action/src/main/java
tion
Modified:
incubator/webwork2/action/pom.xml
incubator/webwork2/action/src/main/java/org/apache/struts/action2/StrutsTestCase.java
incubator/webwork2/action/src/test/java/org/apache/struts/action2/dispatcher/DispatcherUtilsTest.java
incubator/webwork2/action/src/test/java/org/ap
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/ComboBoxTest.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/ComboBoxTest.java?rev=394477&r1=394476&r2=394477&view=diff
=
arty/jfreechart/src/main/java/org/apache/struts/action2/dispatcher/ChartResult.java
incubator/webwork2/thirdparty/jfreechart/src/test/java/org/apache/struts/action2/dispatcher/ChartResultTest.java
incubator/webwork2/thirdparty/pell-file-upload/src/main/java/org/apache/struts/action2/dispat
Author: mrdon
Date: Thu Apr 13 11:14:24 2006
New Revision: 393879
URL: http://svn.apache.org/viewcvs?rev=393879&view=rev
Log:
Fixing template for real this time
Modified:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/dispatcher/error.ftl
Modified:
incub
Author: mrdon
Date: Thu Apr 13 11:12:14 2006
New Revision: 393878
URL: http://svn.apache.org/viewcvs?rev=393878&view=rev
Log:
Fixing error template to deal better with non-localized errors
Modified:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/dispatcher/error
ork2/action/src/main/resources/org/apache/struts/action2/dispatcher/error.ftl
incubator/webwork2/build.xml
incubator/webwork2/webapps/showcase/src/main/webapp/WEB-INF/classes/xwork.xml
Modified:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/dispatcher/error.ftl
Author: mrdon
Date: Wed Apr 12 12:09:01 2006
New Revision: 393581
URL: http://svn.apache.org/viewcvs?rev=393581&view=rev
Log:
Fixing problem report to show root exception location information and snippet
Modified:
incubator/webwork2/action/src/main/java/org/apache/struts/action2/dispat
ork2/action/src/main/resources/org/apache/struts/action2/dispatcher/error.ftl
Modified:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/dispatcher/error.ftl
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/action/src/main/resources/org/apache/struts/action2/dispat
er areas, like
validation configuration
can take advantage of this feature. Also fixing QuickStart for new Maven 2
layout.
PR: WW-1282
Added:
incubator/webwork2/action/src/main/resources/org/apache/struts/action2/dispatcher/
incubator/webwork2/action/src/main/resources/org/apache/
Modified:
incubator/webwork2/src/test/org/apache/struts/webwork/views/jsp/ui/TokenTagTest.java
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/src/test/org/apache/struts/webwork/views/jsp/ui/TokenTagTest.java?rev=390860&r1=390850&r2=390860&view=diff
=
/webwork2/src/java/org/apache/struts/action2/interceptor/debugging/webconsole.html
incubator/webwork2/src/java/org/apache/struts/action2/interceptor/debugging/webconsole.js
Modified:
incubator/webwork2/src/java/org/apache/struts/action2/dispatcher/DispatcherUtils.java
incubator/web
Author: mrdon
Date: Sat Apr 1 09:29:20 2006
New Revision: 390701
URL: http://svn.apache.org/viewcvs?rev=390701&view=rev
Log:
Changing static file prefix to /struts
Modified:
incubator/webwork2/src/java/org/apache/struts/action2/dispatcher/FilterDispatcher.java
Modified:
incub
Author: mrdon
Date: Thu Mar 30 11:21:39 2006
New Revision: 390220
URL: http://svn.apache.org/viewcvs?rev=390220&view=rev
Log:
Fixing Spring object factory not loading correctly due to new class name
Modified:
incubator/webwork2/src/java/org/apache/struts/action2/dispat
Modified: incubator/webwork2/src/xdt/tagdoc-toc.xdt
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/src/xdt/tagdoc-toc.xdt?rev=389662&r1=389661&r2=389662&view=diff
==
--- incubator/webwork2/src/xdt/tagdoc-toc.xdt (or
ache/struts/action2/dispatcher/multipart/PellMultiPartRequest.java
Modified:
incubator/webwork2/ivy.xml
Modified: incubator/webwork2/ivy.xml
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/ivy.xml?rev=388696&r1=388695&r2=3886
is under the LGPL license.
Removed:
incubator/webwork2/src/java/org/apache/struts/action2/dispatcher/multipart/PellMultiPartRequest.java
Modified:
incubator/webwork2/ivy.xml
Modified: incubator/webwork2/ivy.xml
URL:
http://svn.apache.org/viewcvs/incubator/webwork2/ivy.xml?rev=388693&
/cos/license.html - unless you happen to _really_
like the book Java Servlet Programming.
Removed:
incubator/webwork2/src/java/org/apache/struts/action2/dispatcher/multipart/CosMultiPartRequest.java
Modified:
incubator/webwork2/ivy.xml
Modified: incubator/webwork2/ivy.xml
URL:
http://svn.apache
Hi Frank,
Thanks for the explanation, I realized shortly afterwards that there
in the web.xml which pertains to the higher level
of the application/servlet... and thus like you siad unless an action
is in the mappings file the RequestProcessor wouldnt know what to do
(unless there is an action wi
If you invoke main.jsp, the RequestProcessor IS NOT invoked. Well, not
unless you've mapped in to .jsp.
Most people tend to map ActionServlet to .do, and I think extension
mapping is probably more prevalent than path mapping. This is done in
web.xml, same as any servlet mapping is. Remember
Hi,
I've been looking at the src of v1.2.7.
I think the real question is, what happens when no action is invoked,
or configured in the struts xml file.
For example, the initial request is to main.jsp which has no
associated mappings in the xml config file, how does the
RequestProcessor (or Reque
Take a look at the RequestProcessor class source (pre-1.3 Struts, I'm
looking at 1.2.4 at the moment). Look for the process() method. This
is, in a high-level way, where most of the work occurs in the request
processing cycle (at least the part that you are likely to be concerned
with). Spec
Hi,
How does Java/Struts determine when/how to render a page fro the
current findForward path ? For some reason I cant seem to determine
how the RequestDispatcher is directly invoking the this target path
without failing in the processMapping method of RequestProcessor ?
For example, in a demo, i
62 matches
Mail list logo
