Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-18 Thread Lukasz Lenart
2017-03-17 20:46 GMT+01:00 Aleksandr Mashchenko : >> That would be awesome but it's hard if there are just few who test the >> latest test build ;-) That being said, I'm going to extend a test >> build period and instead of a week give a month for everyone to test >> it, hope this allow reduce such

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-17 Thread Aleksandr Mashchenko
> That would be awesome but it's hard if there are just few who test the > latest test build ;-) That being said, I'm going to extend a test > build period and instead of a week give a month for everyone to test > it, hope this allow reduce such problems. Month seems like a long leap from the wee

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 Thread Lukasz Lenart
2017-03-16 20:23 GMT+01:00 Aaron Johnson : > Keeping breaking changes in major releases is important. I recently took a > project from 2.5.8 to 2.5.10.1 and had several compilation errors. Not a > good surprise when attempting to get a security fix in quickly. That would be awesome but it's hard i

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 Thread Stefaan Dutry
I agree with respecting major/minor versions concerning breaking changes. I also encountered an unexpected problem with updating one of our projects at work to 2.5.10.1 (from 2.5.1), which didn’t even cause a compilation error. In my case it was because of the introduction of a parameter object.

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 Thread Aaron Johnson
Keeping breaking changes in major releases is important. I recently took a project from 2.5.8 to 2.5.10.1 and had several compilation errors. Not a good surprise when attempting to get a security fix in quickly. On Thu, Mar 16, 2017 at 8:35 AM, Lukasz Lenart wrote: > 2017-03-16 13:21 GMT+01:00 C

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 Thread Lukasz Lenart
2017-03-16 13:21 GMT+01:00 Christoph Nenning : > I'd say it is too big for a minor version update -> let's put it in 2.6 https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%202.6%20AND%20project%20%3D%20WW%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC Regards -- Ł

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 Thread Christoph Nenning
> > I like those ideas! > > > > Currently it is a bit messy to figure out what can be customized or used > > by apps and what are struts internals. Having an explicit API would clear > > things up. > > Yeah, it should be a bit easier. The question is: do it now or wait > till Struts 2.6? > I'

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 Thread Lukasz Lenart
2017-03-16 10:52 GMT+01:00 Christoph Nenning : > I like those ideas! > > Currently it is a bit messy to figure out what can be customized or used > by apps and what are struts internals. Having an explicit API would clear > things up. Yeah, it should be a bit easier. The question is: do it now or

Re: Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-16 Thread Christoph Nenning
> Subject: Injectable LocaleProvider replaces with LocaleProviderFactory > > Hi, > > Another PR cleaning up a mess with injecting things ;) > https://github.com/apache/struts/pull/122 > > and what do you think about adding a dedicated artefact to keep all > those interfaces

Injectable LocaleProvider replaces with LocaleProviderFactory

2017-03-15 Thread Lukasz Lenart
Hi, Another PR cleaning up a mess with injecting things ;) https://github.com/apache/struts/pull/122 and what do you think about adding a dedicated artefact to keep all those interfaces? strust2-api? And move all the APIs there maybe with default implementations. Another thing I would like to st