Feel free, just target 2.5.x branch and then will will cherry-pick
changes into 2.6
czw., 21 sty 2021 o 10:14 Greg Huber napisał(a):
>
> I can do a PR if this would be OK? Seems not to complex.
>
> ie add a log to ExcludedPatternsChecker.isExcluded
>
> ExcludedPatternsChecker
>
> public fi
I can do a PR if this would be OK? Seems not to complex.
ie add a log to ExcludedPatternsChecker.isExcluded
ExcludedPatternsChecker
public final static class IsExcluded {
private final boolean excluded;
private final String excludedPattern;
*private final boolean log;*
Log file after a few saves, picking out "real log entries" is tiresome.
2021-01-21 07:52:50,834 WARN
com.opensymphony.xwork2.interceptor.ParametersInterceptor
ParametersInterceptor:isExcluded - Parameter [struts.token.name] matches
excluded pattern
[(^|\%\{)((#?)(top(\.|\['|\[")|\[\d\]\.)?)(d
Yet I think we should update DefaultExcludedPatternsChecker and
exclude `action:` by default.
I did try that, but ParametersInterceptor then swaps the ParametersInterceptor:isAccepted
to an ParametersInterceptor:isExcluded message🙁. Would need to add an ignored somewhere
or something like add
czw., 21 sty 2021 o 07:44 Greg Huber napisał(a):
> Looking more into it, the DMI stuff with respect to the
> ParametersInterceptor is work in progress, I tried various ways to
> suppress the warnings, but something extra needs to be done, ie the
> parameter 'action:myAction!save' should not reall
Looking more into it, the DMI stuff with respect to the
ParametersInterceptor is work in progress, I tried various ways to
suppress the warnings, but something extra needs to be done, ie the
parameter 'action:myAction!save' should not really be considered a
bean/ognl parameter, more system lev
Hi Greg,
To me it looks like an app config problem because I'm wondering why it
tries to set a value to action name?! i.e. considers the action name an
an http parameter?!
Regards.
On 1/20/2021 12:22 PM, Greg Huber wrote:
> Seems the regex is passing, but fails on :
>
> Error setting expression
Seems the regex is passing, but fails on :
Error setting expression 'action:myAction!save' with value ['Create', ]
- Class: ognl.Ognl
File: Ognl.java
Method: parseExpression
Line: 179 - ognl/Ognl.java:179:-1
##
ognl.ExpressionSyntaxException: Malformed OGNL expression:
action:myAction!save [
Looking into this again, I am getting loads of these warnings in my logs
WARN com.opensymphony.xwork2.interceptor.ParametersInterceptor
ParametersInterceptor:isAccepted - Parameter [action:myAction!save]
didn't match accepted pattern
[[\w+((\.\w+)|(\[\d+])|(\(\d+\))|(\['(\w|[\u4e00-\u9fa5])+'
