The PR is ready for review
https://github.com/apache/struts/pull/252
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev
wt., 25 wrz 2018 o 10:43 napisał(a):
> > I finished implementing new interfaces and just wonder if I should
> > change `ValidationAware` as well - I thought about splitting it into
> > three smaller interfaces that can be used separately -
> > ValidationErrorsAware, ValidationMessagesAware and
> >
śr., 19 wrz 2018 o 13:30 Yasser Zamani napisał(a):
> On 9/19/2018 2:17 PM, Yasser Zamani wrote:
> > Same refactor would be nice for Struts internal CDI by
> > finding all references of @Inject and refactoring them [1]. This changes
> > isn't backward compatible so no need for deprecation I think.
On 9/19/2018 2:17 PM, Yasser Zamani wrote:
> Same refactor would be nice for Struts internal CDI by
> finding all references of @Inject and refactoring them [1]. This changes
> isn't backward compatible so no need for deprecation I think.
FIX: This change (finding all references of @Inject and r
On 9/19/2018 10:53 AM, Lukasz Lenart wrote:
> Cool, first step https://github.com/apache/struts/pull/252 - WIP :)
+1, thanks a lot! Same refactor would be nice for Struts internal CDI by
finding all references of @Inject and refactoring them [1]. This changes
isn't backward compatible so no need
śr., 19 wrz 2018 o 09:03 napisał(a):
>
> Oh yes, that sounds like a great idea!
> I wonder why we didn't come up with this earlier, the simplest ideas are the
> hardest to find ;)
>
> My preference would be the name withSession.
Cool, first step https://github.com/apache/struts/pull/252 - WIP :)
