I have committed my changes to xwork trunk, I will be testing more on
Showcase and trying to write some integration tests as I go. If
anybody else could help testing this, have fun :). If nothing is
broken I will also commit the changes to the xwork branch.
musachy
On Sat, Jul 19, 2008 at 8:50 AM
> I'm not sure how to get permission to make comments in crucible.
I guess we would have to benchmark it, but I don't see anything big
going on, as the objects(like root, context, etc) are just set into
the new stack.
musachy
-
duh..done :)
On Sat, Jul 19, 2008 at 3:44 AM, Don Brown <[EMAIL PROTECTED]> wrote:
> Musachy, you need to mark the box that lets anyone join the review as
> a reviewer. As it is now, no one can comment.
>
> Don
>
> On Sat, Jul 19, 2008 at 12:47 AM, Musachy Barroso <[EMAIL PROTECTED]> wrote:
>> I
Musachy, you need to mark the box that lets anyone join the review as
a reviewer. As it is now, no one can comment.
Don
On Sat, Jul 19, 2008 at 12:47 AM, Musachy Barroso <[EMAIL PROTECTED]> wrote:
> I opened a code review here:
>
> http://fisheye6.atlassian.com/cru/CR-9
>
> I added a new interfa
Musachy Barroso wrote:
I opened a code review here:
http://fisheye6.atlassian.com/cru/CR-9
I added a new interface ClearableValueStack, which if implemented will
make the OGNL parameter binding run in a clean context.
I'm not sure how to get permission to make comments in crucible.
Genera
I opened a code review here:
http://fisheye6.atlassian.com/cru/CR-9
I added a new interface ClearableValueStack, which if implemented will
make the OGNL parameter binding run in a clean context.
musachy
On Thu, Jul 17, 2008 at 5:46 PM, Musachy Barroso <[EMAIL PROTECTED]> wrote:
> I think it wou
I think it would be the same, we would just need to add a method to
ValueStack, to clear the context.
musachy
On Thu, Jul 17, 2008 at 5:32 PM, Chris Pratt <[EMAIL PROTECTED]> wrote:
> Will it be pluggable between the new-and-improved ValueStack and the
> OGNL ValueStack so that we can make the tr
Will it be pluggable between the new-and-improved ValueStack and the
OGNL ValueStack so that we can make the transition as painless as
possible?
(*Chris*)
On Thu, Jul 17, 2008 at 2:28 PM, Musachy Barroso <[EMAIL PROTECTED]> wrote:
> Yeah I am set to fix those security holes ;). Doing the change