Re: [struts-dev] [OT] Re: StrutsStatics...

2008-03-01 Thread Dave Newton
--- Wes Wannemacher <[EMAIL PROTECTED]> wrote: > On Sat, 2008-03-01 at 10:42 -0800, Dave Newton wrote: > > --- Dale Newfield <[EMAIL PROTECTED]> wrote: > > > [...] (and therefore none of us that still use emacs could possibly > > > by good coders) [...] > > Fixed your typo. > Don't forget about tho

Re: [struts-dev] [OT] Re: StrutsStatics...

2008-03-01 Thread Wes Wannemacher
On Sat, 2008-03-01 at 10:42 -0800, Dave Newton wrote: > --- Dale Newfield <[EMAIL PROTECTED]> wrote: > > [...] (and therefore none of us that still use emacs could possibly > > by good coders) [...] > > Fixed your typo. > > Dave > > Don't forget about those of us using ed/cat/butterflies htt

Re: [struts-dev] [OT] Re: StrutsStatics...

2008-03-01 Thread Dave Newton
--- Dale Newfield <[EMAIL PROTECTED]> wrote: > [...] (and therefore none of us that still use emacs could possibly > by good coders) [...] Fixed your typo. Dave - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional command

Re: [struts-dev] [OT] Re: StrutsStatics...

2008-03-01 Thread Dale Newfield
CleverSwine wrote: auto-suggest IDEs... The combination of your assumption that all "good coders" use IDEs (and therefore none of us that still use vi could possibly by good coders), continued posting about the same issue without any additional contributions to the conversation (this would b

Re: [OT] Re: StrutsStatics...

2008-02-29 Thread CleverSwine
-- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- View this message in context: http://www.nabble.com/StrutsStatics...-tp15595866p15767479.html Sent from the Struts - Dev mailing list archive at Nabbl

[OT] C++ interfaces (WAS: Re: StrutsStatics...)

2008-02-29 Thread Antonio Petrelli
2008/2/29, CleverSwine <[EMAIL PROTECTED]>: > > > Antonio Petrelli wrote: > > Err... Does C++ have interfaces at all? All I recall is that C++ has > > classes. > > > Of course it does. A simple google search > (http://www.google.com/search?hl=en&q=C%2B%2B+interfaces&btnG=Google+Search) > would

[OT] Re: StrutsStatics...

2008-02-29 Thread Dave Newton
--- CleverSwine <[EMAIL PROTECTED]> wrote: > Antonio Petrelli wrote: > > Err... Does C++ have interfaces at all? All I recall is that C++ has classes. > > Of course it does. A simple google search > (http://www.google.com/search?hl=en&q=C%2B%2B+interfaces&btnG=Google+Search) > would have shown you

Re: StrutsStatics...

2008-02-29 Thread Chris Pratt
On Fri, Feb 29, 2008 at 8:15 AM, CleverSwine <[EMAIL PROTECTED]> wrote: > > > Chris Pratt wrote: > > I never said it was a good idea, it's just something that was so common > > that > > they decided to make it part of the language. > > This statement demonstrates a fundamental misunderstanding

Re: StrutsStatics...

2008-02-29 Thread CleverSwine
read, I hope he's not a Struts2 committer. Anyone care to shed some light on his involvement with Struts2? Is he a committer? Thanks, Clever Swine -- View this message in context: http://www.nabble.com/StrutsStatics...-tp15595866p15765459.html Sent from the Struts - Dev mailing list archive at Nabbl

Re: StrutsStatics...

2008-02-29 Thread Al Sutton
Sounds like a good reason why it isn't possible :). - Original Message - From: "Antonio Petrelli" <[EMAIL PROTECTED]> To: "Struts Developers List" Sent: Friday, February 29, 2008 4:21 PM Subject: Re: StrutsStatics... 2008/2/29, CleverSwine &l

Re: StrutsStatics...

2008-02-29 Thread Dave Newton
--- CleverSwine <[EMAIL PROTECTED]> wrote: > Chris Pratt wrote: > > I never said it was a good idea, it's just something that was so common > > that they decided to make it part of the language. > This statement demonstrates a fundamental misunderstanding of Java. I > really hope you are NOT a comm

Re: StrutsStatics...

2008-02-29 Thread Antonio Petrelli
2008/2/29, CleverSwine <[EMAIL PROTECTED]>: > > In some OO languages (C++ comes to > mind), the constant interface anti-pattern isn't possible because > constants > cannot be defined on interfaces. Err... Does C++ have interfaces at all? All I recall is that C++ has classes. Antonio

Re: StrutsStatics...

2008-02-29 Thread CleverSwine
attern isn't possible because constants cannot be defined on interfaces. -- View this message in context: http://www.nabble.com/StrutsStatics...-tp15595866p15761878.html Sent from the Struts - Dev mailing list archive at Nabble.com. ---

Re: StrutsStatics...

2008-02-21 Thread Jeromy Evans
Musachy Barroso wrote: I never thought this would generate such a long thread. Yeah we should fix it, but c'on, we have a ton of bugs to fix and new/cool stuff to implement :). musachy Yeah, this thread is a classic case of non-urgent non-important chatter (ref Steven R. Covey's book h

Re: StrutsStatics...

2008-02-21 Thread Brian Pontarelli
Moving to API compat thread. Don Brown wrote: I do agree we need to be much better about how much of our API we expose to developers, but I think the question of public vs private API goes beyond the Java semantics and into what a typical Struts user will encounter. Unless you are a plugin or

Re: StrutsStatics...

2008-02-21 Thread Don Brown
I do agree we need to be much better about how much of our API we expose to developers, but I think the question of public vs private API goes beyond the Java semantics and into what a typical Struts user will encounter. Unless you are a plugin or framework developer, it would be very rare for yo

Re: StrutsStatics...

2008-02-21 Thread Dave Newton
--- Brian Pontarelli <[EMAIL PROTECTED]> wrote: > Don Brown wrote: > > On 2/22/08, Brian Pontarelli <[EMAIL PROTECTED]> wrote: > >> Hehe. The changes from 2.0 to 2.1 are completely incompatible, so this > >> change is minor in comparison. > > I disagree with that statement. For Struts 2 users, t

Re: StrutsStatics...

2008-02-21 Thread Brian Pontarelli
Don Brown wrote: On 2/22/08, Brian Pontarelli <[EMAIL PROTECTED]> wrote: Hehe. The changes from 2.0 to 2.1 are completely incompatible, so this change is minor in comparison. I disagree with that statement. For Struts 2 users, the changes are only minor. I think you feel them more

Re: StrutsStatics...

2008-02-21 Thread Don Brown
On 2/22/08, Brian Pontarelli <[EMAIL PROTECTED]> wrote: > > Hehe. The changes from 2.0 to 2.1 are completely incompatible, so this > change is minor in comparison. I disagree with that statement. For Struts 2 users, the changes are only minor. I think you feel them more because you are working

Re: StrutsStatics...

2008-02-21 Thread Brian Pontarelli
Hehe. The changes from 2.0 to 2.1 are completely incompatible, so this change is minor in comparison. if we were to use the commonly accepted versioning scheme of major vs. minor releases, 2.1.x would eventually become 3.0 when it goes GA. So, I say make all these "break everything" changes n

Re: StrutsStatics...

2008-02-21 Thread Chris Pratt
On Thu, Feb 21, 2008 at 7:34 AM, CleverSwine <[EMAIL PROTECTED]> wrote: > > > Chris Pratt wrote: > > > > I don't know for sure, but that's pretty common practice before Java 5's > > import static. > > > > I disagree. This was in practice in the '90s, although to say it was > "common" is a stretch.

Re: StrutsStatics...

2008-02-21 Thread Dave Newton
--- Musachy Barroso <[EMAIL PROTECTED]> wrote: > I never thought this would generate such a long thread. Me neither :/ Really, I just wanted confirmation that it was a legacy holdover. I vote to deprecate and move the constants into StrutsConstants. Dave --

Re: StrutsStatics...

2008-02-21 Thread Musachy Barroso
> then you should at least deprecate it in 2.1. > > > > +1. But I think that StrutsStatics is only the minor of the problems. > > Antonio > -- "Hey you! Would you help me to carry the stone?" Pink Floyd -

Re: StrutsStatics...

2008-02-21 Thread Blake Byrnes
patible changes. > > > > -1. I think that deprecating that interface (and its members), moving the > constants in the right place, removing StrutsStatics from the "implements" > directive does not harm anyone. > > Antonio >

Re: StrutsStatics...

2008-02-21 Thread Antonio Petrelli
rement, > then you should at least deprecate it in 2.1. +1. But I think that StrutsStatics is only the minor of the problems. Antonio

Re: StrutsStatics...

2008-02-21 Thread Paul Benedict
e it in > > minor point releases. Better wait for the next major point release to > make > > incompatible changes. > > > > -1. I think that deprecating that interface (and its members), moving the > constants in the right place, removing StrutsStatics from the "implements" > directive does not harm anyone. > > Antonio >

Re: StrutsStatics...

2008-02-21 Thread Antonio Petrelli
gt; incompatible changes. -1. I think that deprecating that interface (and its members), moving the constants in the right place, removing StrutsStatics from the "implements" directive does not harm anyone. Antonio

Re: StrutsStatics...

2008-02-21 Thread Antonio Petrelli
2008/2/21, Dave Newton <[EMAIL PROTECTED]>: > > > In the dozens of companies for which I've consulted, I haven't > > seen it done since a client in the educational textbook industry > > in 2001. > > > Just to provide a counter-anecdote, in the dozens of companies for which > I've > consulted I've s

Re: StrutsStatics...

2008-02-21 Thread Paul Benedict
I say fix it in Struts 3.0. Yes, it's a horrible pattern to make a programming shortcut. But it's certainly not acceptable to change it in minor point releases. Better wait for the next major point release to make incompatible changes. Paul On Thu, Feb 21, 2008 at 9:51 AM, Dave Newton <[EMAIL PRO

Re: StrutsStatics...

2008-02-21 Thread Dave Newton
--- CleverSwine <[EMAIL PROTECTED]> wrote: > Chris Pratt wrote: > > I don't know for sure, but that's pretty common practice before Java 5's > > import static. > I disagree. This was in practice in the '90s, although to say it was > "common" is a stretch. Much more common has always been to define

Re: StrutsStatics...

2008-02-21 Thread Dave Newton
--- Adam Hardy <[EMAIL PROTECTED]> wrote: > I think if you look at StrutsStatics it's not really the constant interface > antipattern. > > It has just 6 constants which are the keys to retrieve the HTTP servlet api > objects from whichever maps. That's the con

Re: StrutsStatics...

2008-02-21 Thread CleverSwine
x27;t seen it done since a client in the educational textbook industry in 2001. Adam Hardy wrote: > I think if you look at StrutsStatics it's not really the constant > interface antipattern. > What?! It is *precisely* the constant interface antipattern. The larger problem is why this

Re: StrutsStatics...

2008-02-21 Thread Adam Hardy
Actually I'd go one further and say the constant should be a static on the class to which it has most relevance. Now that reduces typing and improves clarity. Instead of StrutsConstants.RESULT_CONSTANT1; StrutsConstants.ACTION_CONSTANT1; Action.CONSTANT1; I think if you look at StrutsSt

Re: StrutsStatics...

2008-02-20 Thread Al Sutton
, but imho it reduces code clarity. Al. - Original Message - From: "Dave Newton" <[EMAIL PROTECTED]> To: "Struts Developers List" Sent: Wednesday, February 20, 2008 8:01 PM Subject: Re: StrutsStatics... --- Antonio Petrelli <[EMAIL PROTECTED]> w

Re: StrutsStatics...

2008-02-20 Thread Dave Newton
--- Antonio Petrelli <[EMAIL PROTECTED]> wrote: > 2008/2/20, Dave Newton <[EMAIL PROTECTED]>: > > ...why *do* we have StrutsStatics as an interface implemented all over? > > IMHO all those "constants" should be scattered to all the needing > classes, n

Re: StrutsStatics...

2008-02-20 Thread Dave Newton
--- Antonio Petrelli <[EMAIL PROTECTED]> wrote: > 2008/2/20, Dave Newton <[EMAIL PROTECTED]>: > > ...why *do* we have StrutsStatics as an interface implemented all over? > > IMHO all those "constants" should be scattered to all the needing > classes, n

Re: StrutsStatics...

2008-02-20 Thread Antonio Petrelli
2008/2/20, Dave Newton <[EMAIL PROTECTED]>: > ...why *do* we have StrutsStatics as an interface implemented all over? IMHO all those "constants" should be scattered to all the needing classes, not centralized. In my past projects, I often had this sort of "statics"

Re: StrutsStatics...

2008-02-20 Thread Paul Benedict
over from the pre-j5 era. > > > > > > > > > > On Feb 20, 2008 1:42 PM, Dave Newton <[EMAIL PROTECTED]> wrote: > > > ...why *do* we have StrutsStatics as an interface implemented all > over? > > > > > > Dave > > > >

Re: StrutsStatics...

2008-02-20 Thread Musachy Barroso
ECTED]> wrote: > > ...why *do* we have StrutsStatics as an interface implemented all over? > > > > Dave > > > > > > > > - > > To unsubscribe, e-mail: [EMAIL PROTECTED] &

Re: StrutsStatics...

2008-02-20 Thread James Mitchell
implements vs imports vs static imports Probably just left over from the pre-j5 era. On Feb 20, 2008 1:42 PM, Dave Newton <[EMAIL PROTECTED]> wrote: > ...why *do* we have StrutsStatics as an interface implemented all over?

Re: StrutsStatics...

2008-02-20 Thread Chris Pratt
On Feb 20, 2008 10:42 AM, Dave Newton <[EMAIL PROTECTED]> wrote: > ...why *do* we have StrutsStatics as an interface implemented all over? > > I don't know for sure, but that's pretty common practice before Java 5's import static. It allowed any class that "

StrutsStatics...

2008-02-20 Thread Dave Newton
...why *do* we have StrutsStatics as an interface implemented all over? Dave - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]