Re: struts-config extends

2005-02-27 Thread Hubert Rabago
The answer could be simpler than I originally thought, and it revealed itself in the code. Since a custom config object would have to extend the original, say FormBeanConfig, it would be up to the subclass to override the inheritFrom() method which is what actually copies config properties from an

Re: struts-config extends

2005-02-22 Thread Ted Husted
On Tue, 22 Feb 2005 08:10:03 -0800, Don Brown wrote: > I have yet to take a look at the implementation, but regarding > timing, I think it is perfect and am very grateful to you for > taking this on.  If I remember correctly, this is the last major > feature we wanted to put in 1.3.  After this get

Re: struts-config extends

2005-02-22 Thread Hubert Rabago
If we pull off extends for individual config elements, maybe extending a base-config.xml would be as simple as referring to it in each of the modules' in web.xml. - Hubert On Tue, 22 Feb 2005 09:27:27 -0800, Don Brown <[EMAIL PROTECTED]> wrote: > I don't know about extending modules, but it woul

Re: struts-config extends

2005-02-22 Thread Hubert Rabago
Good catch. I inherited the form property config class, but not its properties, and I was thinking that the FormBeanConfig instance would already be using the custom class, if any. Now I'm seeing that's not necessarily the case. When the extensions are being realized, what we'll have on hand is w

Re: struts-config extends

2005-02-22 Thread Don Brown
I don't know about extending modules, but it would be nice to extend other Struts config files. Define a base-config.xml that isn't used directly then inherit it in several modules. Don Niall Pemberton wrote: Thanks for putting the effort into a solution for this Hubert, it will be a good addit

Re: struts-config extends

2005-02-22 Thread Niall Pemberton
Thanks for putting the effort into a solution for this Hubert, it will be a good addition to Struts. I have a couple of comments I'm wondering whether as well as what you suggest we should also inherit the actual FormBeanConfig as well? This would make it far more complex to implement because

Re: struts-config extends

2005-02-22 Thread Hubert Rabago
On Tue, 22 Feb 2005 08:10:03 -0800, Don Brown <[EMAIL PROTECTED]> wrote: > > I have yet to take a look at the implementation, but regarding timing, I > think it is perfect and am very grateful to you for taking this on. If > I remember correctly, this is the last major feature we wanted to put in

Re: struts-config extends

2005-02-22 Thread Don Brown
Hubert Rabago wrote: Well, I extracted the form bean initialization into an initModuleFormBeans(moduleConfig) method which matches other methods like it. Here's a snippet from ActionServlet.init(): initModuleConfigFactory(); // Initialize modules as needed Mod

Re: struts-config extends

2005-02-22 Thread Hubert Rabago
Well, I extracted the form bean initialization into an initModuleFormBeans(moduleConfig) method which matches other methods like it. Here's a snippet from ActionServlet.init(): initModuleConfigFactory(); // Initialize modules as needed ModuleConfig moduleConfi

Re: struts-config extends

2005-02-22 Thread Joe Germuska
At 9:07 AM -0600 2/22/05, Hubert Rabago wrote: I tried this over the weekend, starting with form beans. Here's what my sample app had: Hubert: the description of intent for the XML is right-on. The extension gets realized before the loop which creates and registers the DynaActionFormClass instances

struts-config extends

2005-02-22 Thread Hubert Rabago
I tried this over the weekend, starting with form beans. Here's what my sample app had: The idea is that basicForm will end up with: The following values would be inherited: FormBeanConfig.type ...and for each property: FormPropertyConfig