After some reading & thinking, I have the same doubts - the maven plugin we
need is already there, it's the tobago apt plugin. For the classes, we just
need a simple library module on which core will have a dependency.
Regards,
Rene
> Guys I'm new to maven also, but I don't think we need
> a pl
This is how lazy I'm :) , I'd rather type "struts svn access" in google,
that going to struts and click around:
http://www.google.com/search?hl=en&lr=&safe=off&q=struts+svn+access&btnG=Search
musachy
Ted Husted wrote:
On 11/22/06, Musachy Barroso <[EMAIL PROTECTED]> wrote:
By the way the lin
Let me know if you would like some help.
--
James Mitchell
678.910.8017
On Nov 22, 2006, at 6:12 PM, Rene Gielen wrote:
Ok, I'll give the plugin a try. Moving out the code is no problem
in either case, will be done before release.
Regards,
Rene
This tutorial shows it to be pretty easy
On 11/22/06, Musachy Barroso <[EMAIL PROTECTED]> wrote:
By the way the link to the online svnrepository is broken in this page:
http://struts.apache.org/2.x/struts2-core/source-repository.html
Hmmm, that page is obsolete and shouldn't even be there.
How did you come across it?
-Ted.
---
Guys I'm new to maven also, but I don't think we need a plugin, something
like the dependency between core and api. I will check it out also.
By the way the link to the online svnrepository is broken in this page:
http://struts.apache.org/2.x/struts2-core/source-repository.html
musachy
On 11/2
Ok, I'll give the plugin a try. Moving out the code is no problem in either
case, will be done before release.
Regards,
Rene
> This tutorial shows it to be pretty easy, although I
> haven't done one
> myself:
>
> http://maven.apache.org/plugin-developers/index.html
>
> If you don't have time
This tutorial shows it to be pretty easy, although I haven't done one
myself:
http://maven.apache.org/plugin-developers/index.html
If you don't have time to make it a proper plugin, please at least move
it to be its own artifact under struts/maven so that the code isn't
included in our releas
Don,
I agree. As my m2 skills could be titled basic at most, would you (or someone
else more experienced than me) mind taking the task of creating plugin for the
annotation stuff? I'll continue converting component sources to use annotarions
then.
Regards,
Rene
> I think we should follow the
I think we should follow the general rule, "If in doubt, leave it out".
We can always add it back in if we discover a need sometime in the
future, but if it is now, we'll have to keep it in for all future
versions. I want to keep core as simple as possible, to encourage both
new Struts 2 comm
Don,
good point! This would be much cleaner, yes. Btw, I must admit I still
have to learn about the new possibilities of the modularized build system :)
The question is if we want to push out the whole stuff under
oas2.annotations or just the apt subpackage, which is clearly used only
during
I have everything working fine, but I'm waiting to get home and retest
it on linux before submitting.
musachy
Ted Husted wrote:
Likewise. Either will be fine with me. From the other thread, I think
Rene was going to look at apt again later today.
-Ted.
On 11/20/06, Don Brown <[EMAIL PROTECTE
Rene, is there any reason this code should go into Struts 2 core?
Does it need to referenced at runtime? I thought you were using these
annotations at compile time, which AFAIK, means they won't be included
in the compiled code, so there would be no reason to include the
annotation code in the ja
I committed Musachy's patch with some modifications, so that the annotations
are in place as well as the apt generation code, so we all can give it a
review. Maybe we will have to do some more changes, but it looks quite straight
forward in the first place.
Converting doc-tags to annotations is
That's a good idea, I was using them inside core because it was easier
:). Just change core's pom "includes" to something like:
**/*.java
../maven/plugins/apt/.../*.java
I just tried it and it works ok.
musachy
James Mitchell wrote:
Ya, we should probably move this to /struts/maven
Ya, we should probably move this to /struts/maven/plugins/ or
something similar. Then we can just depend on it during build.
--
James Mitchell
678.910.8017
On Nov 21, 2006, at 6:18 PM, Don Brown wrote:
Rene, is there any reason this code should go into Struts 2 core?
Does it need to ref
That makes sense, but we don't need a maven plugin just for that right?,
just a jar file with those classes will do.
musachy
Don Brown wrote:
Well, you wouldn't want to include the code as if it was part of
core. You'd want to turn it into its own maven plugin, publish it,
then have Struts 2
Well, you wouldn't want to include the code as if it was part of core.
You'd want to turn it into its own maven plugin, publish it, then have
Struts 2 core use the plugin when it generates resources. It should be
possible to just checkout core and build it without external path
dependencies.
Are we finally going to stick to xdoclet or use annotations? I have the
maven-apt plugin almost ready(from tobago project + some fixes) with the
apt stuff, but I don't want to spend more time on it if we are not going to
use it.
regards
musachy
On 11/18/06, Konstantin Priblouda <[EMAIL PROTECT
HI all,
I just created an issue containing patch to pom.xml
to enable tld-generation by xdoclet-2
( WW-1512 )
feel free to ask questions.
regards,
[ Konstantin Pribluda http://www.pribluda.de ]
Still using XDoclet 1.x? XDoclet 2 is released and of production quality.
che
19 matches
Mail list logo
