JCgH4164838Gh792C124B5 opened a new pull request #404:
URL: https://github.com/apache/struts/pull/404
Initial fix for WW-5069:
- Force US Locale for two tests that use date strings of the form MM/DD/CCYY.
- When the tests/build are run in an environment with a non-US Locale and
ne
coveralls commented on issue #404:
URL: https://github.com/apache/struts/pull/404#issuecomment-616270788
[](https://coveralls.io/builds/30183114)
Coverage remained the same at 47.069% when pulling
**6d6a422db7950634ae
JCgH4164838Gh792C124B5 commented on issue #404:
URL: https://github.com/apache/struts/pull/404#issuecomment-616271172
Hello Apache Struts Team.
This is a very basic PR (it was just a bit-of-a-pain to isolate the issue).
Basically, the default locale behaviour for some date vali
lukaszlenart commented on issue #404:
URL: https://github.com/apache/struts/pull/404#issuecomment-616317694
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lukaszlenart commented on issue #402:
URL: https://github.com/apache/struts/pull/402#issuecomment-616324497
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
davelnewton opened a new pull request #145:
URL: https://github.com/apache/struts-site/pull/145
May also want a directory change to better reflect common JSP usage (and
that it cannot be on classpath).
This is an automated m
lukaszlenart commented on issue #145:
URL: https://github.com/apache/struts-site/pull/145#issuecomment-616719802
Hm... Jenkins triggering stopped working :\
This is an automated message from the Apache Git Service.
To respond
lukaszlenart commented on issue #145:
URL: https://github.com/apache/struts-site/pull/145#issuecomment-616720493
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
lukaszlenart commented on issue #400:
URL: https://github.com/apache/struts/pull/400#issuecomment-616730002
Right, this should express its external effect
```
struts.matcher.appendNamedParameters=true
```
If not objections I'm going to merge this PR and add the flag.
--
atkaiser commented on issue #400:
URL: https://github.com/apache/struts/pull/400#issuecomment-616904644
Sounds good to me
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
lukaszlenart commented on issue #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-617345083
I think this PR is finally ready. I know it's huge so if there are
objections merging it AS-IS I can prepare another PR and just move
`ActionContext`s changes and then update the res
lukaszlenart commented on issue #229:
URL: https://github.com/apache/struts/pull/229#issuecomment-617350536
I assume we are good to merge this PR if no objections, from my side LGTM 👍
This is an automated message from the Ap
coveralls edited a comment on issue #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-602049491
[](https://coveralls.io/builds/30235237)
Coverage increased (+0.03%) to 49.212% when pulling
**f071c9d0ed
lukaszlenart commented on issue #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-617547853
Here are the
[ActionContext](https://github.com/apache/struts/pull/397/files#diff-8bd10f8c78a248734b503714a44e1dcc)
changes I'm talking about. All the rest is a consequence of those
lukaszlenart commented on issue #400:
URL: https://github.com/apache/struts/pull/400#issuecomment-617550492
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lukaszlenart opened a new pull request #405:
URL: https://github.com/apache/struts/pull/405
Follow up on https://github.com/apache/struts/pull/400
Refs [WW-5065](https://issues.apache.org/jira/browse/WW-5065)
This is an au
lukaszlenart commented on issue #400:
URL: https://github.com/apache/struts/pull/400#issuecomment-617569364
@atkaiser @JCgH4164838Gh792C124B5 PR is ready
https://github.com/apache/struts/pull/405
This is an automated message
coveralls commented on issue #405:
URL: https://github.com/apache/struts/pull/405#issuecomment-617625161
[](https://coveralls.io/builds/30251043)
Coverage increased (+0.02%) to 47.086% when pulling
**c2765e5236dd99765
atkaiser commented on issue #405:
URL: https://github.com/apache/struts/pull/405#issuecomment-618022537
LGTM 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
coveralls edited a comment on issue #405:
URL: https://github.com/apache/struts/pull/405#issuecomment-617625161
[](https://coveralls.io/builds/30277905)
Coverage increased (+0.02%) to 47.086% when pulling
**30b43044a3
JCgH4164838Gh792C124B5 commented on a change in pull request #397:
URL: https://github.com/apache/struts/pull/397#discussion_r414173368
##
File path: core/src/main/java/com/opensymphony/xwork2/util/ValueStack.java
##
@@ -28,23 +30,25 @@
*/
public interface ValueStack {
-
JCgH4164838Gh792C124B5 commented on a change in pull request #405:
URL: https://github.com/apache/struts/pull/405#discussion_r414181934
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##
@@ -36,6 +36,9 @@
* @since 2.1
*/
public ab
JCgH4164838Gh792C124B5 commented on a change in pull request #405:
URL: https://github.com/apache/struts/pull/405#discussion_r414185407
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##
@@ -50,10 +53,23 @@
* The compiled patter
JCgH4164838Gh792C124B5 commented on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-618723503
Hi. I will try to go over the new changes in a few days. Thanks for all
the work on this. 👍
Thi
lukaszlenart commented on a change in pull request #405:
URL: https://github.com/apache/struts/pull/405#discussion_r414359429
##
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##
@@ -50,10 +53,23 @@
* The compiled patterns and the
lukaszlenart commented on a change in pull request #405:
URL: https://github.com/apache/struts/pull/405#discussion_r414359578
##
File path: core/src/main/java/org/apache/struts2/StrutsConstants.java
##
@@ -341,4 +341,7 @@
public static final String STRUTS_DISALLOW_PROXY_ME
coveralls edited a comment on pull request #405:
URL: https://github.com/apache/struts/pull/405#issuecomment-617625161
[](https://coveralls.io/builds/30308885)
Coverage increased (+0.01%) to 47.084% when pulling
**6e1
lukaszlenart opened a new pull request #406:
URL: https://github.com/apache/struts/pull/406
Resolves [WW-5070](https://issues.apache.org/jira/browse/WW-5070)
This is an automated message from the Apache Git Service.
To respon
lukaszlenart opened a new pull request #407:
URL: https://github.com/apache/struts/pull/407
Resolves [WW-5017](https://issues.apache.org/jira/browse/WW-5017)
This is an automated message from the Apache Git Service.
To respon
lukaszlenart opened a new pull request #408:
URL: https://github.com/apache/struts/pull/408
Resolves [WW-4043](https://issues.apache.org/jira/browse/WW-4043)
This is an automated message from the Apache Git Service.
To respon
JCgH4164838Gh792C124B5 opened a new pull request #409:
URL: https://github.com/apache/struts/pull/409
Cherry-Pick PR#404 change into master.
Merge pull request #404 from JCgH4164838Gh792C124B5/WW-5069
Initial fix for WW-5069 (improve build behaviour JDK9+)
(cherry picked fro
lukaszlenart opened a new pull request #410:
URL: https://github.com/apache/struts/pull/410
Refs https://github.com/apache/struts/pull/405
Refs [WW-5065](https://issues.apache.org/jira/browse/WW-5065)
This is an automated
JCgH4164838Gh792C124B5 opened a new pull request #411:
URL: https://github.com/apache/struts/pull/411
Minor change to fix WW-5072 (single file upload failure):
- Add action-local method to get upload file size.
- Change file upload validation to use new method.
--
JCgH4164838Gh792C124B5 opened a new pull request #412:
URL: https://github.com/apache/struts/pull/412
Cherry-Pick PR#411 change into master.
Merge pull request #411 from JCgH4164838Gh792C124B5/WW-5072_fix
Minor change to fix WW-5072
(cherry picked from commit e46e662a7ac7fde
JCgH4164838Gh792C124B5 opened a new pull request #413:
URL: https://github.com/apache/struts/pull/413
Proposed WW-5074 Fix:
- Exclude ASM 3.3.1 from inclusion as a dependency for commons-digester3
(also mark commons-digester3 as optional dependency since it is only listed to
allow the e
JCgH4164838Gh792C124B5 opened a new pull request #5:
URL: https://github.com/apache/struts-archetypes/pull/5
Minor changes:
- Make all archetype-descriptor "name" attributes match the archetype they
belong to.
- Make all maven-compiler-plugin versions 3.6.2.
JCgH4164838Gh792C124B5 commented on pull request #5:
URL: https://github.com/apache/struts-archetypes/pull/5#issuecomment-626393098
Hello @lukaszlenart .
I'm not familiar enough with Maven Archetypes to be certain, but I think the
archetype-descriptor entries are intended to match th
lukaszlenart opened a new pull request #414:
URL: https://github.com/apache/struts/pull/414
Two small changes to address problems discovered during testing Struts 2.6
with AppEngine
This is an automated message from the Apac
JCgH4164838Gh792C124B5 opened a new pull request #415:
URL: https://github.com/apache/struts/pull/415
Minor post WW-5030 Cleanup:
- Correction/fix for test within testMockPortletSession(), following recent
changes to 2.6.x.
- Fix TestMockMultipartFile.isEmpty() bug in both original lo
JCgH4164838Gh792C124B5 opened a new pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6
Minor archetype fixes:
- Allow the unit tests for projects built from the Angular and Convention
archetypes to run under JDK 11 (issue not seen with JDK8).
- Fix broken unit te
JCgH4164838Gh792C124B5 commented on pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6#issuecomment-629711361
Hello Apache Struts Team.
This PR should fix a few minor issues with the unit tests failing in a few
of the projects generated from the struts2-archetyp
JCgH4164838Gh792C124B5 opened a new pull request #416:
URL: https://github.com/apache/struts/pull/416
Partial backport of L. Lenart's PR#414 to 2.5.x:
- Improve `Dispatcher` `getLocale()` handling if running in AppEngine.
- Implemented the same improvement to the `defaultLocale` logic
lukaszlenart merged pull request #6:
URL: https://github.com/apache/struts-archetypes/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lukaszlenart merged pull request #415:
URL: https://github.com/apache/struts/pull/415
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart merged pull request #416:
URL: https://github.com/apache/struts/pull/416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
JCgH4164838Gh792C124B5 opened a new pull request #417:
URL: https://github.com/apache/struts/pull/417
Provide unit test for partial backport PR#416 for 2.5.x (from L. Lenart's
PR#414) :
- DispatcherTest provides code coverage tests of all getLocale() paths.
lukaszlenart merged pull request #417:
URL: https://github.com/apache/struts/pull/417
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
JCgH4164838Gh792C124B5 opened a new pull request #418:
URL: https://github.com/apache/struts/pull/418
Straightforward cherry-pick of PR #416 and PR #417 into 2.6.x.
The 1st cherry-pick required a manual merge-conflict resolution, the 2nd was
clean.
-
lukaszlenart merged pull request #418:
URL: https://github.com/apache/struts/pull/418
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart opened a new pull request #419:
URL: https://github.com/apache/struts/pull/419
Refs [WW-5077](https://issues.apache.org/jira/browse/WW-5077)
This is an automated message from the Apache Git Service.
To respond to
lukaszlenart merged pull request #419:
URL: https://github.com/apache/struts/pull/419
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart opened a new pull request #420:
URL: https://github.com/apache/struts/pull/420
Refs [WW-5077](https://issues.apache.org/jira/browse/WW-5077)
This is an automated message from the Apache Git Service.
To respond to
lukaszlenart opened a new pull request #146:
URL: https://github.com/apache/struts-site/pull/146
Refs [S2-018](https://cwiki.apache.org/confluence/display/WW/S2-018)
This is an automated message from the Apache Git Service.
T
allc opened a new pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7
Fix class name in `struts.xml` for archetype starter
This is an automated message from the Apache Git Service.
To respond to the messa
lukaszlenart commented on a change in pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7#discussion_r433643296
##
File path:
struts2-archetype-starter/src/main/resources/archetype-resources/src/main/resources/struts.xml
##
@@ -16,7 +16,7 @@
/
lukaszlenart merged pull request #146:
URL: https://github.com/apache/struts-site/pull/146
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
allc commented on a change in pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7#discussion_r434354664
##
File path:
struts2-archetype-starter/src/main/resources/archetype-resources/src/main/resources/struts.xml
##
@@ -16,7 +16,7 @@
/WEB-INF/
lukaszlenart commented on a change in pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7#discussion_r434359012
##
File path:
struts2-archetype-starter/src/main/resources/archetype-resources/src/main/resources/struts.xml
##
@@ -16,7 +16,7 @@
/
lukaszlenart closed pull request #7:
URL: https://github.com/apache/struts-archetypes/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lukaszlenart merged pull request #420:
URL: https://github.com/apache/struts/pull/420
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart opened a new pull request #422:
URL: https://github.com/apache/struts/pull/422
Implements [WW-5080](https://issues.apache.org/jira/browse/WW-5080)
This is an automated message from the Apache Git Service.
To resp
lukaszlenart opened a new pull request #423:
URL: https://github.com/apache/struts/pull/423
Fixes [WW-5081](https://issues.apache.org/jira/browse/WW-5081)
This is an automated message from the Apache Git Service.
To respond t
yasserzamani merged pull request #423:
URL: https://github.com/apache/struts/pull/423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart opened a new pull request #147:
URL: https://github.com/apache/struts-site/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
yasserzamani merged pull request #422:
URL: https://github.com/apache/struts/pull/422
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
gchatz22 opened a new pull request #424:
URL: https://github.com/apache/struts/pull/424
Initial implementation for Fetch Metadata creating a default resource
isolation policy and a CSRF prevention interceptor
This is an auto
gchatz22 closed pull request #424:
URL: https://github.com/apache/struts/pull/424
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
lukaszlenart opened a new pull request #425:
URL: https://github.com/apache/struts/pull/425
Refs [WW-5077](https://issues.apache.org/jira/browse/WW-5077)
This is an automated message from the Apache Git Service.
To respond to
salcho opened a new pull request #426:
URL: https://github.com/apache/struts/pull/426
Hello Struts devs,
This PR builds Fetch Metadata support on for Struts2, namely:
- If a request has `Sec-Fetch-*` headers (i.e. comes from a modern browser),
the Fetch Metadata Interceptor wi
yasserzamani merged pull request #425:
URL: https://github.com/apache/struts/pull/425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart merged pull request #426:
URL: https://github.com/apache/struts/pull/426
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
JCgH4164838Gh792C124B5 opened a new pull request #427:
URL: https://github.com/apache/struts/pull/427
Initial attempt to fix OSGi Plugin issues discovered during examination of
WW-5075.
- Indication is that the OSGi Plugin has been failing since Struts 2.3.4.
- Applied fix to Resource
JCgH4164838Gh792C124B5 commented on a change in pull request #147:
URL: https://github.com/apache/struts-site/pull/147#discussion_r460444852
##
File path: source/contributors/building-with-maven.md
##
@@ -0,0 +1,206 @@
+---
+layout: default
+title: Building with Maven
+parent:
JCgH4164838Gh792C124B5 commented on a change in pull request #147:
URL: https://github.com/apache/struts-site/pull/147#discussion_r460445631
##
File path: source/contributors/building-with-maven.md
##
@@ -0,0 +1,206 @@
+---
+layout: default
+title: Building with Maven
+parent:
JCgH4164838Gh792C124B5 opened a new pull request #428:
URL: https://github.com/apache/struts/pull/428
WW-5083 PR#426 follow-up.
- Updated ResourceIsolationPolicy Sec-Fetch* header cases to match spec.
- Added the Sec-Fetch-User header, plus additional dest/site/mode values
from the s
salcho opened a new pull request #429:
URL: https://github.com/apache/struts/pull/429
Hello Struts Devs!
This PR adds Content Security Policy support for Struts 2. A very popular
security mitigation against XSS and other injection vulnerabilities. CSP comes
in many flavours, but we'
salcho opened a new pull request #430:
URL: https://github.com/apache/struts/pull/430
Hello Struts Devs!
This PR adds Content Security Policy support for Struts 2. A very popular
security mitigation against XSS and other injection vulnerabilities. CSP comes
in many flavours, but we'
salcho closed pull request #429:
URL: https://github.com/apache/struts/pull/429
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
yasserzamani merged pull request #427:
URL: https://github.com/apache/struts/pull/427
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart commented on pull request #147:
URL: https://github.com/apache/struts-site/pull/147#issuecomment-664589839
Sorry, this is still work-in-progress and I just opened the PR to test
migration to new CI server :)
Thi
gchatz22 opened a new pull request #431:
URL: https://github.com/apache/struts/pull/431
Initial implementation of COOP with coop interceptor and configuration
This is an automated message from the Apache Git Service.
To respo
gchatz22 closed pull request #431:
URL: https://github.com/apache/struts/pull/431
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
gchatz22 opened a new pull request #432:
URL: https://github.com/apache/struts/pull/432
Hello Struts Devs!
This PR adds Cross-Origin Opener Policy (COOP) and Cross-Origin Embedder
Policy (COEP) support for Struts2. Two very popular mitigations that aim to
make a website cross-origin
rgielen opened a new pull request #148:
URL: https://github.com/apache/struts-site/pull/148
The PR adds a new announcement to the Struts site
This is an automated message from the Apache Git Service.
To respond to the message
rgielen merged pull request #148:
URL: https://github.com/apache/struts-site/pull/148
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
lukaszlenart closed pull request #147:
URL: https://github.com/apache/struts-site/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lukaszlenart closed pull request #147:
URL: https://github.com/apache/struts-site/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yasserzamani merged pull request #428:
URL: https://github.com/apache/struts/pull/428
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
yasserzamani commented on pull request #147:
URL: https://github.com/apache/struts-site/pull/147#issuecomment-674374091
LGTM :+1: thanks!
This is an automated message from the Apache Git Service.
To respond to the message, pl
lukaszlenart merged pull request #432:
URL: https://github.com/apache/struts/pull/432
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
JCgH4164838Gh792C124B5 opened a new pull request #433:
URL: https://github.com/apache/struts/pull/433
Initial attempt to fix OSGi Plugin issues discovered during examination of
WW-5075.
- Draws on PR#427 and utilizes similar code, but updated for JDK8.
- Updated OSGi plugin dependenci
lukaszlenart closed pull request #147:
URL: https://github.com/apache/struts-site/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lukaszlenart merged pull request #433:
URL: https://github.com/apache/struts/pull/433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
salcho opened a new pull request #149:
URL: https://github.com/apache/struts-site/pull/149
Hello Struts devs!
We're really proud to have contributed to Struts by adding Fetch Metadata
(https://github.com/apache/struts/pull/426) and COOP/COEP support
(https://github.com/apache/struts
yasserzamani commented on a change in pull request #149:
URL: https://github.com/apache/struts-site/pull/149#discussion_r479367165
##
File path: source/core-developers/coep-interceptor.md
##
@@ -0,0 +1,43 @@
+---
+layout: default
+title: COEP Interceptor
+parent:
+title: In
gchatz22 commented on pull request #149:
URL: https://github.com/apache/struts-site/pull/149#issuecomment-682771689
Thank you for your comments @yasserzamani ! Applied your changes and as said
will also be waiting for @apache/struts-committers opinion.
gchatz22 edited a comment on pull request #149:
URL: https://github.com/apache/struts-site/pull/149#issuecomment-682771689
Thank you for your comments @yasserzamani ! Applied your changes and as said
will also be waiting for
@[apache/struts-committers](https://github.com/orgs/apache/teams/
gchatz22 edited a comment on pull request #149:
URL: https://github.com/apache/struts-site/pull/149#issuecomment-682771689
Thank you for your comments @yasserzamani ! Applied your changes and as said
will also be waiting for @apache/struts-committers opinion.
-
gchatz22 edited a comment on pull request #149:
URL: https://github.com/apache/struts-site/pull/149#issuecomment-682771689
Thank you for your comments @yasserzamani ! Applied your changes and as said
will also be waiting for @apache/struts-committers opinion
--
aleksandr-m merged pull request #430:
URL: https://github.com/apache/struts/pull/430
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
1 - 100 of 1086 matches
Mail list logo
