Re: I believe I have found a bug with 'svn mv' + ACL-protected files.

2010-05-04 Thread Stephen Butler
On May 4, 2010, at 8:39 , Karl Fogel wrote: > Mark Slade writes: >> Per your Issue Tracker Guidelines, I am seeking somebody who agrees >> that this is a bug before I submit it. >> >> Overview: For files, 'svn mv' does not properly inherit ACL >> permissions from the parent directory. >> >> St

Paths in the client patch code

2010-05-04 Thread Hyrum K. Wright
I see a lot of paths in the client patch code, but few of the variable names are explicit about whether the path is absolute or relative. Can somebody who knows the code comment on what types of paths it uses? If we do know, we should probably rename the various patch variables as foo_abspath or

Re: Paths in the client patch code

2010-05-04 Thread Stefan Sperling
On Tue, May 04, 2010 at 10:54:51AM +0200, Hyrum K. Wright wrote: > I see a lot of paths in the client patch code, but few of the variable names > are explicit about whether the path is absolute or relative. Can somebody > who knows the code comment on what types of paths it uses? If we do know, >

Re: Paths in the client patch code

2010-05-04 Thread Hyrum K. Wright
On Tue, May 4, 2010 at 11:13 AM, Stefan Sperling wrote: > On Tue, May 04, 2010 at 10:54:51AM +0200, Hyrum K. Wright wrote: > > I see a lot of paths in the client patch code, but few of the variable > names > > are explicit about whether the path is absolute or relative. Can > somebody > > who kn

Re: patch API review

2010-05-04 Thread Hyrum K. Wright
On Wed, Apr 28, 2010 at 9:20 PM, Hyrum K. Wright < hyrum_wri...@mail.utexas.edu> wrote: > > > On Wed, Apr 28, 2010 at 1:43 PM, Stefan Sperling wrote: > >> ... >> > > Also, I know that the API uses >> > notifications, but it might also be useful to return the _tempfile >> > parameters through a ca

Re: Paths in the client patch code

2010-05-04 Thread Stefan Sperling
On Tue, May 04, 2010 at 11:30:07AM +0200, Hyrum K. Wright wrote: > On Tue, May 4, 2010 at 11:13 AM, Stefan Sperling wrote: > > > On Tue, May 04, 2010 at 10:54:51AM +0200, Hyrum K. Wright wrote: > > > I see a lot of paths in the client patch code, but few of the variable > > names > > > are explic

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Julian Foad
On Tue, 2010-05-04, hwri...@apache.org wrote: > Author: hwright > Date: Tue May 4 09:45:43 2010 > New Revision: 940786 > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > Log: > Add a callback to the public patch API, to allow consumers to collect > information about the patch targets. T

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Stefan Sperling
On Tue, May 04, 2010 at 09:45:44AM -, hwri...@apache.org wrote: > Author: hwright > Date: Tue May 4 09:45:43 2010 > New Revision: 940786 > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > Log: > Add a callback to the public patch API, to allow consumers to collect > information about

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Stefan Sperling
On Tue, May 04, 2010 at 11:36:49AM +0100, Julian Foad wrote: > Wasn't the idea that the caller could choose whether the patched result > should be written straight to the target file or to somewhere else? No, that wasn't the idea. The patched result is *always* written to tempfiles first. Always

[ANN] SVNKit 1.3.3 is available.

2010-05-04 Thread Alexander Kitaev
Hello All, We are glad to announce that SVNKit 1.3.3 has been published and available for download at http://svnkit.com/ web site. SVNKit is a pure Java Subversion library. SVNKit provides Java APIs to access and manipulate Subversion working copies and Subversion repositories. You may find more

Re: [Sketch] Don't checksum reliable transmissions

2010-05-04 Thread Branko Čibej
On 03.05.2010 23:05, Stefan Fuhrmann wrote: > Blair Zajac wrote: >> On 5/2/10 8:56 AM, Philipp Marek wrote: >>> Hello Stefan! >>> The idea is the following: ra_local (and possibly others) are "reliable" in that they won't corrupt transmission. For now, this implies that we don't need

Re: [PATCH] sasl service name for svnserve

2010-05-04 Thread 'Stefan Sperling'
On Tue, Apr 13, 2010 at 10:33:47AM +0600, Катаргин Алексей wrote: > -Original Message- > From: 'Stefan Sperling' [mailto:s...@elego.de] > Sent: Monday, April 12, 2010 10:05 PM > To: Катаргин Алексей > Cc: dev@subversion.apache.org; n...@chelcom.ru > Subject: Re: [PATCH] sasl service name f

Re: svnserve and sasl cross-realm (was: svnserve and ldap status ?)

2010-05-04 Thread Stefan Sperling
On Tue, Mar 23, 2010 at 10:16:25PM +0100, Stefan Sperling wrote: > On Tue, Mar 23, 2010 at 03:58:50PM -0500, Alec Kloss wrote: > > Now please see attached. > > Thanks. I'll try to look at this soon. > > I've also downloaded a couple of related RFCs (e.g. RFC4422) for reference, > as well as cyrus

Re: svnserve and sasl cross-realm (was: svnserve and ldap status ?)

2010-05-04 Thread Alec Kloss
On 2010-05-04 16:22, Stefan Sperling wrote: > On Tue, Mar 23, 2010 at 10:16:25PM +0100, Stefan Sperling wrote: > > On Tue, Mar 23, 2010 at 03:58:50PM -0500, Alec Kloss wrote: > > > Now please see attached. > > > > Thanks. I'll try to look at this soon. > > > > I've also downloaded a couple of rel

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Hyrum K. Wright
On Tue, May 4, 2010 at 12:45 PM, Stefan Sperling wrote: > On Tue, May 04, 2010 at 09:45:44AM -, hwri...@apache.org wrote: > > Author: hwright > > Date: Tue May 4 09:45:43 2010 > > New Revision: 940786 > > > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > > Log: > > Add a callback t

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Julian Foad
On Tue, 2010-05-04 at 17:55 +0200, Hyrum K. Wright wrote: > On Tue, May 4, 2010 at 12:45 PM, Stefan Sperling wrote: > > > On Tue, May 04, 2010 at 09:45:44AM -, hwri...@apache.org wrote: > > > Author: hwright > > > Date: Tue May 4 09:45:43 2010 > > > New Revision: 940786 > > > > > > URL: http

Re: svn commit: r940898 - in /subversion/trunk/subversion: libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c libsvn_wc/wc_db.h tests/libsvn_wc/pristine-store-test.c

2010-05-04 Thread Greg Stein
On Tue, May 4, 2010 at 11:14, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Tue May  4 15:14:13 2010 > @@ -2560,6 +2560,75 @@ svn_wc__db_pristine_install(svn_wc__db_t > > >  svn_error_t * > +svn_wc__db_pristine_remove(svn_wc__db_t *db, > +                           const char *w

Re: svn commit: r940651 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_wc/status.c libsvn_wc/util.c

2010-05-04 Thread Daniel Näslund
On Mon, May 03, 2010 at 08:41:14PM -0400, Greg Stein wrote: > On Mon, May 3, 2010 at 18:01, wrote: > >... > > +++ subversion/trunk/subversion/libsvn_wc/util.c Mon May  3 22:01:53 2010 > >... > > @@ -565,6 +567,12 @@ svn_wc__status2_from_3(svn_wc_status2_t > >   SVN_ERR(svn_wc__get_entry(&entry, w

Re: patch API review

2010-05-04 Thread Stefan Küng
On 04.05.2010 11:46, Hyrum K. Wright wrote: On Wed, Apr 28, 2010 at 9:20 PM, Hyrum K. Wright< hyrum_wri...@mail.utexas.edu> wrote: On Wed, Apr 28, 2010 at 1:43 PM, Stefan Sperling wrote: ... Also, I know that the API uses notifications, but it might also be useful to return the _tempfil

Re: Some failing tests

2010-05-04 Thread Johan Corveleyn
Anyone? A simple answer like "this is obvious problem A, just search the list archives" or "it's not an obvious problem, you need to do some more digging" would already be quite helpful... Should this be relevant: this is a debug build (on Windows). Some dependencies: - APR 1.3.8 - Neon 0.28.6 (I

Re: Some failing tests

2010-05-04 Thread Daniel Shahaf
I saw it but kept silent because I had little to contribute. (I'm not sure what's going on here, never saw a combination of failures resembling it.) Some more comments below. Johan Corveleyn wrote on Tue, 4 May 2010 at 22:29 +0200: > Anyone? > > A simple answer like "this is obvious problem A

Re: Some failing tests

2010-05-04 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, 4 May 2010 at 23:43 +0300: > Johan Corveleyn wrote on Tue, 4 May 2010 at 22:29 +0200: > > > The failing tests are: > > > FAIL:  dirent_uri-test.exe 37: test svn_dirent_condense_targets > > > FAIL:  depth_tests.py 5: update depth-immediates wc gets top file mod only > > >

Re: svn commit: r940786 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/patch.c svn/patch-cmd.c tests/libsvn_client/client-test.c

2010-05-04 Thread Hyrum K. Wright
On Tue, May 4, 2010 at 12:36 PM, Julian Foad wrote: > On Tue, 2010-05-04, hwri...@apache.org wrote: > > Author: hwright > > Date: Tue May 4 09:45:43 2010 > > New Revision: 940786 > > > > URL: http://svn.apache.org/viewvc?rev=940786&view=rev > > Log: > > Add a callback to the public patch API, to

Re: Some failing tests

2010-05-04 Thread Johan Corveleyn
On Tue, May 4, 2010 at 10:49 PM, Daniel Shahaf wrote: > Daniel Shahaf wrote on Tue, 4 May 2010 at 23:43 +0300: >> Johan Corveleyn wrote on Tue, 4 May 2010 at 22:29 +0200: >> > > The failing tests are: >> > > FAIL:  dirent_uri-test.exe 37: test svn_dirent_condense_targets >> > > FAIL:  depth_tests.

Bug in dirent_uri-test 37 (was: Re: Some failing tests)

2010-05-04 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, 5 May 2010 at 00:15 +0200: > AFAIK, there's nothing special concerning I/O on my machine. I don't > have a D drive (should I have one for these tests? I'll look a bit at > what that test really does). I get the same error as you when I use Z: instead of D: (I have a D

Re: Some failing tests

2010-05-04 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, 5 May 2010 at 00:15 +0200: > I have 2,7 Gb of free disk space on C:. Not a lot, I know, but > I thought it should be plenty to run these tests. With --cleanup, you can get away with 50MB or so. (I used to use a 50MB ramdisk.) Without --cleanup, you'll need a coupl