How does the workqueues provide atomic updates, or do they?

2010-06-24 Thread Daniel Näslund
Hi! Some questions about how the workqueues... work. Have I got it right? How are files installed during an update? We acquire a write lock We crawl the wc We tell the repos about our state The repo runs an editor open_root(): We set status to

Re: How does the workqueues provide atomic updates, or do they?

2010-06-24 Thread Philip Martin
Daniel Näslund dan...@longitudo.com writes: How are files installed during an update? We acquire a write lock We crawl the wc We tell the repos about our state The repo runs an editor open_root(): We set status to _status_incomplete

[WIP] #1957 'svn switch does not update keywords'

2010-06-24 Thread Daniel Näslund
Hi! Is 'svn switch does not update keywords' a problem that needs solving? Is the performance of this solution acceptable (traverse the entire wc one more time after the editor drive)? Alternatives? * Custom db-query that only returns the paths with matching property set on them. Could be

Re: How does the workqueues provide atomic updates, or do they?

2010-06-24 Thread Daniel Näslund
On Thu, Jun 24, 2010 at 09:20:22AM +0100, Philip Martin wrote: Daniel Näslund dan...@longitudo.com writes: How are files installed during an update? We acquire a write lock We crawl the wc We tell the repos about our state The repo runs an

dangerous implementation of rep-sharing cache for fsfs

2010-06-24 Thread michael . felke
Excuse me, but i original wrote the following E-Mail to Hyrum K. Wright directly, because I wasn't used to the guidelines of the subversion project. - Weitergeleitet von Michael Felke/AN/Stockhausen/DE am 24.06.2010 11:09 - Michael Felke 23.06.2010 14:07 An:

Re: Ruby bindings don't work with 1.9 + patch

2010-06-24 Thread Hyrum K. Wright
Applied in r957507. I noticed the patch was against 1.6.12, but it applied cleanly to trunk. In the future, please make patches against trunk (and hopefully include a log message). Should this be backported to the 1.6.x branch? Cheers, -Hyrum On Wed, Jun 23, 2010 at 6:52 PM, Joe Rozner

Re: [PATCH] Let svn blame truncate long author names to keep the column width fixed to 10 characters

2010-06-24 Thread Johan Corveleyn
Ping. This patch hasn't gotten feedback nor commits ... Johan On Fri, Jun 18, 2010 at 10:22 PM, Johan Corveleyn jcor...@gmail.com wrote: Hi devs, Here is another (trivial) patch for svn blame, which was also discussed in [1]. [[[ Let svn blame truncate long author names to keep the column

Re: [PATCH] Let svn blame truncate long author names to keep the column width fixed to 10 characters

2010-06-24 Thread Daniel Shahaf
You truncate the author name even in 'svn blame -v' --- is that per the previous thread's concensus too? (Personally I lean towards not truncating with -v.) Daniel (no need to re-send for this) Johan Corveleyn wrote on Thu, 24 Jun 2010 at 14:25 -: Ping. This patch hasn't gotten feedback

RE: [Patch] Support OS/2

2010-06-24 Thread Bert Huijben
-Original Message- From: Paul Smedley [mailto:p...@smedley.id.au] Sent: donderdag 24 juni 2010 15:04 To: dev@subversion.apache.org Subject: [Patch] Support OS/2 Hi All, I've been building Subversion on OS/2 for some time, and figured it was time to request to get the patches

Re: [Patch] Support OS/2

2010-06-24 Thread Julian Foad
Paul Smedley wrote: I've been building Subversion on OS/2 for some time, and figured it was time to request to get the patches incorporated in the main distribution. Hi Paul. Thanks - we'd be delighted to receive your changes to make Subversion work on OS/2. The current diff, based on

Getting delta content length

2010-06-24 Thread Ramkumar Ramachandra
Hi, We're working on a project to replay revisions using the replay API and dump a deltified dumpfile to stdout on-the-fly without using a filesystem backing. Althought the md5sum seems to be available through svn_txdelta_apply, the length of the delta doesn't seem to be. Without this length, we

Re: Getting delta content length

2010-06-24 Thread C. Michael Pilato
Ramkumar Ramachandra wrote: Hi, We're working on a project to replay revisions using the replay API and dump a deltified dumpfile to stdout on-the-fly without using a filesystem backing. Althought the md5sum seems to be available through svn_txdelta_apply, the length of the delta doesn't

Re: Getting delta content length

2010-06-24 Thread Ramkumar Ramachandra
Hi, IIRC, Subversion is calculating that delta on the fly, so it can't exactly hand you up-front the length thereof.  Could you use a temporary file on disk (and a stat() call for the filesize) instead of in-memory storage as your go-between? I see. Writing to filesystem and measuring size

Re: dangerous implementation of rep-sharing cache for fsfs

2010-06-24 Thread Julian Foad
michael.fe...@evonik.com wrote: [The new representation caching in 1.6] could save us a lot of disk space on the server [...]. But unfortunately it seems we could not use it :-( Because after what the source code of rep.cache.c and fs_fs.c in libsvn_fs_fs looks to me, the mechanism to find

Re: dangerous implementation of rep-sharing cache for fsfs

2010-06-24 Thread Daniel Shahaf
Julian Foad wrote on Thu, 24 Jun 2010 at 17:21 -: I am not sure whether the representation whose SHA-1 sum is stored is ever an exact copy of the user's file. If it is - if it does not include an extra header and is not stored in a delta format - then the That is not the case: [[[

Re: Antwort: Re: dangerous implementation of rep-sharing cache for fsfs

2010-06-24 Thread Greg Hudson
On Thu, 2010-06-24 at 11:29 -0400, michael.fe...@evonik.com wrote: We must ensure that the data in the repository is, without any concerns, the data we have once measured or written. You do realize that the probability of data corruption due to faulty hardware is much, much more likely than

RE: svn commit: r957608 - in /subversion/trunk/subversion/libsvn_client: info.c status.c

2010-06-24 Thread Bert Huijben
-Original Message- From: hwri...@apache.org [mailto:hwri...@apache.org] Sent: donderdag 24 juni 2010 18:20 To: comm...@subversion.apache.org Subject: svn commit: r957608 - in /subversion/trunk/subversion/libsvn_client: info.c status.c Author: hwright Date: Thu Jun 24 16:19:42

Re: svn commit: r957587 - in /subversion/trunk/subversion: libsvn_ra_svn/client.c libsvn_ra_svn/protocol svnserve/serve.c

2010-06-24 Thread Daniel Shahaf
danie...@apache.org wrote on Thu, 24 Jun 2010 at 18:52 -: Modified: subversion/trunk/subversion/svnserve/serve.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnserve/serve.c?rev=957587r1=957586r2=957587view=diff

Re: svn commit: r957587 - in /subversion/trunk/subversion: libsvn_ra_svn/client.c libsvn_ra_svn/protocol svnserve/serve.c

2010-06-24 Thread C. Michael Pilato
Daniel Shahaf wrote: danie...@apache.org wrote on Thu, 24 Jun 2010 at 18:52 -: Modified: subversion/trunk/subversion/svnserve/serve.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnserve/serve.c?rev=957587r1=957586r2=957587view=diff

Re: svn commit: r957094 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_fs*/ subversion/libsvn_ra*/ ...

2010-06-24 Thread Arfrever Frehtes Taifersar Arahesis
2010-06-24 18:35:21 Daniel Shahaf napisał(a): C. Michael Pilato wrote on Wed, 23 Jun 2010 at 22:43 -: Daniel Shahaf wrote: - SVN_ERR(svn_ra_svn_write_cmd(conn, pool, get-locks, c, path)); + /* Figure out the repository abspath from PATH. */ + abs_path =

[Patch] - Fix paths on OS/2 - svn-paths.diff [1/1]

2010-06-24 Thread Paul Smedley
[[[ Fix paths command prompts for OS/2 by re-using WIN32 #ifdef's * subversion/libsvn_subr/dirent_uri.c * subversion/libsvn_subr/io.c * subversion/libsvn_subr/prompt.c * subversion/libsvn_ra_local/split_url.c * subversion/libsvn_fs_fs/fs_fs.c (various): Use WIN32 code for paths with drive

Re: Stalish downloads still on Tigris

2010-06-24 Thread C. Michael Pilato
Jack Repenning wrote: It turns out that there are still quite a few folks downloading the rather stale-ish binary packages still stored on Tigris (Subversion installers and language bindings). We see around 40,000 downloads of these files per week, even though the newest is version 1.6.6.

Re: Ruby bindings don't work with 1.9 + patch

2010-06-24 Thread Joe Swatosh
On Thu, Jun 24, 2010 at 4:15 AM, Hyrum K. Wright hyrum_wri...@mail.utexas.edu wrote: Applied in r957507.  I noticed the patch was against 1.6.12, but it applied cleanly to trunk.  In the future, please make patches against trunk (and hopefully include a log message). Should this be backported

[Patch] OS/2 configuration changes - svn-config.diff [1/1]

2010-06-24 Thread Paul Smedley
Hi All, Patches to change configuration slightly for OS/2 clients. [[[ Fix Subversion on OS/2 * subversion/libsvn_subr/config_file.c (svn_config_ensure): Add OS/2 .cmd files as type eol_native * subversion/include/svn_config.h (SVN_CONFIG__DEFAULT_GLOBAL_IGNORES_LINE_2): Add

Re: [Patch] OS/2 configuration changes - svn-config.diff [1/1]

2010-06-24 Thread Paul Smedley
Hi All, This one should be suitable for both the 1.6.x branch the trunk. On Fri, 25 Jun 2010 03:28:10 UTC, Paul Smedley pauldes...@despamsmedley.id.au wrote: Hi All, Patches to change configuration slightly for OS/2 clients. [[[ Fix Subversion on OS/2 *

Re: [Patch] - Fix paths on OS/2 - patch for trunk - svn-paths-trunk.diff [1/1]

2010-06-24 Thread Paul Smedley
Hi All, This patch is for trunk: [[[ Fix paths command prompts for OS/2 by re-using WIN32 #ifdef's * subversion/libsvn_subr/dirent_uri.c * subversion/libsvn_subr/io.c * subversion/libsvn_subr/prompt.c * subversion/libsvn_ra_local/split_url.c * subversion/libsvn_fs_fs/fs_fs.c (various): Use

Re: [Patch] - Fix paths on OS/2 - svn-paths.diff [1/1]

2010-06-24 Thread Daniel Näslund
On Fri, Jun 25, 2010 at 02:03:17AM +, Paul Smedley wrote: [[[ Fix paths command prompts for OS/2 by re-using WIN32 #ifdef's * subversion/libsvn_subr/dirent_uri.c * subversion/libsvn_subr/io.c * subversion/libsvn_subr/prompt.c * subversion/libsvn_ra_local/split_url.c *