Re: svn commit: r965943 - in /subversion/trunk/subversion: svn/commit-cmd.c tests/cmdline/input_validation_tests.py

2010-07-20 Thread Neels J Hofmeyr
On 2010-07-20 20:23, s...@apache.org wrote: > Author: stsp > Date: Tue Jul 20 18:23:11 2010 > New Revision: 965943 > > URL: http://svn.apache.org/viewvc?rev=965943&view=rev > Log: > Turns out that 'svn commit' is already pretty good at rejecting URL targets. > Add a test for it anyway and do some

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Jul 20, 2010 at 23:05:45 +0300: > Hyrum K. Wright wrote on Tue, Jul 20, 2010 at 11:29:38 -0500: > > On Jul 20, 2010, at 9:32 AM, Simon Atanasyan wrote: > > > I am not sure that SQLite locking works correctly over network share > > > due the limit file level locking supp

Re: File externals, 1.5 client, and 1.7 client: dies with with "In file 'subversion/libsvn_wc/adm_ops.c' line 2343: assertion failed (external_repos_relpath != NULL)"

2010-07-20 Thread 'Daniel Shahaf'
Bert Huijben wrote on Mon, Jul 19, 2010 at 22:21:55 +0200: > As noted on IRC, I fixed the assertion in r965523. But note that this > doesn't make the scenario work as libsvn_wc can't determine if two different > urls point to the same repository. > Thanks. > I would recommend using repository re

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Daniel Shahaf
Simon Atanasyan wrote on Tue, Jul 20, 2010 at 19:51:47 +0400: > + apr_hash_set(fs_config, SVN_FS_CONFIG_FSFS_REP_SHARING, > + APR_HASH_KEY_STRING, > + (opt_state->fsfs_no_rep_sharing ? "0" : "1")); > + >apr_hash_set(fs_config, SVN_FS_CONFIG_BDB_TXN_NOSYNC, >

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Daniel Shahaf
Hyrum K. Wright wrote on Tue, Jul 20, 2010 at 11:29:38 -0500: > > > > > On Jul 20, 2010, at 9:32 AM, Simon Atanasyan wrote: > > > The general idea of the patch is to introduce new svnadmin option > > and FSFS filesystem configuration option to allow enabling/disabling > > repository sharing o

Re: svn commit: r27653 - in trunk/subversion: libsvn_client libsvn_ra

2010-07-20 Thread David Glasser
Let's play "incredibly late code review"! The fallback implementation svn_ra__file_revs_from_log incorrectly ignores its "path" argument. (The only call from libsvn_client hardcodes "" as that argument, so people using libsvn_client instead of libsvn_ra directly will not notice.) Also, if pointe

Re: svn commit: r965892 - in /subversion/trunk: notes/dump-load-format.txt subversion/include/svn_repos.h subversion/libsvn_repos/dump.c

2010-07-20 Thread Stefan Sperling
On Tue, Jul 20, 2010 at 04:14:53PM -, s...@apache.org wrote: > Author: stsp > Date: Tue Jul 20 16:14:53 2010 > New Revision: 965892 > > URL: http://svn.apache.org/viewvc?rev=965892&view=rev > Log: > Make svnadmin dump print headers containing MD5 and SHA1 checksums of > property content, as wa

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread C. Michael Pilato
On 07/20/2010 12:29 PM, Hyrum K. Wright wrote: > Is this in addition or in place of the already-present capability to > disable rep-sharing via the db/fsfs.conf file? Since we already expose > the option elsewhere, I'm not convinced we need an additional option for > svnadmin. There is at least s

Re: svn commit: r965892 - in /subversion/trunk: notes/dump-load-format.txt subversion/include/svn_repos.h subversion/libsvn_repos/dump.c

2010-07-20 Thread C. Michael Pilato
On 07/20/2010 12:14 PM, s...@apache.org wrote: > Author: stsp > Date: Tue Jul 20 16:14:53 2010 > New Revision: 965892 [...] > (dump_nodem, write_revision_record): When dumping properties, generate ^ Oops? -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed D

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Hyrum K. Wright
On Jul 20, 2010, at 9:32 AM, Simon Atanasyan wrote: > The general idea of the patch is to introduce new svnadmin option > and FSFS filesystem configuration option to allow enabling/disabling > repository sharing on FSFS. > > I am not sure that SQLite locking works correctly over network shar

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Simon Atanasyan
On Tue, Jul 20, 2010 at 18:32, Simon Atanasyan wrote: > The patch itself is in the attachment. The missed patch file. -- Simon Atanasyan VisualSVN Limited Index: subversion/svnadmin/main.c === --- subversion/svnadmin/main.c (revis

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Philip Martin
Simon Atanasyan writes: > The general idea of the patch is to introduce new svnadmin option > and FSFS filesystem configuration option to allow enabling/disabling > repository sharing on FSFS. > > I am not sure that SQLite locking works correctly over network share > due the limit file level lock

[PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Simon Atanasyan
The general idea of the patch is to introduce new svnadmin option and FSFS filesystem configuration option to allow enabling/disabling repository sharing on FSFS. I am not sure that SQLite locking works correctly over network share due the limit file level locking support offered by OS for network