I do understand that the following invocation is not proper (I obviously
missed --relocate)
% svn switch svn:// svn+ssh://gerald@
but assume svn should not run into an assertion but diagnose this
differently
svn: subversion/libsvn_subr/path.c:114: svn_path_join: Assertion
`svn_path_is_
Hi Daniel,
Thanks for the review. Here's another revision.
[[[
* subversion/tests/cmdline/svntest/actions.py
(run_and_verify_svnrdump): Add new function to run svnrdump with
'-q', verify that stderr is empty, exit_code is zero, and return the
output on stdout.
* subversion/tests/cmdline/svn
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 22:28:12 +0530:
> Hi,
>
> Thanks to Daniel for suggesting this.
>
> -- Ram
>
> [[[
> * subversion/tests/cmdline/svntest/actions.py
> (run_and_verify_svnrdump): Add new function to run svnrdump with
> '-q', verify that stderr is empty, and re
Hi,
Thanks to Daniel for suggesting this.
-- Ram
[[[
* subversion/tests/cmdline/svntest/actions.py
(run_and_verify_svnrdump): Add new function to run svnrdump with
'-q', verify that stderr is empty, and return the output on stdout.
* subversion/tests/cmdline/svnrdump_tests.py
(run_test, ba
I've drilled a changelist into 'svn patch'.
[[[
0:% $svn st subversion
0:% $svn patch ../diffs/svn-patch-add_to_cl.diff --add-to-cl cl
A [cl] subversion/tests/libsvn_client/client-test.c
U subversion/tests/libsvn_client/client-test.c
A [cl] subversion/svn/patch-cmd.c
U subversion/
Hi,
The tests in svnsync_tests_data/ are in dumpfile v2 and these are
unsuitable for testing svnrdump. Hence, load all of them into a
repository and re-dump them in dumpfile v3 format before attempting to
add them to svnrdump_tests_data/. I still have to figure out how to
extend the test framework
Hi,
Instead of spawning diff, I used difflib in Python. Here's the
result. I need a +1 to commit this since it's outside my area.
Thanks.
-- Ram
[[[
* subversion/tests/cmdline/svntest/verify.py (display_lines): Use
Python difflib to output a context diff instead of printing actual
and expec
Hi Stefan,
Stefan Sperling writes:
> ... this won't work on windows.
>
> We'll need a utility function in our test suite that prints diffs.
Right. How about this?
Index: subversion/tests/cmdline/svntest/verify.py
===
--- subversion
Stefan Sperling wrote on Sat, Jul 24, 2010 at 15:55:19 +0200:
> On Sat, Jul 24, 2010 at 06:46:11PM +0530, Ramkumar Ramachandra wrote:
> > Hi,
> >
> > This patch is not intended for inclusion, but I hope it conveys the
> > idea- I want display_lines() to display a diff instead of the full
> > actua
On Sat, Jul 24, 2010 at 06:46:11PM +0530, Ramkumar Ramachandra wrote:
> Hi,
>
> This patch is not intended for inclusion, but I hope it conveys the
> idea- I want display_lines() to display a diff instead of the full
> actual and expected outputs.
That would be nice indeed, but ...
> + exit_cod
Hi,
This patch is not intended for inclusion, but I hope it conveys the
idea- I want display_lines() to display a diff instead of the full
actual and expected outputs.
Thanks.
Index: subversion/tests/cmdline/svntest/verify.py
===
--
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 16:58:34 +0530:
> Hi Daniel,
>
> Daniel Shahaf writes:
> > Please don't add "Review by" before I've actually reviewed the patch,
> > thanks :-)
>
> Um, right. I guess I misunderstood you when you asked me to put the
> 'Review by' in your previou
Hi Daniel,
Daniel Shahaf writes:
> Please don't add "Review by" before I've actually reviewed the patch, thanks
> :-)
Um, right. I guess I misunderstood you when you asked me to put the
'Review by' in your previous email. I'll include it while actually
committing, but not in the email.
> Perhap
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 16:28:49 +0530:
> Hi Daniel,
>
> Daniel Shahaf writes:
> > Not your fault, but that's not what I meant. What I meant was to check for
> > no
> > unexpected stderr (e.g., no "svn: warning %s" or similar).
> >
> > For example, you could do that b
C. Michael Pilato wrote on Fri, Jul 23, 2010 at 15:15:37 -0400:
> On 07/23/2010 03:13 PM, danie...@apache.org wrote:
> > Author: danielsh
> > Date: Fri Jul 23 19:13:52 2010
> > New Revision: 967212
>
> [...]
>
> > * subversion/libsvn_repos/deprecated.c
> > (svn_repos_fs_change_rev_prop3):
> >
Hi Daniel,
Daniel Shahaf writes:
> Not your fault, but that's not what I meant. What I meant was to check for no
> unexpected stderr (e.g., no "svn: warning %s" or similar).
>
> For example, you could do that by running 'svnrdump -q' and then verifying
> that
> *nothing* was printed to stderr.
artag...@apache.org wrote on Sat, Jul 24, 2010 at 10:18:58 -:
> + # Create a dump file using svnrdump
> + r, svnrdump_dumpfile, err = svntest.main.run_svnrdump(sbox.repo_url)
> +
> + # Check error code
> + if (r != 0):
> +raise svntest.Failure('Result code not 0')
> +
> + # Check the o
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 15:21:41 +0530:
> Daniel Shahaf writes:
> > Have you run 'make check'? :-)
>
> Yeah, but I usually execute the Python script raw from command-line
> when I want to test my changes. It currently doesn't really need all
> the setup that `make check
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 14:59:07 +0530:
> Hi,
>
> Thanks to Stefan and Daniel, I now have a neat patch with a nice log
> message.
>
You could thank us by adding a "Review by" header in the log message. :-)
> +++ subversion/tests/cmdline/svnrdump_tests.py(worki
Hi Daniel,
Daniel Shahaf writes:
> > > First of all, please don't verify a 100k dumpfile during every 'make
> > > check'.
> > > It would take too long.
> >
> > Ah, I didn't think about that.
> >
>
> Have you run 'make check'? :-)
Yeah, but I usually execute the Python script raw from command
Hi Stefan,
Stefan Sperling writes:
> (I guess you're getting the idea, but I'd still like to point out that,
> for new functions, it's OK to just say 'New function.'. But if you make
> further changes to the functions, just saying 'I changed this function.'
> is not detailed enough... :)
>
> Not
Hi,
Thanks to Stefan and Daniel, I now have a neat patch with a nice log
message.
[[[
svnrdump: Add a regression test which verifies that revision 0 of a
repository is dumped correctly. Revision 0 only has revision
properties, so it's somewhat special.
* subversion/tests/cmdline/svnrdump_tests_d
On Sat, Jul 24, 2010 at 01:16:02PM +0530, Ramkumar Ramachandra wrote:
> Hi Daniel,
>
> Daniel Shahaf writes:
> > Where is the log message?
>
> My proposed svn:log
> * subversion/tests/cmdline/svnrdump_tests_data: Add a new directory to
> keep test data for svnrdump.
> * subversion/tests/cmdline
On Sat, Jul 24, 2010 at 01:19:15PM +0530, Ramkumar Ramachandra wrote:
> Hi Daniel,
>
> Daniel Shahaf writes:
> > Revving these interfaces falls under the "editor v2" header, for which see
> > svn_editor.h (not implemented yet) and notes/editor-v2.txt.
>
> I see. Thanks for the pointer. Looks like
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 13:37:35 +0530:
> I'll commit it now.
>
Please don't "Approved by: danielsh"; I haven't +1'd the patch yet.
(e.g., I haven't run it yet)
> > First of all, please don't verify a 100k dumpfile during every 'make check'.
> > It would take too long
Hi Daniel,
Daniel Shahaf writes:
> Good start. But you don't have a first sentence before the bullets (which we
> want for most non-small changes), and you aren't using the standard
> (function_name)
> syntax. So, perhaps along these lines:
>
> [[[
> Add a unit test for svnrdump dumping r0.
>
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 13:16:02 +0530:
> Daniel Shahaf writes:
> > Where is the log message?
>
> My proposed svn:log
> * subversion/tests/cmdline/svnrdump_tests_data: Add a new directory to
> keep test data for svnrdump.
> * subversion/tests/cmdline/svnrdump_tests_dat
Hi Daniel,
Daniel Shahaf writes:
> Revving these interfaces falls under the "editor v2" header, for which see
> svn_editor.h (not implemented yet) and notes/editor-v2.txt.
I see. Thanks for the pointer. Looks like I'll have to wait until
editor v2 is finished to dump sha1sums then.
> BTW: adding
Hi Daniel,
Daniel Shahaf writes:
> Where is the log message?
My proposed svn:log
* subversion/tests/cmdline/svnrdump_tests_data: Add a new directory to
keep test data for svnrdump.
* subversion/tests/cmdline/svnrdump_tests_data/asf-0.dump: Add a
dumpfile of the zeroth revision of the ASF repo
Hi,
After Bert pointed out some problems with my patch on IRC, I've
updated it. Here's the new patch including the original basic_svnrdump
test as well.
Thanks.
Index: subversion/tests/cmdline/svnrdump_tests.py
===
--- subversion/te
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 03:37:06 +0530:
> Hi Stefan,
>
> Stefan Sperling writes:
> > I'd say get the basics right first, before worrying about features
> > like this. In my opinion that means that it needs to produce the same
> > output as svnadmin dump does. (I'm planni
Where is the log message?
Why are you removing basic_svnrdump()?
Why are you using r0 *of the ASF repository* --- is anything special about that
repository?
Should we have run_and_verify_svnrdump()?
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 03:33:53 +0530:
> Hi,
>
> Here's a patch for
32 matches
Mail list logo
