How to preserve err->apr_err error codes over the wire in ra_dav?

2010-08-07 Thread Daniel Shahaf
In order to properly use the svn_ra_change_rev_prop2() API (on the 'atomic-revprop') branch, I'd like to make it return a specific error code (over all RA layers) when the propchange fails due to the provided expected value not being the found value. (That's kinda the point of the new API

Re: svn commit: r983269 - in /subversion/branches/atomic-revprop: ./ notes/http-and-webdav/ subversion/include/private/ subversion/libsvn_ra_neon/ subversion/libsvn_ra_serf/ subversion/mod_dav_svn/

2010-08-07 Thread Daniel Shahaf
danie...@apache.org wrote on Sat, Aug 07, 2010 at 17:45:39 -: > Author: danielsh > Date: Sat Aug 7 17:45:38 2010 > New Revision: 983269 > > URL: http://svn.apache.org/viewvc?rev=983269&view=rev > Log: > On the 'atomic-revprop' branch: > > Implement the API over ra_dav. > I'll appreciate so

Re: Bikeshed: configuration override order

2010-08-07 Thread Greg Hudson
On Sat, 2010-08-07 at 07:58 -0400, Daniel Shahaf wrote: > Stefan Küng wrote on Sat, Aug 07, 2010 at 12:59:26 +0200: > > On 07.08.2010 12:44, Daniel Shahaf wrote: > >> If corporations want to have configuration override, fine. > >> > >> But I want a way to disable that completely. I don't necessari

Re: svn commit: r983222 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-08-07 Thread Branko Čibej
On 07.08.2010 16:32, Ramkumar Ramachandra wrote: > Hi Daniel, > > Daniel Shahaf writes: > >> artag...@apache.org wrote on Sat, Aug 07, 2010 at 12:31:50 -: >> >>> Author: artagnon >>> Date: Sat Aug 7 12:31:50 2010 >>> New Revision: 983222 >>> >>> URL: http://svn.apache.org/viewvc?rev=98

Re: svn commit: r983096 - in /subversion/trunk/subversion/svnrdump: load_editor.c load_editor.h

2010-08-07 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sat, Aug 07, 2010 at 20:00:28 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > Ramkumar, I've noticed before in your patches that they tend to have > > multiple separable parts, and this commit is a good opportunity to explain: > > Thanks for the review. > > > >

Re: svn commit: r983222 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-08-07 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > artag...@apache.org wrote on Sat, Aug 07, 2010 at 12:31:50 -: > > Author: artagnon > > Date: Sat Aug 7 12:31:50 2010 > > New Revision: 983222 > > > > URL: http://svn.apache.org/viewvc?rev=983222&view=rev > > Log: > > svnrdump: Fix a bug in the load_editor;

Re: svn commit: r983096 - in /subversion/trunk/subversion/svnrdump: load_editor.c load_editor.h

2010-08-07 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Ramkumar, I've noticed before in your patches that they tend to have > multiple separable parts, and this commit is a good opportunity to explain: Thanks for the review. > >if (strcmp(hname, SVN_REPOS_DUMPFILE_NODE_COPYFROM_REV) == 0) > > nb->c

Re: svn commit: r983222 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-08-07 Thread Daniel Shahaf
artag...@apache.org wrote on Sat, Aug 07, 2010 at 12:31:50 -: > Author: artagnon > Date: Sat Aug 7 12:31:50 2010 > New Revision: 983222 > > URL: http://svn.apache.org/viewvc?rev=983222&view=rev > Log: > svnrdump: Fix a bug in the load_editor; it was unable to handle > revisions without node i

Re: svn commit: r983096 - in /subversion/trunk/subversion/svnrdump: load_editor.c load_editor.h

2010-08-07 Thread Daniel Shahaf
Ramkumar, I've noticed before in your patches that they tend to have multiple separable parts, and this commit is a good opportunity to explain: artag...@apache.org wrote on Fri, Aug 06, 2010 at 19:10:20 -: > Author: artagnon > Date: Fri Aug 6 19:10:20 2010 > New Revision: 983096 > > URL: ht

Re: Bikeshed: configuration override order

2010-08-07 Thread Daniel Shahaf
Stefan Küng wrote on Sat, Aug 07, 2010 at 12:59:26 +0200: > On 07.08.2010 12:44, Daniel Shahaf wrote: >> If corporations want to have configuration override, fine. >> >> But I want a way to disable that completely. I don't necessarily want to >> allow a random sourceforge repository to control my

Re: svn_wc_translated_file3

2010-08-07 Thread Stefan Küng
On 07.08.2010 12:52, Daniel Shahaf wrote: What's the solution? I'm using svn_wc_get_pristine_copy_path() and disable the deprecated warnings for that API call. I won't get a translated file that way, but most if not all UI diff tools have options to ignore EOLs. And if keywords aren't expand

Re: Bikeshed: configuration override order

2010-08-07 Thread Stefan Küng
On 07.08.2010 12:44, Daniel Shahaf wrote: If corporations want to have configuration override, fine. But I want a way to disable that completely. I don't necessarily want to allow a random sourceforge repository to control my auto-props settings for a wc of that repository. Maybe a stupid que

Re: svn_wc_translated_file3

2010-08-07 Thread Daniel Shahaf
What's the solution? Stefan Küng wrote on Fri, Aug 06, 2010 at 23:56:37 +0200: > Never mind - I found a solution to the problem. > > Stefan > > On Fri, Aug 6, 2010 at 21:42, Stefan Küng wrote: > > Hi, > > > > Just noticed that the API svn_wc_translated_file3() has been removed in > > r963632: >

Re: RFC: WCNG and Issue #2915: Merge tracking and missing subtrees due to non-svn removal

2010-08-07 Thread Daniel Shahaf
Paul Burba wrote on Fri, Aug 06, 2010 at 10:30:50 -0400: > As described in issue #2915, in 1.6 when a merge target is a missing > subtree due to its removal by non-svn means, we try to record > mergeinfo such that the missing subtree doesn't have (or inherit) > mergeinfo describing the merge: > >

Re: Bikeshed: configuration override order

2010-08-07 Thread Daniel Shahaf
If corporations want to have configuration override, fine. But I want a way to disable that completely. I don't necessarily want to allow a random sourceforge repository to control my auto-props settings for a wc of that repository. So. We could have an allow-repos-config switch (parallel to th

Re: Bikeshed: configuration override order

2010-08-07 Thread Daniel Shahaf
Stefan Sperling wrote on Fri, Aug 06, 2010 at 21:51:37 +0200: > Why do we have settings in the individual client config that all users > would want to share anyway? > > So maybe having auto-props in the config is part of the problem? What about > having an svn:auto-props property at the parent dir