Re: Upgrade from 1.6 must use the same incremental steps? [was: svn commit: r987526 - ...]

2010-08-22 Thread Daniel Shahaf
Justin Erenkrantz wrote on Sun, Aug 22, 2010 at 14:23:15 -0700: > On Sun, Aug 22, 2010 at 11:14 AM, Daniel Shahaf > wrote: > > Greg Stein wrote on Fri, Aug 20, 2010 at 14:11:21 -0400: > >> I wish you wouldn't change the subject line so often. > > > > Why not?  It has proper References: and In-Rep

Re: svn commit: r987689 - /subversion/branches/1.6.x/STATUS

2010-08-22 Thread Justin Erenkrantz
On Sun, Aug 22, 2010 at 7:25 PM, Greg Stein wrote: > I also added an API to serf to facilitate runtime version checks (ie. > hopefully before a call to a bogus signature is performed). But that > call is only in later versions :-P Yup - I noticed that when I added the minimum version auto-fu chec

Re: svn commit: r987689 - /subversion/branches/1.6.x/STATUS

2010-08-22 Thread Greg Stein
On Sun, Aug 22, 2010 at 17:30, Justin Erenkrantz wrote: > On Sun, Aug 22, 2010 at 1:02 PM, Lieven Govaerts wrote: >> Hey Justin, >> >> On Sat, Aug 21, 2010 at 4:30 AM,   wrote: >>> Author: jerenkrantz >>> Date: Sat Aug 21 02:30:31 2010 >>> New Revision: 987689 >>> >>> URL: http://svn.apache.org/v

Re: Upgrade from 1.6 must use the same incremental steps? [was: svn commit: r987526 - ...]

2010-08-22 Thread Greg Stein
On Sun, Aug 22, 2010 at 17:23, Justin Erenkrantz wrote: > On Sun, Aug 22, 2010 at 11:14 AM, Daniel Shahaf > wrote: >> Greg Stein wrote on Fri, Aug 20, 2010 at 14:11:21 -0400: >>> I wish you wouldn't change the subject line so often. >> >> Why not?  It has proper References: and In-Reply-To:.  Sh

Re: Upgrade from 1.6 must use the same incremental steps? [was: svn commit: r987526 - ...]

2010-08-22 Thread Justin Erenkrantz
On Sun, Aug 22, 2010 at 11:14 AM, Daniel Shahaf wrote: > Greg Stein wrote on Fri, Aug 20, 2010 at 14:11:21 -0400: >> I wish you wouldn't change the subject line so often. > > Why not?  It has proper References: and In-Reply-To:.  Should be enough > for threading to work, no? Not with Gmail - chan

Re: svn commit: r987689 - /subversion/branches/1.6.x/STATUS

2010-08-22 Thread Justin Erenkrantz
On Sun, Aug 22, 2010 at 1:02 PM, Lieven Govaerts wrote: > Hey Justin, > > On Sat, Aug 21, 2010 at 4:30 AM,   wrote: >> Author: jerenkrantz >> Date: Sat Aug 21 02:30:31 2010 >> New Revision: 987689 >> >> URL: http://svn.apache.org/viewvc?rev=987689&view=rev >> Log: >> Propose r879757 & r880320 for

Re: svn commit: r987689 - /subversion/branches/1.6.x/STATUS

2010-08-22 Thread Lieven Govaerts
Hey Justin, On Sat, Aug 21, 2010 at 4:30 AM, wrote: > Author: jerenkrantz > Date: Sat Aug 21 02:30:31 2010 > New Revision: 987689 > > URL: http://svn.apache.org/viewvc?rev=987689&view=rev > Log: > Propose r879757 & r880320 for backport to 1.6.x. > > Modified: >    subversion/branches/1.6.x/STATU

Re: svn commit: r987888 - in /subversion/branches/performance: ./ build/win32/

2010-08-22 Thread Daniel Shahaf
See r987210 on trunk. stef...@apache.org wrote on Sun, Aug 22, 2010 at 12:19:57 -: > Author: stefan2 > Date: Sun Aug 22 12:19:57 2010 > New Revision: 987888 > > URL: http://svn.apache.org/viewvc?rev=987888&view=rev > Log: > svn:ignore file generated by VisualStudio 2010 > > * / > ignore ip

Re: svn commit: r987872 - in /subversion/branches/performance/subversion: include/private/svn_temp_serializer.h libsvn_fs_fs/dag.c libsvn_subr/svn_temp_serializer.c

2010-08-22 Thread Daniel Shahaf
stef...@apache.org wrote on Sun, Aug 22, 2010 at 11:43:48 -: > Author: stefan2 > Date: Sun Aug 22 11:43:47 2010 > New Revision: 987872 > > URL: http://svn.apache.org/viewvc?rev=987872&view=rev > Log: > Build file generation scripts don't handle uppercase identifiers. > Therefore, we can't have

Re: [PATCH] add docstrings to libsvn_ra_neon's 207 XML parser

2010-08-22 Thread Daniel Shahaf
Julian Foad wrote on Fri, Aug 20, 2010 at 18:12:29 +0100: > On Fri, 2010-08-20, Daniel Shahaf wrote: > > I arrived at these docstrings by reverse-engineering the implementation > > and some guesses. Could someone confirm my understanding? > > > > [[[ > > * subversion/libsvn_ra_neon/util.c > > (

Re: Upgrade from 1.6 must use the same incremental steps? [was: svn commit: r987526 - ...]

2010-08-22 Thread Daniel Shahaf
Greg Stein wrote on Fri, Aug 20, 2010 at 14:11:21 -0400: > I wish you wouldn't change the subject line so often. Why not? It has proper References: and In-Reply-To:. Should be enough for threading to work, no?

Re: svn commit: r987869 - /subversion/branches/performance/subversion/libsvn_fs_fs/temp_serial izer.c

2010-08-22 Thread Daniel Shahaf
Stefan Sperling wrote on Sun, Aug 22, 2010 at 13:44:07 +0200: > On Sun, Aug 22, 2010 at 11:37:38AM -, stef...@apache.org wrote: > > + apr_size_t entries_len = count * sizeof(svn_fs_dirent_t*[1]); > So how would this be parsed? Is it parsed as sizeof( (type *) [1] ) ? > Do you rea

Re: Performance branch ready for review

2010-08-22 Thread Daniel Shahaf
Stefan, you did mention "Patch by" for Johan's patches which you committed, did you intend to mention "Found by" or "Suggested by" for the other two (quoted below)? http://subversion.apache.org/docs/community-guide/conventions.html#crediting Thanks, Daniel Stefan Fuhrmann wrote on Sun, Aug 22,

Re: svn diff optimization to make blame faster?

2010-08-22 Thread Branko Čibej
On 18.08.2010 00:59, Johan Corveleyn wrote: > Hi devs, > > While "Looking to improve performance of svn annotate" [1], I found > that the current blame algorithm is mainly client-side bound, and that > most of its time is spent on "svn diff" (calls to svn_diff_file_diff_2 > from add_file_blame in b

Re: Performance branch ready for review

2010-08-22 Thread Stefan Fuhrmann
Johan Corveleyn wrote: On Wed, Aug 18, 2010 at 9:14 PM, Stefan Fuhrmann wrote: Hi @all, I just finished my porting work; the performance branch is now fully synchronized with my prototype code. From my point of view, review can start now. According to my measurements, the code is now faste

Re: svn commit: r986521 - in /subversion/branches/performance/subversion: libsvn_fs_fs/id.c libsvn_fs_fs/temp_serializer.c libsvn_subr/svn_temp_serializer.c

2010-08-22 Thread Stefan Fuhrmann
Johan Corveleyn wrote: On Wed, Aug 18, 2010 at 1:11 AM, wrote: Author: stefan2 Date: Tue Aug 17 23:11:13 2010 New Revision: 986521 URL: http://svn.apache.org/viewvc?rev=986521&view=rev Log: Change serialized representation of pointers: instead of storing offsets relative to the whole buffe

Re: svn commit: r987869 - /subversion/branches/performance/subversion/libsvn_fs_fs/temp_serializer.c

2010-08-22 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 01:44:07PM +0200, Stefan Sperling wrote: > On Sun, Aug 22, 2010 at 11:37:38AM -, stef...@apache.org wrote: > > Author: stefan2 > > Date: Sun Aug 22 11:37:38 2010 > > New Revision: 987869 > > > > URL: http://svn.apache.org/viewvc?rev=987869&view=rev > > Log: > > Fix Visu

Re: svn commit: r987869 - /subversion/branches/performance/subversion/libsvn_fs_fs/temp_serializer.c

2010-08-22 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 11:37:38AM -, stef...@apache.org wrote: > Author: stefan2 > Date: Sun Aug 22 11:37:38 2010 > New Revision: 987869 > > URL: http://svn.apache.org/viewvc?rev=987869&view=rev > Log: > Fix VisualStudio build: memory size calculation for variable size > arrays is not portab

Re: Issue #3693 -- any ideas?

2010-08-22 Thread Geoff Rowell
On Fri, Aug 20, 2010 at 5:46 PM, Hyrum K. Wright wrote: > On Fri, Aug 20, 2010 at 7:35 AM, C. Michael Pilato > wrote: >> See http://subversion.tigris.org/issues/show_bug.cgi?id=3693 >> >> Would it make sense for a multi-target update (such as 'svn update *') to >> print headers for each of its t

Re: sasl mechanisms order

2010-08-22 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 12:56:23PM +0200, Stefan Sperling wrote: > On Sun, Aug 22, 2010 at 12:17:41PM +0700, Victor Sudakov wrote: > > Colleagues, I understand that you are expecting a patch. I am sorry, I > > am a systems administrator and not a programmer, my code writing > > ability does not go

Re: sasl mechanisms order

2010-08-22 Thread Stefan Sperling
On Sun, Aug 22, 2010 at 12:17:41PM +0700, Victor Sudakov wrote: > Colleagues, I understand that you are expecting a patch. I am sorry, I > am a systems administrator and not a programmer, my code writing > ability does not go beyond scripting. Can you try this patch and let me know if it works? I