Re: svn commit: r1001413 - in /subversion/branches/performance/subversion: include/svn_string.h libsvn_subr/svn_string.c

2010-09-27 Thread Hyrum K. Wright
+1 to merge to trunk. On Sun, Sep 26, 2010 at 6:01 AM, wrote: > Author: stefan2 > Date: Sun Sep 26 11:01:03 2010 > New Revision: 1001413 > > URL: http://svn.apache.org/viewvc?rev=1001413&view=rev > Log: > Extensively document the benefits of svn_stringbuf_appendbyte and > the rationals behind it

Re: Some tips on profiling

2010-09-27 Thread Stefan Fuhrmann
On 27.09.2010 21:44, Ramkumar Ramachandra wrote: Hi Stefan, Could you tell me which tools you use to profile the various applications in trunk? I'm looking to profile svnrdump to fix some perf issues, but OProfile doesn't seem to work for me. Thanks. -- Ram Hi Ram, Under Linux, I'm using

[WIP] Gracefully handle svn_wc_prop_set4() errors in svn patch

2010-09-27 Thread Daniel Näslund
Hi! Questions - * Is it sane to add a svn_wc_notify_failed_prop_patch action for this special case? We're starting to have a lot of actions. * What is wrong with the way I handle the error? I hit err_abort() when the program terminates. (I'm expecting the answer to hurt a bit - th

Some tips on profiling

2010-09-27 Thread Ramkumar Ramachandra
Hi Stefan, Could you tell me which tools you use to profile the various applications in trunk? I'm looking to profile svnrdump to fix some perf issues, but OProfile doesn't seem to work for me. Thanks. -- Ram

Re: svnrdump tool

2010-09-27 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > svnsync allows you to sync a subdir of a repository (i.e., > svnsync $REPOS/trunk/A/B $MIRROR > ), but does it also create /trunk/A/B in the mirror? Yes, it does. > But for now I still think that svnrdump invocation I quoted above > shouldn't have outputted a

Re: place of svnrdump

2010-09-27 Thread Ramkumar Ramachandra
Hi Neels, Neels J Hofmeyr writes: > > I just benchmarked it recently and found that it dumps 1 revisions > > of the ASF repository in 106 seconds: that's about 94 revisions per > > second. > > Wow! That's magnitudes better than the 5 to 10 revisions per second I'm used > to (I think that's us

Re: Bindings for svn_auth_get_platform_specific_client_providers missing

2010-09-27 Thread Matthijs Kooijman
Hey Folks, > I've attached an updated patch with a test case. The testcase is a bity > ugly, since it tests each element of the returned array and keeps the > result in its own variable. This is needed since I can't predict how > many elements there will be in the returned array, but I didn't want

Re: svn commit: r1001677 - /subversion/trunk/notes/wc-ng/nodes

2010-09-27 Thread Greg Stein
NICE!! On Mon, Sep 27, 2010 at 07:40, wrote: > Author: ehu > Date: Mon Sep 27 11:40:18 2010 > New Revision: 1001677 > > URL: http://svn.apache.org/viewvc?rev=1001677&view=rev > Log: > Add NODES design considerations document in nodes/wc-ng/nodes. > > Added: >    subversion/trunk/notes/wc-ng/node

Re: migration to NODES

2010-09-27 Thread Julian Foad
On Fri, 2010-09-24, Greg Stein wrote: > On Fri, Sep 24, 2010 at 11:16, Julian Foad wrote: > >... > > I think we should produce a test framework that can give us a WC > > containing all the different possible WC states. Then we can write > > tests against this framework, some tests that test speci

Re: buildbot failure in ASF Buildbot on svn-x64-centos gcc

2010-09-27 Thread Greg Stein
Are these authz failures expected? On Mon, Sep 27, 2010 at 12:44, wrote: > The Buildbot has detected a new failure of svn-x64-centos gcc on ASF Buildbot. > Full details are available at: >  http://ci.apache.org/builders/svn-x64-centos%20gcc/builds/1343 > > Buildbot URL: http://ci.apache.org/ > >

Re: place of svnrdump (was: Re: svnmucc multiline property issue)

2010-09-27 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Sperling writes: > > "tools" and "subversion" are merely directory names. All I'm saying is > > this: I don't want packaging/ distribution overheads for such a simple > > package; users should be able to use whatever Subversion-interop tools > > that other developers build by jus

Re: place of svnrdump (was: Re: svnmucc multiline property issue)

2010-09-27 Thread Stefan Sperling
On Mon, Sep 27, 2010 at 07:48:06PM +0530, Ramkumar Ramachandra wrote: > Hi Stefan, > > Stefan Sperling writes: > > I don't really mind where svnrdump lives. > > The community is committed to supporting both the tools/ and subversion/ > > directories. > > "tools" and "subversion" are merely direct

Re: place of svnrdump (was: Re: svnmucc multiline property issue)

2010-09-27 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Sperling writes: > I don't really mind where svnrdump lives. > The community is committed to supporting both the tools/ and subversion/ > directories. "tools" and "subversion" are merely directory names. All I'm saying is this: I don't want packaging/ distribution overheads for

Re: place of svnrdump

2010-09-27 Thread Neels J Hofmeyr
On 2010-09-27 09:45, Ramkumar Ramachandra wrote: ... > I just benchmarked it recently and found that it dumps 1 revisions > of the ASF repository in 106 seconds: that's about 94 revisions per > second. Wow! That's magnitudes better than the 5 to 10 revisions per second I'm used to (I think th

NODES table - conditional compilation for op_depth

2010-09-27 Thread Julian Foad
Philip and I have started implementing op_depth in the NODES table, but we soon found there is more to do than simply calculating a value here and there. ("Implementing op_depth" means enabling multiply nested copies/replacements/adds/deletes etc., with the ability to revert at each level.) In th

Re: place of svnrdump (was: Re: svnmucc multiline property issue)

2010-09-27 Thread Stefan Sperling
On Sat, Sep 25, 2010 at 02:43:37PM +0200, Daniel Shahaf wrote: > Ramkumar Ramachandra wrote on Sat, Sep 25, 2010 at 11:59:49 +0530: > > Daniel Shahaf writes: > > > Would svnrdump benefit if, once 1.7.x branched and RC's start being > > > rolled, it were subjected to a more relaxed backporting polic

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Dominique Leuenberger
On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > needs to be something like: > > if test -n ["`echo "$NEON_VERSION" | $EGREP > '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then > > ? That should match 0.29-0.99 a

Build tools/ by default? (was: Re: place of svnrdump)

2010-09-27 Thread Stefan Sperling
On Sat, Sep 25, 2010 at 04:40:01PM +0200, Daniel Shahaf wrote: > Ramkumar Ramachandra wrote on Sat, Sep 25, 2010 at 19:15:16 +0530: > > I have no interest in politics, and I don't want to speculate why > > svnmucc isn't built by `make` by default. > > Because it lives in tools/. What about we sta

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Jon Foster
Dominique Leuenberger wrote: > On Mon, 2010-09-27 at 12:33 +0100, Jon Foster wrote: > > Hi, > > > > + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then > > + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], > > +[Define to 1 if you have Neon 0.29 or later.]) > > + fi > > > > Th

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Dominique Leuenberger
On Mon, 2010-09-27 at 12:33 +0100, Jon Foster wrote: > Hi, > > + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then > + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], > +[Define to 1 if you have Neon 0.29 or later.]) > + fi > > The comment says "0.29 or later" (which I think i

Re: [RFC] Preprocessor flags to target code to a specific API version

2010-09-27 Thread Hyrum K. Wright
On Sun, Sep 26, 2010 at 5:31 PM, Dani Church wrote: > On Sun, 26 Sep 2010, Daniel Shahaf wrote: > >> Adding the SVN_MAYBE_POISON(svn_wc_some_function) can be done >> mechanically (by a script that reads the @deprecated comments and >> transforms the header files accordingly) --- instead of editing

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Jon Foster
Hi, + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], +[Define to 1 if you have Neon 0.29 or later.]) + fi The comment says "0.29 or later" (which I think is right), but the test looks like it's checking for Neon 0.29 exactly

[PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Dominique Leuenberger
Hi All, [[[ Use Neon's system_proxy autodetection if no proxy has been explicitly specified. ]]] As a notebook user I'm of course using it on different locations/networks and one thing rather annoying is that subversion only cares for it's own configuration file when it comes to proxy connections

Re: place of svnrdump

2010-09-27 Thread Ramkumar Ramachandra
Hi Neels, Neels J Hofmeyr writes: > On a side note, svnsync happens to be relatively slow. I tried to svnsync > the ASF repos once (for huge test data). The slowness of svnsync made it > practically unfeasible to pull off. I ended up downloading a zipped dump and > 'svnadmin load'ing that dump. Ev