Re: trunk failing tests on Windows XP (32 bit): prop-tests.py 33, stat-tests.py 5, upgrade-tests.py 11

2010-10-04 Thread Hyrum K. Wright
On Mon, Oct 4, 2010 at 5:00 PM, Branko Čibej wrote: >  On 01.10.2010 15:45, Paul Burba wrote: >> On Thu, Sep 30, 2010 at 8:10 PM, Bert Huijben wrote: -Original Message- From: Johan Corveleyn [mailto:jcor...@gmail.com] Sent: vrijdag 1 oktober 2010 1:51 To: Subversion De

Re: trunk failing tests on Windows XP (32 bit): prop-tests.py 33, stat-tests.py 5, upgrade-tests.py 11

2010-10-04 Thread Branko Čibej
On 01.10.2010 15:45, Paul Burba wrote: > On Thu, Sep 30, 2010 at 8:10 PM, Bert Huijben wrote: >>> -Original Message- >>> From: Johan Corveleyn [mailto:jcor...@gmail.com] >>> Sent: vrijdag 1 oktober 2010 1:51 >>> To: Subversion Development >>> Subject: trunk failing tests on Windows XP (32

Re: svn commit: r1001084 - /subversion/branches/object-model/subversion/bindings/c++/include/Types.h

2010-10-04 Thread Blair Zajac
On 10/04/2010 01:54 PM, Hyrum Wright wrote: On Fri, Sep 24, 2010 at 4:30 PM, Blair Zajac wrote: On 9/24/10 2:25 PM, hwri...@apache.org wrote: Author: hwright Date: Fri Sep 24 21:25:44 2010 New Revision: 1001084 All the methods that return a const std::string can return a non-const std::st

Re: svn commit: r1004418 - in /subversion/trunk/subversion/bindings/javahl: native/ src/org/apache/subversion/javahl/ src/org/tigris/subversion/javahl/

2010-10-04 Thread Blair Zajac
On 10/04/2010 01:40 PM, hwri...@apache.org wrote: Author: hwright Date: Mon Oct 4 20:40:25 2010 New Revision: 1004418 URL: http://svn.apache.org/viewvc?rev=1004418&view=rev Log: Modified: subversion/trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl/SVNClient.java URL: http:

Re: svn commit: r1001084 - /subversion/branches/object-model/subversion/bindings/c++/include/Types.h

2010-10-04 Thread Hyrum Wright
On Fri, Sep 24, 2010 at 4:30 PM, Blair Zajac wrote: > On 9/24/10 2:25 PM, hwri...@apache.org wrote: >> >> Author: hwright >> Date: Fri Sep 24 21:25:44 2010 >> New Revision: 1001084 >> >> URL: http://svn.apache.org/viewvc?rev=1001084&view=rev >> Log: >> On the object-model branch: >> * subversion/b

Re: [PATCH] -cM-N command line syntax

2010-10-04 Thread Paul Burba
On Mon, Oct 4, 2010 at 12:43 PM, Peter Samuelson wrote: >> On Sat, Oct 2, 2010 at 9:34 PM, Peter Samuelson wrote: >> > Hmmm, in tests/cmdline/log_tests.py XFail(log_chanage_range), I see >> > Lieven thought -c might someday take ranges with ":" instead of "-". >> > But since the output uses "-",

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-10-04 Thread scott mc
I've attached the 1.6.12 patch and the 1.7.xx-svn patches. > -scottmc > > Scott McCreary > HaikuPorts > This time as in-line text: ---1.6.12.patch diff -urN subversion-1.6.12/subversion/libsvn_subr/config_file.c subversion-1.6.12-haiku/subversion/libsvn_subr/config_file.c ---

Re: [PATCH] for building subversion 1.6.12 for haiku

2010-10-04 Thread scott mc
Philip, On Thu, Sep 30, 2010 at 9:53 AM, Philip Martin wrote: > scott mc writes: > >> On Wed, Sep 29, 2010 at 5:45 PM, Philip Martin >> wrote: >> >>> Please write a log message: >> - >>

Re: [PATCH] -cM-N command line syntax

2010-10-04 Thread Peter Samuelson
[Paul Burba] > FWIW diff/merge gained -c in 1.4 and log got it in 1.5. Sounds right. > > The following patch allows "-c" on the command line to use the same > > range syntax as svn:mergeinfo.  Thus you can cut and paste those ranges > > from 'svn diff' output, into commands such as 'svn log' and

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Philip Martin
Philip Martin writes: > Stefan Sperling writes: > >> I think the warning is printed only for functions that are marked in >> a special way that GCC looks for. >> The svn_* functions don't have such markers. > > They don't have __attribute((sentinel)) but there is the same need for > a cast, no m

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Greg Hudson
On Mon, 2010-10-04 at 12:06 -0400, Julian Foad wrote: > The issue at hand is when NULL is defined as an unadorned '0' *and* is > passed to a variadic function such as apr_pstrcat. If that's not a > practical concern, that must be because the size and representation of > (int)0 is the same as (char

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Philip Martin
Stefan Sperling writes: > I think the warning is printed only for functions that are marked in > a special way that GCC looks for. > The svn_* functions don't have such markers. They don't have __attribute((sentinel)) but there is the same need for a cast, no more or less, than the function call

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Stefan Sperling
On Mon, Oct 04, 2010 at 10:05:48AM +0100, Philip Martin wrote: > s...@apache.org writes: > > > Author: stsp > > Date: Sun Oct 3 16:05:19 2010 > > New Revision: 1003986 > > > * subversion/mod_authz_svn/mod_authz_svn.c > > (get_access_conf, req_check_access, req_check_access): Use (const *)NULL

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Stefan Sperling
On Mon, Oct 04, 2010 at 09:42:01AM -0500, Hyrum K. Wright wrote: > On Mon, Oct 4, 2010 at 5:14 AM, Julian Foad wrote: > > I'm glad you are keen to keep only relevant warnings visible, but the > > sight of so many unnecessary casts in our code makes me squirm. :-( > > > > The NULL macro is intended

Re: [PATCH] Avoid allocating memory to extract basename using svn_relpath_basename

2010-10-04 Thread Kamesh Jayachandran
On 10/04/2010 05:52 PM, vijayaguru wrote: Hi, From svn_relpath_basename documentation, if pool is NULL, it simply returns a pointer to the string without allocating additional memory. Pass NULL pointer to svn_relpath_basename wherever the returned basename need not be persistent. It could sav

Re: [PATCH] -cM-N command line syntax

2010-10-04 Thread Julian Foad
On Mon, 2010-10-04 at 11:28 -0400, Paul Burba wrote: > On Sat, Oct 2, 2010 at 7:00 PM, Peter Samuelson wrote: [...] > > Hmmm, in tests/cmdline/log_tests.py XFail(log_chanage_range), I see > > Lieven thought -c might someday take ranges with ":" instead of "-". > > But since the output uses "-", I'

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Julian Foad
On Mon, 2010-10-04 at 11:14 -0400, Greg Hudson wrote: > On Mon, 2010-10-04 at 06:14 -0400, Julian Foad wrote: > > The NULL macro is intended for use as a pointer. > > Only when statically cast to the appropriate pointer type. This happens > automatically in many contexts, such as assignments or p

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Philip Martin
Julian Foad writes: > I'm glad you are keen to keep only relevant warnings visible, but the > sight of so many unnecessary casts in our code makes me squirm. :-( > > The NULL macro is intended for use as a pointer. When a combination of > compiler, system library headers and APR headers conspire

Re: [Merge request] Merge r985477 from performance branch

2010-10-04 Thread Ramkumar Ramachandra
Hi Julian, Julian Foad writes: > Hi Ram. I wasn't comfortable with giving a +1 for this change just > then, but now I've satisfied myself. The only potential negative impact > I can imagine is if a user has a very long-running instance of > Subversion and is accustomed to Subversion tracking cha

Re: [PATCH] -cM-N command line syntax

2010-10-04 Thread Paul Burba
On Sat, Oct 2, 2010 at 7:00 PM, Peter Samuelson wrote: > > So, in 1.3 or 1.4 we gained '-c' as a convenience for specifying > changesets as opposed to revision endpoints. Hi Peter, FWIW diff/merge gained -c in 1.4 and log got it in 1.5. > Then in 1.5 we got the > svn:mergeinfo property, which e

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Greg Hudson
On Mon, 2010-10-04 at 06:14 -0400, Julian Foad wrote: > The NULL macro is intended for use as a pointer. Only when statically cast to the appropriate pointer type. This happens automatically in many contexts, such as assignments or prototyped function parameters. But it does not happen automatic

Re: [PATCH] Enhancement to svnperms.py to read sections via regex

2010-10-04 Thread C. Michael Pilato
Are you saying, then, that you'd like us to disregard your patch for now? On 09/29/2010 08:50 AM, prabhugnanasundar wrote: > Mike, > Sorry for the delayed response. > Your point is very much a valid one, Mike. But since we used > *re.match*, "perf" would not match "superfun". But your po

Re: Some tips on profiling

2010-10-04 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Fuhrmann writes: > >I enabled it, but there's still some issue: > >subversion/svnadmin/main.c:1892: undefined reference to > >`svn_fs_get_cache_config' > > > It builds here. Did you run autogen.sh before ./configure? Yep, I did. I tried it several times again; same issue. Is th

Re: [Merge request] Merge r985477 from performance branch

2010-10-04 Thread Julian Foad
On Sun, 2010-10-03, Ramkumar Ramachandra wrote: > Hi Julian, > > Julian Foad writes: > > Looks good to me. > > > > I wondered if it is safe in a long-running Subversion process, like > > TortoiseSvn or a Linux equivalent. > > > > It seems to me that it won't really matter much in practice. If s

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Hyrum K. Wright
On Mon, Oct 4, 2010 at 5:14 AM, Julian Foad wrote: > On Mon, 2010-10-04, Philip Martin wrote: >> s...@apache.org writes: >> >> > Author: stsp >> > Date: Sun Oct  3 16:05:19 2010 >> > New Revision: 1003986 > > Quoting the log message: > >> > Starting with version 4, gcc has been printing irritating

Re: What happened to svndiff1

2010-10-04 Thread John Szakmeister
On Wed, Sep 29, 2010 at 9:50 AM, Ramkumar Ramachandra wrote: > Hi, > > I'd like to know what happened to svndiff version 1 format. All the > specs and code including notes/dump-load-format.txt seem to refer only > to svndiff0. This probably got answered somewhere else, but for the sake of complet

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Julian Foad
On Mon, 2010-10-04, Philip Martin wrote: > s...@apache.org writes: > > > Author: stsp > > Date: Sun Oct 3 16:05:19 2010 > > New Revision: 1003986 Quoting the log message: > > Starting with version 4, gcc has been printing irritating warnings about > > "missing sentinels in function call" for vi

[PATCH] Avoid allocating memory to extract basename using svn_relpath_basename

2010-10-04 Thread vijayaguru
Hi, From svn_relpath_basename documentation, if pool is NULL, it simply returns a pointer to the string without allocating additional memory. Pass NULL pointer to svn_relpath_basename wherever the returned basename need not be persistent. It could save few bytes of memory. [[[ Log: Pass NU

Re: svn commit: r1003986 [1/2] - in /subversion/trunk/subversion: libsvn_client/ libsvn_fs_base/ libsvn_fs_base/bdb/ libsvn_fs_fs/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsv

2010-10-04 Thread Philip Martin
s...@apache.org writes: > Author: stsp > Date: Sun Oct 3 16:05:19 2010 > New Revision: 1003986 > * subversion/mod_authz_svn/mod_authz_svn.c > (get_access_conf, req_check_access, req_check_access): Use (const *)NULL >as sentinel for apr_pstrcat(), instead of NULL. That should be "(char *)"

Re: svn commit: r1002271 - /subversion/trunk/subversion/include/svn_client.h

2010-10-04 Thread Julian Foad
On Tue, 2010-09-28, Daniel Shahaf wrote: > julianf...@apache.org wrote on Tue, Sep 28, 2010 at 17:16:59 -: > > Author: julianfoad > > Date: Tue Sep 28 17:16:59 2010 > > New Revision: 1002271 > > > > URL: http://svn.apache.org/viewvc?rev=1002271&view=rev > > Log: > > * subversion/include/svn_cl

FREE Apache Subversion Meetup: Thursday, November 4, at ApacheCon NA in Atlanta, GA

2010-10-04 Thread C. Michael Pilato
For those who don't know, ApacheCon North America comes to Atlanta, GA, November 1-5 this year. You can find out more about the conference via the official conference website at http://na.apachecon.com/c/acna2010/. In addition to a full slate of scheduled presentations, talks, training sessions, e