Re: [PATCH] Fix svnrdump test 27 on Windows

2010-10-07 Thread Ramkumar Ramachandra
Hi Gavin, Gavin Beau Baumanis writes: > Ping. This patch has received no comments. This patch has been committed. See r1003064- the directory baton is now allocated in `eb-pool`. I hoped that it would fix test 27, but it didn't- that is fixed in r1005035/ r1005050. Thanks for picking this up. -

[RFC] Diff (blame) optimization: how to go forward

2010-10-07 Thread Johan Corveleyn
Hi all, This is a follow-up to the WIP-patches I posted last week [1], which are about improving performance of svn_diff (and therefor also blame on the client-side), especially for large files. To summarize: the idea was (is) to strip off the identical prefix and suffix, and then letting the exi

Re: [PATCH] Fix svnrdump test 27 on Windows

2010-10-07 Thread Gavin Beau Baumanis
Ping. This patch has received no comments. Gavin "Beau" Baumanis On 30/09/2010, at 11:28 PM, Ramkumar Ramachandra wrote: > Hi, > > This is an experimental patch to fix svnrdump test 27 "dump: > subdirectory with changes on root" on Windows. It's experimental > because it's based simply on a

Re: [PATCH] fix @deprecated tags in header comments

2010-10-07 Thread Gavin Beau Baumanis
Ping. This patch has received no comments. Gavin "Beau" Baumanis On 27/09/2010, at 7:23 AM, Dani Church wrote: > This patch is a fix for some of the @deprecated tags in the Doxygen comments. > It standardizes them so that the phrasing "Provided for backward > compatibility with the 1.x API"

Re: [RFC] WC APIs for adding and copying

2010-10-07 Thread Greg Stein
On Thu, Oct 7, 2010 at 15:34, Julian Foad wrote: >... >  * For a repo->WC copy: > >    svn_wc_add_repos_file4()     # existing function >    svn_wc_add_repos_dir(depth)  # new function Please use "copy" in their name to better reflect the operation. Let's never use the term "add-with-history" and

Re: Problem with external file

2010-10-07 Thread Talden
> (Note to everybody else: Bob's decision to start testing 1.7, and > report bugs here, ensures that his bugs are known and (hopefully) > addressed before 1.7 ships.  Interested parties would do well to > follow his example. :) On this note. I'd been testing 1.7 using the binaries at: http:/

Re: [RFC] WC APIs for adding and copying

2010-10-07 Thread C. Michael Pilato
On 10/07/2010 03:34 PM, Julian Foad wrote: > I'm planning to remove/deprecate svn_wc_add4(), the many-headed beast, > and provide replacement functions that have more focused tasks. [...] > Any thoughts? Anything that can be done to make that multi-headed beast more maintainable would be a welco

[RFC] WC APIs for adding and copying

2010-10-07 Thread Julian Foad
I'm planning to remove/deprecate svn_wc_add4(), the many-headed beast, and provide replacement functions that have more focused tasks. I reached this point from trying to understand the different kinds of add and copy in order to sort out the "operation depth" field for the NODES table. I drew ou

Re: Problem with external file

2010-10-07 Thread Hyrum K. Wright
On Thu, Oct 7, 2010 at 9:09 AM, Bob Fletcher wrote: > Philip Martin wandisco.com> writes: > >> Ideally these would be commands we could execute using the command >> line client. Of even a script with these commands in it (though that isn't always feasible). > > > Thanks, Philip. > > I normally

Re: svn commit: r1003238 - in /subversion/trunk/subversion: svn/cl.h svn/propget-cmd.c svn/proplist-cmd.c svn/props.c tests/cmdline/prop_tests.py

2010-10-07 Thread Paul Burba
On Thu, Oct 7, 2010 at 8:09 AM, Julian Foad wrote: > Hi Paul. > > It's good to see a fix.  I think, however, you could do this more simply > and avoid some of the difficulties completely. Julian, Thanks as always for the review, comments inline. > On Thu, 2010-09-30, pbu...@apache.org wrote: >>

Re: Performance optimization - svn_stringbuf_appendbyte()

2010-10-07 Thread Philip Martin
Julian Foad writes: > This tells me that the hand-optimization is actually harmful and the > compiler does a 10% better job by itself. > > Have I made a mistake? > > What are the results for your system? > > (I'm using GCC 4.4.1 on an Intel Centrino laptop CPU.) On my system (Intel Core 2 Duo, G

Re: Problem with external file

2010-10-07 Thread Bob Fletcher
Philip Martin wandisco.com> writes: > Ideally these would be commands we could execute using the command > line client. Thanks, Philip. I normally use TortoiseSVN so I will have to spend some time seeing if/how this occurs with the command line client. Maybe I can get something this weekend.

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 2)

2010-10-07 Thread Daniel Trebbien
Hi Julian, Thank you for your note. Feel free to take all the time that you need. On Thu, Oct 7, 2010 at 7:09 AM, Julian Foad wrote: > Daniel, sorry I haven't looked at this yet, and won't be able to today. > > - Julian

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 2)

2010-10-07 Thread Julian Foad
Daniel, sorry I haven't looked at this yet, and won't be able to today. - Julian On Sun, 2010-10-03 at 11:55 -0700, Daniel Trebbien wrote: > On Fri, Oct 1, 2010 at 3:57 AM, Julian Foad wrote: > >> Adds a public API function, svn_subst_translate_string2(), an extension of > >> svn_subst_translat

Re: Performance optimization - svn_stringbuf_appendbyte()

2010-10-07 Thread Julian Foad
> New Revision: 997203 > > URL: http://svn.apache.org/viewvc?rev=997203&view=rev > Log: > Merge r985037, r985046, r995507 and r995603 from the performance branch. > > These changes introduce the svn_stringbuf_appendbyte() function, which has > significantly less overhead than svn_stringbuf_append

Re: [PATCH] gpg-agent configure fix.

2010-10-07 Thread Senthil Kumaran S
Hi Alex, Alexander Thomas wrote: [[[ On the 'gpg-agent-password-store' branch: * configure.ac: (SVN_HAVE_GPG_AGENT): Defines when --with-gpg-agent option passed to 'configure' ]]] Committed the patch in r1005433. Thank You. -- Senthil Kumaran S http://www.stylesen.org/

[PATCH] gpg-agent configure fix.

2010-10-07 Thread Alexander Thomas
[[[ On the 'gpg-agent-password-store' branch: * configure.ac: (SVN_HAVE_GPG_AGENT): Defines when --with-gpg-agent option passed to 'configure' ]]] Index: configure.ac === --- configure.ac (revision 1005331) +++ configure.ac

Re: svn commit: r1003238 - in /subversion/trunk/subversion: svn/cl.h svn/propget-cmd.c svn/proplist-cmd.c svn/props.c tests/cmdline/prop_tests.py

2010-10-07 Thread Julian Foad
Hi Paul. It's good to see a fix. I think, however, you could do this more simply and avoid some of the difficulties completely. On Thu, 2010-09-30, pbu...@apache.org wrote: > Author: pburba > Date: Thu Sep 30 20:21:19 2010 > New Revision: 1003238 > > URL: http://svn.apache.org/viewvc?rev=10032

Re: Format 20 upgrade to NODES

2010-10-07 Thread Philip Martin
Philip Martin writes: > I'd like to enable NODES as a replacement for BASE_NODE and > WORKING_NODE. This would involve bumping the format number, and old > working copies would get automatically upgraded. This has been committed to trunk. -- Philip

Re: Problem with external file

2010-10-07 Thread Philip Martin
Bob Fletcher writes: > To show the problem: > (1) Create a project with an external file. > (2) Modify and Commit a change to an actual working copy of the file > (in another project). > (3) Update the original project with the external file - even when > omitting externals. > This gives